[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-05-01 by santoshsinha100 · Pull Request #6620 · Azure/azure-rest-api-specs

santoshsinha100 · 2019-07-15T08:22:41Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…-01-01 to version 2019-05-01

Updated scope for Usage detail list

update

usage detail

syntax error fix

syntax fix

fixing syntax error

added scope parameter

scope added

added scope

json correction

syntax correction

added reservationRecommendation, RI Usage Summary and RI Usage details

syntax correction

bug fix

…on/stable/2019-05-01/examples/ReservationSummariesDaily.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

bug fix

…tps://github.com/santoshsinha100/azure-rest-api-specs into dev-consumption-Microsoft.Consumption-2019-05-01

bug fix

Bug fix

santoshsinha100 · 2019-07-17T18:31:15Z

Hi Nick,

Can you mark this item complete. I already addressed all your suggestions. We need this to roll out ASAP.

Thanks & Regards
Santosh

nschonni · 2019-07-17T19:19:55Z

Sorry, I'm not an MS employee, but I think there is instructions over here if you need to escalate https://armwiki.azurewebsites.net/rp_onboarding/ResourceProviderOnboardingAPIRevieworkflow.html

santoshsinha100 · 2019-07-19T21:22:45Z

Can some one please approve this PR. This is active since last 4 to 5 days.

ms-premp · 2019-07-22T17:30:07Z

We have preview version for usage details already merged in
#6575
We are moving this to GA and adding one more API in this GA version. Please review.

majastrz · 2019-07-30T22:52:24Z

"/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/microsoft.consumption/ReservationRecommendations": {

nit - should be camelCase

Refers to: specification/consumption/resource-manager/Microsoft.Consumption/stable/2019-05-01/consumption.json:968 in d04e302. [](commit_id = d04e302, deletion_comment = False)

majastrz · 2019-07-31T00:18:02Z

    "billingPeriodId": {

This is potentially an SDK breaking change. (When users update the current SDK to one generated from this Swagger, their code won't compile if they are referencing properties that got removed.) What's the plan to deal with that?

Refers to: specification/consumption/resource-manager/Microsoft.Consumption/stable/2019-05-01/consumption.json:1269 in 71e2dcb. [](commit_id = 71e2dcb, deletion_comment = True)

majastrz

Signed off from ARM side.

santoshsinha100 · 2019-08-01T01:34:28Z

Can some one do this review on priority. Its waiting for an approval

majastrz · 2019-08-01T02:23:15Z

Can some one do this review on priority. Its waiting for an approval

I'm confused by this. Normally a person from the SDK team is assigned to a PR like this and they finish the review from the SDK side once ARM (me this week) signs off. I'll send an email to a contact I know internally (I don't know her GitHub name to just @ mention here.)

majastrz · 2019-08-01T02:25:30Z

If you reach out to me directly via Teams (alias is same as my github name), I can add you to the mail thread.

yungezz

looks good, some minor issue in samples. @santoshsinha100 could you pls resolve conflict? then I'll go to approve and merge the PR.

yungezz · 2019-08-01T02:55:09Z

+          ],
+          "excludedSubscriptions": [],
+          "usageStart": "2019-05-01T00:00:00.0000000Z",
+          "usageEnd": "2018-10-31T00:00:00.0000000Z",


usageStart is later than usageEnd

Hi I am unable to resolve the conflict in readme.md file. UI doesn't allow me to resolve. Looking at the conflict, I will go with "### Tag: package-2019-05" not the preview one. Will it be possible to get this resolved at your end .

yungezz · 2019-08-01T02:57:53Z

+    "api-version": "2019-05-01",
+    "billingAccountId": "1234",
+    "departmentId": "42425",
+	"scope": "providers/Microsoft.Billing/BillingAccounts/1234",


minor, indention

…-05-01

openapi-sdkautomation · 2019-08-05T05:27:53Z

In Testing, Please Ignore

[Logs] (Generated from 052f9db, Iteration 1)

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

consumption/mgmt/2017-11-30 [Logs]
consumption/mgmt/2018-01-31 [Logs]
consumption/mgmt/2018-03-31 [Logs]
consumption/mgmt/2018-05-31 [Logs]
consumption/mgmt/2018-06-30 [Logs]
consumption/mgmt/2018-08-31 [Logs]
consumption/mgmt/2018-10-01 [Logs]
consumption/mgmt/2019-01-01 [Logs]
preview/consumption/mgmt/2017-04-24-preview [Logs]
preview/consumption/mgmt/2017-12-30-preview [Logs]

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-consumption [Logs] [Instructions] [Generation PR]
- azure-mgmt-consumption-3.0.0.zip
- azure_mgmt_consumption-3.0.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

consumption/resource-manager/v2017_04_24_preview [Logs]
consumption/resource-manager/v2017_11_30 [Logs]
consumption/resource-manager/v2018_01_31 [Logs]
consumption/resource-manager/v2018_03_31 [Logs]
consumption/resource-manager/v2018_05_31 [Logs]
consumption/resource-manager/v2018_06_30 [Logs]
consumption/resource-manager/v2018_08_31 [Logs]
consumption/resource-manager/v2018_10_01 [Logs]
consumption/resource-manager/v2019_01_01 [Logs]

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-consumption [Logs]

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

No packages generated.

yungezz · 2019-08-05T05:30:02Z

@santoshsinha100 pls look at the resolved readme.md file. pls update the tag package-preview-2019-05 to package-2019-05 at https://github.com/Azure/azure-rest-api-specs/pull/6620/files#diff-19989b3082cb3c89e63e9903a79a80b6R40 to

yungezz

pls review change in readme.md for conflict resolving, and update tag name per need.

ms-premp

Thanks @yungezz. Your ReadMe changes looks good.

santoshsinha100 added 29 commits July 11, 2019 20:19

Adds base for updating Microsoft.Consumption from version stable/2019…

71e2dcb

…-01-01 to version 2019-05-01

Updates readme

037ada6

Updates API version in new specs and examples

31e6fa4

Updated scope for Usage detail list

88ecde3

Updated scope for Usage detail list

Update UsageDetailsList.json

faca65d

update

Update UsageDetailsList.json

1420327

usage detail

Update BudgetsList.json

db17122

syntax error fix

Update UsageDetailsList.json

7b45b10

syntax fix

fixing syntax error

b949996

fixing syntax error

added scope parameter

40b87bf

added scope parameter

scope added

a422c46

scope added

added scope

08b2b2b

added scope

added scope

5cbdfba

added scope

added scope

9492159

added scope

Update Budget.json

c5bfb87

added scope

added scope

cc1f6f2

added scope

added scope

47da520

added scope

added scope

fa66189

added scope

json correction

de22a9c

json correction

syntax correction

9ee8c70

syntax correction

added reservationRecommendation, RI Usage Summary and RI Usage details

0637fa7

added reservationRecommendation, RI Usage Summary and RI Usage details

syntax correction

d6b335f

syntax correction

bug fix

d57b0c3

bug fix

bug fix

b95e703

bug fix

bug fix

4d48f7e

bug fix

bug fix

c0f05dc

bug fix

bug fix

02e3236

bug fix

bug fix

41d751b

bug fix

bug fix

9d3e764

bug fix

santoshsinha100 requested a review from kjeur as a code owner July 15, 2019 08:22

Update specification/consumption/resource-manager/Microsoft.Consumpti…

b4ed81a

…on/stable/2019-05-01/examples/ReservationSummariesDaily.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

nschonni reviewed Jul 16, 2019

View reviewed changes

Comment thread ...cation/consumption/resource-manager/Microsoft.Consumption/stable/2019-05-01/consumption.json Outdated

santoshsinha100 added 4 commits July 15, 2019 19:43

bug fix

0708eec

bug fix

Merge branch 'dev-consumption-Microsoft.Consumption-2019-05-01' of ht…

4045e81

…tps://github.com/santoshsinha100/azure-rest-api-specs into dev-consumption-Microsoft.Consumption-2019-05-01

bug fix

9c70c56

bug fix

Bug fix

d04e302

Bug fix

santoshsinha100 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2019

majastrz added the potential-sdk-breaking-change label Jul 31, 2019

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Jul 31, 2019

majastrz approved these changes Jul 31, 2019

View reviewed changes

yungezz reviewed Aug 1, 2019

View reviewed changes

yungezz self-assigned this Aug 2, 2019

Merge branch 'master' into dev-consumption-Microsoft.Consumption-2019…

052f9db

…-05-01

yungezz requested changes Aug 5, 2019

View reviewed changes

ms-premp approved these changes Aug 5, 2019

View reviewed changes

yungezz approved these changes Aug 6, 2019

View reviewed changes

yungezz merged commit 815d420 into Azure:master Aug 6, 2019

Conversation

santoshsinha100 commented Jul 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

Uh oh!

santoshsinha100 commented Jul 17, 2019

Uh oh!

nschonni commented Jul 17, 2019

Uh oh!

santoshsinha100 commented Jul 19, 2019

Uh oh!

ms-premp commented Jul 22, 2019

Uh oh!

majastrz commented Jul 30, 2019

Uh oh!

majastrz commented Jul 31, 2019

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

santoshsinha100 commented Aug 1, 2019

Uh oh!

majastrz commented Aug 1, 2019

Uh oh!

majastrz commented Aug 1, 2019

Uh oh!

yungezz left a comment

Choose a reason for hiding this comment

Uh oh!

yungezz Aug 1, 2019

Choose a reason for hiding this comment

Uh oh!

santoshsinha100 Aug 3, 2019

Choose a reason for hiding this comment

Uh oh!

yungezz Aug 1, 2019

Choose a reason for hiding this comment

Uh oh!

openapi-sdkautomation Bot commented Aug 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 052f9db, Iteration 1)

Uh oh!

yungezz commented Aug 5, 2019

Uh oh!

yungezz left a comment

Choose a reason for hiding this comment

Uh oh!

ms-premp left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

santoshsinha100 commented Jul 15, 2019 •

edited

Loading

openapi-sdkautomation Bot commented Aug 5, 2019 •

edited

Loading