Skip to content

support teradata dataset in adf#6568

Merged
raych1 merged 2 commits intoAzure:masterfrom
xiaoyingQQ:xiaoyz/AddTeradataDataset
Jul 17, 2019
Merged

support teradata dataset in adf#6568
raych1 merged 2 commits intoAzure:masterfrom
xiaoyingQQ:xiaoyz/AddTeradataDataset

Conversation

@xiaoyingQQ
Copy link
Copy Markdown
Contributor

@xiaoyingQQ xiaoyingQQ commented Jul 9, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jul 9, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 4e54925)

Failed Python: Azure/azure-sdk-for-python [Logs]
  • No packages generated.
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: Azure/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.

@azuresdkci azuresdkci requested a review from raych1 July 9, 2019 05:56
@AutorestCI AutorestCI mentioned this pull request Jul 9, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 9, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5747

@AutorestCI AutorestCI mentioned this pull request Jul 9, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 9, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5269

@AutorestCI AutorestCI mentioned this pull request Jul 9, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 9, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3084

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Jul 9, 2019

Can one of the admins verify this patch?

raych1
raych1 reviewed Jul 9, 2019
View reviewed changes
Comment thread ...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json
}
}
},
"TeradataTableDataset": {
Copy link
Copy Markdown
Member

@raych1 raych1 Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of new definitions added in this PR are not referenced anywhere in datafactory.json. What's the purpose to add them?

Copy link
Copy Markdown
Contributor Author

@xiaoyingQQ xiaoyingQQ Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used to help customer create Teradata Table Dataset. It is based on "Dataset", and it will be used in pipeline.

raych1
raych1 reviewed Jul 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these new changes being used in API?

@xiaoyingQQ
Copy link
Copy Markdown
Contributor Author

xiaoyingQQ commented Jul 12, 2019

Yes

@raych1 raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 12, 2019
@AutorestCI AutorestCI mentioned this pull request Jul 12, 2019
Merged
KrisBash
KrisBash approved these changes Jul 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns with the definitions defined, although it is unclear to me how they are used if not referenced in API request/response

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 16, 2019
@raych1 raych1 merged commit 6b8f592 into Azure:master Jul 17, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@xiaoyingQQ @celikcigdem
support teradata dataset in adf (Azure#6568)
b3eaa77 
* support teradata dataset in adf

* remove Teradata linked service required property
@hvermis hvermis mentioned this pull request Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raych1 raych1 raych1 left review comments

+1 more reviewer

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@raych1 raych1

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xiaoyingQQ @AutorestCI @azuresdkci @KrisBash @raych1 @hbzhxying