[media] Fix "sync_keys" and "regenerate_key"#654
[media] Fix "sync_keys" and "regenerate_key"#654lmazuel wants to merge 4 commits intoAzure:masterfrom lmazuel:media_fix
Conversation
BrianBlum
left a comment
There was a problem hiding this comment.
Need to also trim the comma after "OK"
|
@johanste There is no breaking change here:
|
|
@lmazuel, switching a property from not required to required may be a breaking changes in some languages. We are just spinning up the breaking change review/notification process, and as of now, we are applying the tag if we think that something could be breaking in an SDK. Meaning we do expect false positives at the moment. However, we very much appreciate your confirmation that this will not be breaking for the Python SDK :) |
|
Adding "id" as required for "sync" |
|
@amarzavery @johanste @BrianBlum FYI:
|
|
@BrianBlum - I think the changes made in this PR are also made in #698. Hence, I think it will be safe to close this PR and let the other one get merged with all the changes. |
https://msdn.microsoft.com/en-us/library/azure/mt750386.aspx
https://msdn.microsoft.com/en-us/library/azure/mt750388.aspx
@amarzavery @BrianBlum for review
This change is