Skip to content

introducing the SqlManagement in Microsoft.SqlVirtualMachine#6524

Merged
praries880 merged 7 commits intoAzure:masterfrom
SeliuMSFT:seliu-sqlvirtualmachine-Microsoft.SqlVirtualMachine-2017-03-01-preview
Jul 2, 2019
Merged

introducing the SqlManagement in Microsoft.SqlVirtualMachine#6524
praries880 merged 7 commits intoAzure:masterfrom
SeliuMSFT:seliu-sqlvirtualmachine-Microsoft.SqlVirtualMachine-2017-03-01-preview

Conversation

@SeliuMSFT
Copy link
Contributor

@SeliuMSFT SeliuMSFT commented Jul 1, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@SeliuMSFT SeliuMSFT requested a review from yareyes July 1, 2019 20:58
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2019

SDK Automation [Logs] (Generated from f26d0f7)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jul 1, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jul 1, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5768

@AutorestCI
Copy link

AutorestCI commented Jul 1, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 1, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5180

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@SeliuMSFT
Copy link
Contributor Author

SeliuMSFT commented Jul 1, 2019

@praries880 could you help to take a look at this change? we need to this out sooner than later to unblock an announcement this week.

@nschonni
Copy link
Contributor

nschonni commented Jul 2, 2019

If you want to use "LUNs" instead of "LUN", you might need to add the word to https://github.com/Azure/azure-rest-api-specs/blob/master/custom-words.txt

@praries880
Copy link

@praries880 praries880 merged commit 8a69874 into Azure:master Jul 2, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
)

* introducing the SqlManagement

* update the type.

* fixing the typo for LUN

* fixing the LUNs again.

* fixing the lun

* update the LUNs to LUN

* Fixing the LUNs to LUN again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants