Skip to content

Conversation

@reshantchandra
Copy link
Contributor

@reshantchandra reshantchandra commented Jun 27, 2019

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 27, 2019

SDK Automation [Logs] (Generated from b11a3ac)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6195

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2696

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5178

@AutorestCI
Copy link

AutorestCI commented Jun 27, 2019

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3115

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@jhendrixMSFT jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 27, 2019
Copy link
Member

@jlian jlian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had more examples we needed to change?

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 1, 2019
@jhendrixMSFT jhendrixMSFT merged commit 54094bf into Azure:master Jul 1, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
…review/2019-03-22-preview (Azure#6479)

* adding locations property to iothub properties

* adding locations property to iothub properties

* adding locations property to iothub properties

* adding locations property to iothub properties

* adding locations property to iothub properties

* adding locations property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants