Skip to content

[Hub Generated] Review request for Microsoft.Portal to add version preview/2015-08-01-preview#6470

Merged
praries880 merged 8 commits intoAzure:masterfrom
jjbfour:dev-portal-Microsoft.Portal-add-api-version
Jul 12, 2019
Merged

[Hub Generated] Review request for Microsoft.Portal to add version preview/2015-08-01-preview#6470
praries880 merged 8 commits intoAzure:masterfrom
jjbfour:dev-portal-Microsoft.Portal-add-api-version

Conversation

@jjbfour
Copy link
Contributor

@jjbfour jjbfour commented Jun 26, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 26, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from ac6f48c, Iteration 8)

Failed Python: Azure/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: Azure/azure-sdk-for-java [Logs]
  • No packages generated.
Failed Go: Azure/azure-sdk-for-go [Logs]
  • No packages generated.
Failed JavaScript: Azure/azure-sdk-for-js [Logs]
  • No packages generated.
Failed Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5240

@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5670

@azuresdkci azuresdkci requested a review from NelsonDaniel June 26, 2019 22:32
@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2686

@AutorestCI
Copy link

AutorestCI commented Jun 26, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

azuresdkci commented Jun 26, 2019

Can one of the admins verify this patch?

@jjbfour
Copy link
Contributor Author

jjbfour commented Jun 27, 2019

This is just adding a new API version there is no change from the previous version

@jjbfour
Copy link
Contributor Author

jjbfour commented Jun 27, 2019

@NelsonDaniel can you take a look? It looks like the GO sdk is failing because its not under preview folder, but its under preview currently.

@NelsonDaniel NelsonDaniel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 28, 2019
NelsonDaniel
NelsonDaniel suggested changes Jun 28, 2019
View reviewed changes
@jjbfour jjbfour requested a review from NelsonDaniel June 28, 2019 21:05
@NelsonDaniel
Copy link

NelsonDaniel commented Jul 1, 2019

@jjbfour the readme.go.md is missing the output-folder configuration for 'package-preview-2015-08'

@azuresdkci azuresdkci assigned praries880 and unassigned NelsonDaniel Jul 5, 2019
@azuresdkci azuresdkci requested a review from praries880 July 5, 2019 20:26
@jjbfour jjbfour mentioned this pull request Jul 8, 2019
Closed
anthony-c-martin
anthony-c-martin requested changes Jul 8, 2019
View reviewed changes
@anthony-c-martin anthony-c-martin removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 8, 2019
@anthony-c-martin anthony-c-martin added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 8, 2019
@praries880
Copy link

praries880 commented Jul 9, 2019

@jhendrixMSFT Can you kindly look at why is the go SDK generation breaking?

It says (link : https://dev.azure.com/azure-sdk/public/_build/results?buildId=61172&view=logs&j=ca30ae81-48c9-59ef-f3b5-00f8d328b667&t=c9bd2211-4c27-5895-a82d-bcc52dd2dab9&l=141) :

INFO:swaggertosdk.autorest_tools:FATAL: System.InvalidOperationException: codegen for preview swagger Microsoft.Portal/preview/2015-08-01-preview/portal.json must be under a preview subdirectory

but I see that the go sdk readme file already mentioned preview folder : https://github.com/Azure/azure-rest-api-specs/pull/6470/files#diff-87dc3751cf63ed02e8a3781c601f2950R18

@praries880
Copy link

praries880 commented Jul 9, 2019

@jjbfour reason for the go SDK failure :

in readme.md it's package-preview-2015-08
but in readme.go.md it's package-2015-08-01-preview

Thanks @jhendrixMSFT for looking into this :)

@AutorestCI AutorestCI mentioned this pull request Jul 10, 2019
Merged
@jjbfour
Copy link
Contributor Author

jjbfour commented Jul 10, 2019

@praries880 Thanks for taking the time to look. I think I fixed the errors. When you get a chance, can you take another look.

@praries880
Copy link

praries880 commented Jul 11, 2019

@sergey-shandar can you kindly merge this change in? I cant since @NelsonDaniel needs to approve this as well.

@praries880 praries880 merged commit 4812740 into Azure:master Jul 12, 2019
@anthony-c-martin anthony-c-martin mentioned this pull request Jul 15, 2019
Merged
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@jjbfour @celikcigdem
[Hub Generated] Review request for Microsoft.Portal to add version pr…
5270331 
…eview/2015-08-01-preview (Azure#6470)

* Adds base for updating Microsoft.Portal from version preview/2015-11-01-preview to version 2015-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add object type to each of the definitions

* Remove old api version and update to have the correct api-version

* Fix readme for sdk generation

* Fix auto rest version generation

* update the preview version for dashboards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

@NelsonDaniel NelsonDaniel Awaiting requested review from NelsonDaniel

+2 more reviewers

@sergey-shandar sergey-shandar sergey-shandar left review comments

@praries880 praries880 praries880 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@praries880 praries880

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jjbfour @AutorestCI @azuresdkci @NelsonDaniel @praries880 @sergey-shandar @anthony-c-martin