Skip to content

Adding Maintenance RP, Private Preview PR https://github.com/Azure/azure-rest-api-specs-pr/pull/482#6469

Merged
sergey-shandar merged 5 commits into
Azure:masterfrom
abkmr:master
Aug 30, 2019
Merged

Adding Maintenance RP, Private Preview PR https://github.com/Azure/azure-rest-api-specs-pr/pull/482#6469
sergey-shandar merged 5 commits into
Azure:masterfrom
abkmr:master

Conversation

@abkmr

@abkmr abkmr commented Jun 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation

openapi-sdkautomation Bot commented Jun 26, 2019 •
edited
Loading

Copy link
Copy Markdown

In Testing, Please Ignore

[Logs] (Generated from 54eb326, Iteration 8)

Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

@AutorestCI

AutorestCI commented Jun 26, 2019 •
edited
Loading

Copy link
Copy Markdown

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI

AutorestCI commented Jun 26, 2019 •
edited
Loading

Copy link
Copy Markdown

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7019

@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Closed
@AutorestCI

AutorestCI commented Jun 26, 2019 •
edited
Loading

Copy link
Copy Markdown

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5666

@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Closed
@AutorestCI

AutorestCI commented Jun 26, 2019 •
edited
Loading

Copy link
Copy Markdown

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci

azuresdkci commented Jun 26, 2019

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 9, 2019
@KrisBash

KrisBash commented Jul 15, 2019

Copy link
Copy Markdown
Contributor

Please schedule a meeting with arm api review for new RP

@sergey-shandar

sergey-shandar commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

@abkmr any progress on ARM review?

This was referenced Aug 16, 2019
Merged
Merged
@abkmr abkmr changed the title Adding Maintenance RP Adding Maintenance RP, Private Preview PR https://github.com/Azure/azure-rest-api-specs-pr/pull/482 Aug 16, 2019
@abkmr

abkmr commented Aug 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@abkmr any progress on ARM review?

Hi Sergey, the Microsoft.Maintenance RP Manifest has already been reviewed in the Private spec repo. See PR https://github.com/Azure/azure-rest-api-specs-pr/pull/482. We have already had API spec review as well with API review board which included KrisBash and Gaurav Bhatnagar. We are now moving from Private Preview to Public preview and hence need to publish to the public ARM spec repo.

@yungezz

yungezz commented Aug 28, 2019

Copy link
Copy Markdown
Member

Hi @abkmr could you pls get ARM team members lable the PR as ARMSignedOff, then we can merge it?

@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewMeetingRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 30, 2019
@sergey-shandar sergey-shandar merged commit 081caca into Azure:master Aug 30, 2019
@abkmr abkmr mentioned this pull request Sep 7, 2019
Merged
isra-fel pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Sep 11, 2019
@abkmr @isra-fel
Adding Maintenance RP .NET SDK, ARM Swagger PR Azure/azure-rest-api-s…
ed45d2b 
…pecs#6469 (#7485)

* Adding Maintenance RP .NET SDK

* Updating Maintenance RP

* updating maintenance rp

* updating pr with tests and new paths

* resolving failure

* test updates

* delete the metadata file that's in wrong place
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
@jinghzhu-msft
Rename Grafana service in desc (Azure#6469)
c4ca570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sergey-shandar sergey-shandar sergey-shandar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@abkmr @AutorestCI @azuresdkci @KrisBash @sergey-shandar @yungezz @anthony-c-martin