Added link to definition schema #6448

tfitzmac · 2019-06-25T17:29:56Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

[X ] I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-06-25T17:29:57Z

SDK Automation [Logs] (Generated from 1d88bc5)

Python: Azure/azure-sdk-for-python [Logs] [Diff]

sdk/logic/azure-mgmt-logic [Logs] [Instructions]
- azure-mgmt-logic-4.0.0rc2.zip
- azure_mgmt_logic-4.0.0rc2-py2.py3-none-any.whl

Java: Azure/azure-sdk-for-java [Logs] [Diff]

logic/resource-manager/v2016_06_01 [Logs] [Instructions]
logic/resource-manager/v2018_07_01_preview [Logs] [Instructions]

Go: Azure/azure-sdk-for-go [Logs] [Diff]

logic/mgmt/2016-06-01 [Logs] [Instructions]
- logic.mgmt.2016-06-01.zip
preview/logic/mgmt/2015-02-01-preview [Logs] [Instructions]
- preview.logic.mgmt.2015-02-01-preview.zip
preview/logic/mgmt/2015-08-01-preview [Logs] [Instructions]
- preview.logic.mgmt.2015-08-01-preview.zip
preview/logic/mgmt/2018-07-01-preview [Logs] [Instructions]
- preview.logic.mgmt.2018-07-01-preview.zip

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@azure/arm-logic [Logs] [Instructions]
- azure-arm-logic-6.0.1.tgz

Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.27.0.gem
data/logic [Logs]

AutorestCI · 2019-06-25T17:31:06Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout a88a1a6cfc490465e38b8378787474203370f808
  stderr: 'fatal: reference is not a tree: a88a1a6cfc490465e38b8378787474203370f808'

tfitzmac · 2019-06-25T17:31:34Z

@ecfan - I have updated the description for the logic app definition property based on feedback from reference docs.

azuresdkci · 2019-06-25T17:31:41Z

Can one of the admins verify this patch?

AutorestCI · 2019-06-25T17:31:58Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2656

AutorestCI · 2019-06-25T17:34:52Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout a88a1a6cfc490465e38b8378787474203370f808
  stderr: 'fatal: reference is not a tree: a88a1a6cfc490465e38b8378787474203370f808'

AutorestCI · 2019-06-25T17:37:08Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#4006

jhendrixMSFT · 2019-06-26T17:17:19Z

@AutorestCI regenerate azure-sdk-for-go

ecfan · 2019-06-27T02:25:52Z

@tfitzmac, looks good? Thanks!

zikalino

the ci failure seems to be unrelated

zikalino · 2019-06-28T16:12:41Z

@pankajsn @tonytang-microsoft-com
please confirm adding this link is ok.

tfitzmac · 2019-07-15T23:58:14Z

@pankajsn or @tonytang-microsoft-com - can this PR be merged? It was submitted in response to customer confusion about how to set the values.

zikalino · 2019-07-29T02:01:50Z

I am going to merge this PR soon, just need to figure out why CI is failing now....

tfitzmac · 2019-07-29T18:58:29Z

Resubmitted this change in #6772

Added link to definition schema

1d88bc5

azuresdkci assigned zikalino Jun 25, 2019

azuresdkci requested a review from zikalino June 25, 2019 17:30

AutorestCI mentioned this pull request Jun 25, 2019

[AutoPR logic/resource-manager] Added link to definition schema Azure/azure-sdk-for-python#6081

Closed

AutorestCI mentioned this pull request Jun 25, 2019

[AutoPR logic/resource-manager] Added link to definition schema Azure/azure-sdk-for-ruby#2680

Closed

AutorestCI mentioned this pull request Jun 25, 2019

[AutoPR logic/resource-manager] Added link to definition schema Azure/azure-sdk-for-go#5104

Closed

AutorestCI mentioned this pull request Jun 25, 2019

[AutoPR logic/resource-manager] Added link to definition schema Azure/azure-sdk-for-java#4103

Closed

AutorestCI mentioned this pull request Jun 26, 2019

[AutoPR logic/resource-manager] Added link to definition schema Azure/azure-sdk-for-go#5129

Closed

zikalino approved these changes Jun 27, 2019

View reviewed changes

tfitzmac closed this Jul 29, 2019

Added link to definition schema #6448

Added link to definition schema #6448

Uh oh!

Conversation

tfitzmac commented Jun 25, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from 1d88bc5)

Uh oh!

AutorestCI commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

tfitzmac commented Jun 25, 2019

Uh oh!

azuresdkci commented Jun 25, 2019

Uh oh!

AutorestCI commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

jhendrixMSFT commented Jun 26, 2019

Uh oh!

ecfan commented Jun 27, 2019

Uh oh!

zikalino left a comment

Choose a reason for hiding this comment

Uh oh!

zikalino commented Jun 28, 2019

Uh oh!

tfitzmac commented Jul 15, 2019

Uh oh!

zikalino commented Jul 29, 2019

Uh oh!

tfitzmac commented Jul 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openapi-sdkautomation bot commented Jun 25, 2019 •

edited

Loading

AutorestCI commented Jun 25, 2019 •

edited

Loading

AutorestCI commented Jun 25, 2019 •

edited

Loading

AutorestCI commented Jun 25, 2019 •

edited

Loading

AutorestCI commented Jun 25, 2019 •

edited

Loading