Skip to content

More examples improvements#6444

Merged
sergey-shandar merged 1 commit intoAzure:network-may-releasefrom
EvgenyAgafonchikov:more-ex
Jun 25, 2019
Merged

More examples improvements#6444
sergey-shandar merged 1 commit intoAzure:network-may-releasefrom
EvgenyAgafonchikov:more-ex

Conversation

@EvgenyAgafonchikov
Copy link
Contributor

@EvgenyAgafonchikov EvgenyAgafonchikov commented Jun 25, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpeq1xwvi9/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpeq1xwvi9/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4384/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4384)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[27901:0x344bcc0]    80892 ms: Mark-sweep 1377.9 (1425.1) -> 1377.5 (1425.1) MB, 2264.6 / 0.0 ms  (average mu = 0.091, current mu = 0.001) allocation failure scavenge might not succeed
[27901:0x344bcc0]    83220 ms: Mark-sweep 1378.4 (1425.1) -> 1378.0 (1425.6) MB, 2324.6 / 0.0 ms  (average mu = 0.046, current mu = 0.001) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x8608fadbe1d]
Security context: 0x01f883f9e6e9 <JSObject>
    1: IdentitySourceMapping [0x3beacca92571] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4384/node_modules/@microsoft.azure/autorest-core/dist/lib/source-map/merging.js:~189] [pc=0x86090047b5e](this=0x2e8af3df1f89 <Object map = 0x1898835570d9>,sourceYamlFileName=0x07887a0c47a1 <String[30]: mem:///2724?code-model-v1.yaml>,sourceYamlAst=0x180e8f382721 ...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea0466 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [node]
11: 0xea0cea v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [node]
12: 0xea12a7 v8::internal::Factory::NewUninitializedFixedArray(int, v8::internal::PretenureFlag) [node]
13: 0xe5462f  [node]
14: 0x10fa57d v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [node]
15: 0x8608fadbe1d

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpdrdqux_z/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpdrdqux_z/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.133', '--use-onever', '--verbose']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Including configuration file 'file:///tmp/tmpdrdqux_z/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.133->2.1.133)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-02"} .
   Including configuration file 'file:///tmp/tmpdrdqux_z/rest/specification/network/resource-manager/readme.go.md'

<--- Last few GCs --->

[13316:0x233d8c0]   127442 ms: Mark-sweep 1387.3 (1476.9) -> 1387.3 (1476.9) MB, 2383.3 / 0.0 ms  allocation failure GC in old space requested
[13316:0x233d8c0]   129660 ms: Mark-sweep 1387.3 (1476.9) -> 1387.3 (1439.4) MB, 2218.3 / 0.0 ms  last resort GC in old space requested
[13316:0x233d8c0]   131842 ms: Mark-sweep 1387.3 (1439.4) -> 1387.3 (1435.9) MB, 2181.0 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x2900206a5879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0xde993e0d209](this=0x2fe8cf9202f1 <JSWeakMap>,key=0xb47b22f9a71 <Object map = 0x32a349b1d849>,value=0xc7bb5fc90c9 <String[6]: String>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0xde993c69919](this=0x2d90143822d1 <und...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0xde993b042fd

@azuresdkci
Copy link
Contributor

azuresdkci commented Jun 25, 2019

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@sergey-shandar sergey-shandar merged commit d19ecfd into Azure:network-may-release Jun 25, 2019
sergey-shandar pushed a commit that referenced this pull request Jul 16, 2019
@anton-evseev @sergey-shandar
Merge Network release branch into master (#6632)
737110f 
* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01

* Updates readme

* Updates API version in new specs and examples

* Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (#6164)

* Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties.

* Fixed LB examples

* Fix examples in 2019-06-01

* Remove API version number in privateIPAddressVersion description.

* Add privateIPAddressVersion in LoadBalancer examples.

* Add privateIPAddressVersion in 2019-06-01 API version.

* Update specs to avoid readOnly in the request body (#6228)

* typo: netowork May double word the (#6206)

* Update cipher suites (#6213)

* removing resource group name from PrepareNetworkPoliciesRequest (#6232)

* Add exception for property "Conditon" in Network's webapplicationfirewall.json (#6335)

* Extend long-running ops fixes to new API version; Suppression (#6336)

* Update long-running for new API version

* Add suppression for new API

* Updated examples to have valid bodies for live put (#6349)

* More examples fix after live testing (#6382)

* Improved more examples after live testing

* Fix validations

* Improve descriptions in Network to align with Swagger guidelines (#6350)

* Improve descriptions in Network to align with Swagger guidelines

* Fix for CI

* More examples improvements (#6444)

* Add PATCH to Azure Firewall supported operations (#6486)

* Add PATCH to Azure Firewall supported operations

* Name the parameter how validation expects it

* Patch is not a long running operation, so update the specs accordingly

* PrivateEndpoint & PrivateLinkService APIs update (#6332)

* Add two properties on Subnet for privateIp. Add two new APIs to support privateIp.

Minor modify on readme.md file.

* Fix some issue found by Model Validation.

* Merge all apis relative to private end point / private link service to its json file.

* Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property.

* Change AutoApprovedPrivateLinkService structure to fit with NRP side.

* Delete suppress for merged APIs in readme.md.

* 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect.
2. Change opertaion id for opertaions that relative to private endpoint and private link service.

* Minor fix for model validation.

* Revert opertion id changes for AvailablePrivateEndpointType to previous name.

* 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string.
2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter.

* Improve Network's examples (#6493)

* Removed read-only props from VPNGW example

* Fixed LoadBalancer examples:
* "outboundRules" array isn't returned for "Basic" SKU load balancer
* added example for external LB with outboundRules
* added missing read-only properties

* Replace "regionName" in examples with real location

* Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer

* chore: jsonfmt network (#6592)

* Adding VpnSiteLink and VpnSiteLinkConnection properties. (#6528)

* Added VpnSiteLink/VpnSiteLinkConnection operations.

* Sdk changes for vpn site link.

* Fixing error.

* Fixing more comments.

* Fixing json error.

* Fixing json files.

* Fixing comments.

* Fixing more issues.

* Fixing more errors.

* Fixing more error.

* Prettify JSON in VpnConnectionGet.json

* Resolving more comments.

* Fixing typo.

* Adding type in examples of put.

* Removing Child resource type.

* chore: jsonfmt network-may

* Fix incorrect examples
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@anton-evseev @celikcigdem
Merge Network release branch into master (Azure#6632)
cd19c2b 
* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01

* Updates readme

* Updates API version in new specs and examples

* Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (Azure#6164)

* Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties.

* Fixed LB examples

* Fix examples in 2019-06-01

* Remove API version number in privateIPAddressVersion description.

* Add privateIPAddressVersion in LoadBalancer examples.

* Add privateIPAddressVersion in 2019-06-01 API version.

* Update specs to avoid readOnly in the request body (Azure#6228)

* typo: netowork May double word the (Azure#6206)

* Update cipher suites (Azure#6213)

* removing resource group name from PrepareNetworkPoliciesRequest (Azure#6232)

* Add exception for property "Conditon" in Network's webapplicationfirewall.json (Azure#6335)

* Extend long-running ops fixes to new API version; Suppression (Azure#6336)

* Update long-running for new API version

* Add suppression for new API

* Updated examples to have valid bodies for live put (Azure#6349)

* More examples fix after live testing (Azure#6382)

* Improved more examples after live testing

* Fix validations

* Improve descriptions in Network to align with Swagger guidelines (Azure#6350)

* Improve descriptions in Network to align with Swagger guidelines

* Fix for CI

* More examples improvements (Azure#6444)

* Add PATCH to Azure Firewall supported operations (Azure#6486)

* Add PATCH to Azure Firewall supported operations

* Name the parameter how validation expects it

* Patch is not a long running operation, so update the specs accordingly

* PrivateEndpoint & PrivateLinkService APIs update (Azure#6332)

* Add two properties on Subnet for privateIp. Add two new APIs to support privateIp.

Minor modify on readme.md file.

* Fix some issue found by Model Validation.

* Merge all apis relative to private end point / private link service to its json file.

* Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property.

* Change AutoApprovedPrivateLinkService structure to fit with NRP side.

* Delete suppress for merged APIs in readme.md.

* 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect.
2. Change opertaion id for opertaions that relative to private endpoint and private link service.

* Minor fix for model validation.

* Revert opertion id changes for AvailablePrivateEndpointType to previous name.

* 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string.
2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter.

* Improve Network's examples (Azure#6493)

* Removed read-only props from VPNGW example

* Fixed LoadBalancer examples:
* "outboundRules" array isn't returned for "Basic" SKU load balancer
* added example for external LB with outboundRules
* added missing read-only properties

* Replace "regionName" in examples with real location

* Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer

* chore: jsonfmt network (Azure#6592)

* Adding VpnSiteLink and VpnSiteLinkConnection properties. (Azure#6528)

* Added VpnSiteLink/VpnSiteLinkConnection operations.

* Sdk changes for vpn site link.

* Fixing error.

* Fixing more comments.

* Fixing json error.

* Fixing json files.

* Fixing comments.

* Fixing more issues.

* Fixing more errors.

* Fixing more error.

* Prettify JSON in VpnConnectionGet.json

* Resolving more comments.

* Fixing typo.

* Adding type in examples of put.

* Removing Child resource type.

* chore: jsonfmt network-may

* Fix incorrect examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

1 more reviewer

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EvgenyAgafonchikov @AutorestCI @azuresdkci @sergey-shandar