Skip to content

update CODEROWNERS#6443

Merged
mmyyrroonn merged 1 commit intomasterfrom
yungez-codeowner1
Jun 26, 2019
Merged

update CODEROWNERS#6443
mmyyrroonn merged 1 commit intomasterfrom
yungez-codeowner1

Conversation

@yungezz
Copy link
Copy Markdown
Member

@yungezz yungezz commented Jun 25, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jun 25, 2019

SDK Automation [Logs] (Generated from 3eec02c)

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 25, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 25, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 25, 2019

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 25, 2019

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@mmyyrroonn mmyyrroonn merged commit 1f2d3f5 into master Jun 26, 2019
@mmyyrroonn mmyyrroonn deleted the yungez-codeowner1 branch June 26, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants