Skip to content

Remove x-ms-azure-resource extension from ManagedResource#6436

Merged
kpajdzik merged 1 commit intoAzure:masterfrom
mahakjain314:update-spec
Jun 24, 2019
Merged

Remove x-ms-azure-resource extension from ManagedResource#6436
kpajdzik merged 1 commit intoAzure:masterfrom
mahakjain314:update-spec

Conversation

@mahakjain314
Copy link
Copy Markdown
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jun 24, 2019

SDK Automation [Logs] (Generated from ed1a7a8)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 24, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 24, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 24, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 24, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@mahakjain314
Copy link
Copy Markdown
Contributor Author

x-ms-azure-resource extension in ManagedResource definition was treating ManagedResource as azure resource and hence it was inheriting from IResource instead of Resource. This was causing issue while Autorest code generation for .NET SDK.

@kpajdzik kpajdzik merged commit a730739 into Azure:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants