Dev vmwarecloudsimple microsoft.v mware cloud simple 2019 04 01 by tenmozes · Pull Request #6427 · Azure/azure-rest-api-specs

tenmozes · 2019-06-24T11:11:39Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

- add dedicated prefix to placement group and availability zones - rename onboardingState

openapi-sdkautomation · 2019-06-24T11:11:41Z

SDK Automation [Logs] (Generated from d09eede)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

.NET: Azure/azure-sdk-for-net

Package generation pending.

AutorestCI · 2019-06-24T11:12:47Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d25554a0e35f79dbe78957e732f41d68a39b5f45
  stderr: 'fatal: reference is not a tree: d25554a0e35f79dbe78957e732f41d68a39b5f45'

AutorestCI · 2019-06-24T11:13:07Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d25554a0e35f79dbe78957e732f41d68a39b5f45
  stderr: 'fatal: reference is not a tree: d25554a0e35f79dbe78957e732f41d68a39b5f45'

AutorestCI · 2019-06-24T11:14:22Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d25554a0e35f79dbe78957e732f41d68a39b5f45
  stderr: 'fatal: reference is not a tree: d25554a0e35f79dbe78957e732f41d68a39b5f45'

AutorestCI · 2019-06-24T11:14:53Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout d25554a0e35f79dbe78957e732f41d68a39b5f45
  stderr: 'fatal: reference is not a tree: d25554a0e35f79dbe78957e732f41d68a39b5f45'

azuresdkci · 2019-06-24T12:01:37Z

Can one of the admins verify this patch?

ravbhatnagar · 2019-06-24T17:37:38Z

This PR has breaking changes. properties have been renamed in the same api-version. confirming with Service owner if this change is needed.

yungezz · 2019-06-25T06:44:14Z

...simple/resource-manager/Microsoft.VMwareCloudSimple/stable/2019-04-01/vmwarecloudsimple.json

          "readOnly": true
        },
+        "nodesCount": {
+          "description": "count of nodes to create",


count -> Count for consistence.

yungezz · 2019-06-25T06:47:02Z

@ravbhatnagar would you pls add "ArmChangesRequested" label?

tenmozes · 2019-06-25T08:51:54Z

fields will be renamed in next api version

tenmozes and others added 3 commits June 24, 2019 13:22

New Swagger Example Spec File

f1b3f8e

[VMwareCloudSimple] initial spec

2447c85

[vmwarecloudsimple] rename fields:

eba79ff

- add dedicated prefix to placement group and availability zones - rename onboardingState

azuresdkci assigned yungezz Jun 24, 2019

azuresdkci requested a review from yungezz June 24, 2019 11:12

tenmozes requested a review from ravbhatnagar June 24, 2019 11:12

AutorestCI mentioned this pull request Jun 24, 2019

[AutoPR vmwarecloudsimple/resource-manager] Dev vmwarecloudsimple microsoft.v mware cloud simple 2019 04 01 Azure/azure-sdk-for-python#6048

Closed

AutorestCI mentioned this pull request Jun 24, 2019

[AutoPR vmwarecloudsimple/resource-manager] Dev vmwarecloudsimple microsoft.v mware cloud simple 2019 04 01 Azure/azure-sdk-for-ruby#2669

Closed

AutorestCI mentioned this pull request Jun 24, 2019

[AutoPR vmwarecloudsimple/resource-manager] Dev vmwarecloudsimple microsoft.v mware cloud simple 2019 04 01 Azure/azure-sdk-for-go#5085

Closed

AutorestCI mentioned this pull request Jun 24, 2019

[AutoPR vmwarecloudsimple/resource-manager] Dev vmwarecloudsimple microsoft.v mware cloud simple 2019 04 01 Azure/azure-sdk-for-java#4064

Closed

[vmwarecloudsimple] update examples

d09eede

tenmozes added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 24, 2019

yungezz reviewed Jun 25, 2019

View reviewed changes

tenmozes closed this Jun 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev vmwarecloudsimple microsoft.v mware cloud simple 2019 04 01#6427

Dev vmwarecloudsimple microsoft.v mware cloud simple 2019 04 01#6427
tenmozes wants to merge 4 commits intoAzure:masterfrom
tenmozes:dev-vmwarecloudsimple-Microsoft.VMwareCloudSimple-2019-04-01

tenmozes commented Jun 24, 2019 •

edited

Loading

Uh oh!

openapi-sdkautomation bot commented Jun 24, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Jun 24, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Jun 24, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Jun 24, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Jun 24, 2019 •

edited

Loading

Uh oh!

azuresdkci commented Jun 24, 2019

Uh oh!

ravbhatnagar commented Jun 24, 2019

Uh oh!

yungezz Jun 25, 2019

Uh oh!

yungezz commented Jun 25, 2019

Uh oh!

tenmozes commented Jun 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

tenmozes commented Jun 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Jun 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from d09eede)

Uh oh!

AutorestCI commented Jun 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jun 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Jun 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Jun 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

azuresdkci commented Jun 24, 2019

Uh oh!

ravbhatnagar commented Jun 24, 2019

Uh oh!

yungezz Jun 25, 2019

Choose a reason for hiding this comment

Uh oh!

yungezz commented Jun 25, 2019

Uh oh!

tenmozes commented Jun 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

tenmozes commented Jun 24, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 24, 2019 •

edited

Loading

AutorestCI commented Jun 24, 2019 •

edited

Loading

AutorestCI commented Jun 24, 2019 •

edited

Loading

AutorestCI commented Jun 24, 2019 •

edited

Loading

AutorestCI commented Jun 24, 2019 •

edited

Loading