fix: adhybridhealthservice model validation issues#6414
Merged
yaohaizh merged 7 commits intoAzure:masterfrom Jul 22, 2019
Merged
fix: adhybridhealthservice model validation issues#6414yaohaizh merged 7 commits intoAzure:masterfrom
yaohaizh merged 7 commits intoAzure:masterfrom
Conversation
- service is an object not an array - casing on "notificationEmailEnabledForGlobalAdmins"
- setting is an object rather than an array
- tenant is an object rather than array
- alertFeedback is object instead of array - feeback -> feedback
- Missing required parameter "metricName" - flatten value in response
- additionalInformation is an array value
- additionalInformation is an array type
SDK Automation [Logs] (Generated from 0e75d48)
|
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-rubyUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-javaUnable to detect any generation context from this PR. |
nschonni
changed the title
Contributor
|
Can one of the admins verify this patch? |
Contributor
Author
|
@binilkk looks like you touched this last, so hope this makes sense |
yaohaizh
added
WaitForARMFeedback
Contributor
|
@binilkk Could you help review this PR? |
Contributor
Contributor
|
@binilkk Could you help review this? Thanks. |
1 similar comment
Contributor
|
@binilkk Could you help review this? Thanks. |
yaohaizh
approved these changes
Jul 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran through using oav to correct the examples that were flagged before