[Blueprints] Fix ModelValidation Errors#6394
Closed
filizt wants to merge 1 commit intoAzure:masterfrom
filizt:ModelValidationError
Closed
[Blueprints] Fix ModelValidation Errors#6394filizt wants to merge 1 commit intoAzure:masterfrom filizt:ModelValidationError
filizt wants to merge 1 commit intoAzure:masterfrom
filizt:ModelValidationError
Conversation
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-javaUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-rubyUnable to detect any generation context from this PR. |
Contributor
Author
|
@sergey-shandar this is the follow up PR to our discussion. |
Contributor
|
Can one of the admins verify this patch? |
5 tasks
Contributor
Author
|
Issue is being tracked here: Azure/oav#431 Closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a PR to follow up on model validation errors that started failing the checks in the last two PRs. One example can be found here: https://dev.azure.com/azure-sdk/public/_build/results?buildId=48989
There is currently no spec change committed in the PR, we'd like to discuss to find a good fix for the issue before we commit a spec change.
Issue summary:
These failures are specifically around the ParameterValueBase property and its polymorphic relation to ParameterValue. It seems like the model validation tool is not seeing this relationship and complaining that the "value" parameter in the request examples are not complaint.
We ideally want to find out the best way to model the following JSON:
The parameter value should either be have a reference or value property set, but (ideally) not both. One workaround I can think of is just to create a ParameterValue definition in the swagger with both value and reference properties as optional, but I'm hoping you can recommend some better solution.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.