Skip to content

Extend long-running ops fixes to new API version; Suppression #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergey-shandar merged 2 commits into from
Jun 17, 2019
Merged

Extend long-running ops fixes to new API version; Suppression #6336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0cf0ae
Update long-running for new API version
EvgenyAgafonchikov Jun 13, 2019
b05c44d
Add suppression for new API
EvgenyAgafonchikov Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...fication/network/resource-manager/Microsoft.Network/stable/2019-06-01/networkProfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,10 @@
"$ref": "./examples/NetworkProfileDelete.json"
}
},
"x-ms-long-running-operation": false
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
},
"get": {
"tags": [
Expand Down
2 changes: 2 additions & 0 deletions ...n/network/resource-manager/Microsoft.Network/stable/2019-06-01/virtualNetworkGateway.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,7 @@
"$ref": "./examples/VirtualNetworkGatewayGenerateVpnClientPackage.json"
}
},
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
Expand Down Expand Up @@ -546,6 +547,7 @@
"$ref": "./examples/VirtualNetworkGatewayGenerateVpnProfile.json"
}
},
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
Expand Down
3 changes: 3 additions & 0 deletions specification/network/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,9 @@ directive:
- suppress: RequiredPropertiesMissingInResourceModel
from: serviceCommunity.json
reason: name, id and type properties are inherited from the upper level
- suppress: AvoidNestedProperties
where: $.definitions.ServiceTagInformation.properties.properties
reason: No x-ms-client-flatten by design
- suppress: RequiredPropertiesMissingInResourceModel
from: usage.json
reason: name, id and type properties are inherited from the upper level
Expand Down