Skip to content

Remove unneeded values from Delete call for iot_dps_certificate #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbfrahry wants to merge 1 commit into from
Closed

Remove unneeded values from Delete call for iot_dps_certificate #6311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 0 additions & 67 deletions ...viceprovisioningservices/resource-manager/Microsoft.Devices/stable/2018-01-22/iotdps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,73 +268,6 @@
"type": "string",
"description": "This is a mandatory field, and is the logical name of the certificate that the provisioning service will access by."
},
Copy link
Contributor

@ravbhatnagar ravbhatnagar Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why were these query parameters added to delete? They are not present on the PUT. Were these somehow supported on the service side?

{
"name": "certificate.name",
"in": "query",
"required": false,
"type": "string",
"description": "This is optional, and it is the Common Name of the certificate."
},
{
"name": "certificate.rawBytes",
"in": "query",
"required": false,
"type": "string",
"format": "byte",
"description": "Raw data within the certificate."
},
{
"name": "certificate.isVerified",
"in": "query",
"required": false,
"type": "boolean",
"description": "Indicates if certificate has been verified by owner of the private key."
},
{
"name": "certificate.purpose",
"in": "query",
"required": false,
"type": "string",
"description": "A description that mentions the purpose of the certificate.",
"enum": [
"clientAuthentication",
"serverAuthentication"
],
"x-ms-enum": {
"name": "CertificatePurpose",
"modelAsString": true
}
},
{
"name": "certificate.created",
"in": "query",
"description": "Time the certificate is created.",
"required": false,
"type": "string",
"format": "date-time"
},
{
"name": "certificate.lastUpdated",
"in": "query",
"required": false,
"type": "string",
"description": "Time the certificate is last updated.",
"format": "date-time"
},
{
"name": "certificate.hasPrivateKey",
"in": "query",
"required": false,
"type": "boolean",
"description": "Indicates if the certificate contains a private key."
},
{
"name": "certificate.nonce",
"in": "query",
"required": false,
"type": "string",
"description": "Random number generated to indicate Proof of Possession."
},
{
"$ref": "#/parameters/api-version"
}
Expand Down