Skip to content

chore: jsonfmt storage#6261

Merged
jhendrixMSFT merged 3 commits intoAzure:masterfrom
nschonni:chore--jsonfmt-storage
Jun 26, 2019
Merged

chore: jsonfmt storage#6261
jhendrixMSFT merged 3 commits intoAzure:masterfrom
nschonni:chore--jsonfmt-storage

Conversation

@nschonni
Copy link
Copy Markdown
Contributor

@nschonni nschonni commented Jun 7, 2019

Ran jsonfmt -w "specification/storage/**/*.json"

@nschonni nschonni requested a review from stankovski as a code owner June 7, 2019 00:29
@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jun 7, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from cd15dc4)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@azuresdkci azuresdkci requested a review from tjprescott June 7, 2019 00:30
@AutorestCI AutorestCI mentioned this pull request Jun 7, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 7, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3561

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 7, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#3995

@AutorestCI AutorestCI mentioned this pull request Jun 7, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 7, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#6014

@AutorestCI AutorestCI mentioned this pull request Jun 7, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 7, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2664

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jun 7, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Jun 7, 2019

Can one of the admins verify this patch?

@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Jun 7, 2019

Fixed some model validation issues, but I can move those to a different PR if you want

tjprescott
tjprescott requested changes Jun 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is seemingly throwing away several description fields for different methods. That's not a purely formatting change.

Comment thread ...on/storage/resource-manager/Microsoft.Storage/stable/2017-06-01/examples/OperationsList.json Outdated
Copy link
Copy Markdown
Member

@tjprescott tjprescott Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How/why is this removing this metadata?

Copy link
Copy Markdown
Contributor Author

@nschonni nschonni Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix some model validation errors. I can remove the separate commit and submit it separately if preferred. There is a bug in VS Code with the schemas suggesting that authors add "descriptions" in example files, but the "description" isn't part of the Swagger properties

@tjprescott
Copy link
Copy Markdown
Member

tjprescott commented Jun 7, 2019

Can't merge due to failing checks.

@nschonni nschonni force-pushed the chore--jsonfmt-storage branch from a8dfebe to 23c9058 Compare June 18, 2019 21:40
@AutorestCI AutorestCI mentioned this pull request Jun 19, 2019
Closed
nschonni added 3 commits June 21, 2019 14:14
@nschonni
chore: jsonfmt storage
63d8e33 
Ran `jsonfmt -w "specification/storage/**/*.json"`
@nschonni
fix: Remove "description" for older API examples
2c8ce6d 
It is in the spec after the 2017 version
@nschonni
fix: camelCase example result properties
cd15dc4
@nschonni nschonni force-pushed the chore--jsonfmt-storage branch from 23c9058 to cd15dc4 Compare June 21, 2019 18:16
This was referenced Jun 21, 2019
Closed
Closed
@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Jun 26, 2019

@jhendrixMSFT can you help land this?

@jhendrixMSFT jhendrixMSFT merged commit 26df0a6 into Azure:master Jun 26, 2019
@nschonni nschonni deleted the chore--jsonfmt-storage branch June 26, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjprescott tjprescott tjprescott approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@stankovski stankovski Awaiting requested review from stankovski

Assignees

@tjprescott tjprescott

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nschonni @AutorestCI @azuresdkci @tjprescott @jhendrixMSFT