Skip to content

Comments

chore: jsonfmt mediaservices#6248

Merged
jhendrixMSFT merged 1 commit intoAzure:masterfrom
nschonni:chore--jsonfmt-mediaservices
Jun 28, 2019
Merged

chore: jsonfmt mediaservices#6248
jhendrixMSFT merged 1 commit intoAzure:masterfrom
nschonni:chore--jsonfmt-mediaservices

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Jun 6, 2019

Ran jsonfmt -w "specification/mediaservices/**/*.json"

@nschonni nschonni requested a review from BrianBlum as a code owner June 6, 2019 20:28
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 6, 2019

SDK Automation [Logs] (Generated from 5f2bf1d)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3172

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@nschonni
Copy link
Contributor Author

nschonni commented Jun 6, 2019

@BrianBlum I adjusted some camelCase in the examples in separate commits from the formatting. I can pull that stuff out if you prefer

@nschonni nschonni force-pushed the chore--jsonfmt-mediaservices branch from 000efe0 to ab9dfb4 Compare June 18, 2019 21:34
@nschonni
Copy link
Contributor Author

I've pulled out the example changes to keep it cleaner

@nschonni
Copy link
Contributor Author

@jhendrixMSFT any idea where to report the issue with the breaking change job? I looks like it's having trouble parsing an int64.Max value and reading it as larger than the value in the example (9223372036854776000 vs 9223372036854775807 actual)?

Unhandled Exception: Newtonsoft.Json.JsonReaderException: JSON integer 9223372036854776000 is too large or small for an Int64. Path 'paths['/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Media/mediaServices/{accountName}/accountFilters'].get.x-ms-examples['List all Account Filters'].responses.200.body.value[0].properties.presentationTimeRange.presentationWindowDuration', line 373, position 75.
   at Newtonsoft.Json.JsonTextReader.ParseNumber(ReadType readType)
   at Newtonsoft.Json.JsonTextReader.ParseValue()
   at Newtonsoft.Json.Linq.JContainer.ReadContentFrom(JsonReader r, JsonLoadSettings settings)
   at Newtonsoft.Json.Linq.JContainer.ReadTokenFrom(JsonReader reader, JsonLoadSettings options)
   at Newtonsoft.Json.Linq.JObject.Load(JsonReader reader, JsonLoadSettings settings)
   at Newtonsoft.Json.Linq.JToken.ReadFrom(JsonReader reader, JsonLoadSettings settings)
   at Newtonsoft.Json.Linq.JToken.Parse(String json, JsonLoadSettings settings)
   at AutoRest.Swagger.SwaggerParser.Parse(String swaggerDocument, String fileName) in D:\a\1\s\openapi-diff\src\modeler\AutoRest.Swagger\SwaggerParser.cs:line 16
   at AutoRest.Swagger.SwaggerModeler.Compare(String fileNameOld, String swaggerOld, String fileNameNew, String swaggerNew, Settings settings) in D:\a\1\s\openapi-diff\src\modeler\AutoRest.Swagger\SwaggerModeler.cs:line 29

@BrianBlum
Copy link

We hit that on another PR. The value is getting rounded up for some reason. I shrunk the value in the examples. FYI, I'm waiting for some issues in the java SDK autoPR to get resolved before I approve this PR.

@nschonni
Copy link
Contributor Author

@BrianBlum thanks, do you know if there is an issue or internal bug tracking the int64.max thing already?

@BrianBlum
Copy link

@nschonni I don't know if there's a bug tracking it.

@jhendrixMSFT
Copy link
Member

@sergey-shandar do you know about this failure in the breaking changes job?

Ran `jsonfmt -w "specification/mediaservices/**/*.json"`
@nschonni nschonni force-pushed the chore--jsonfmt-mediaservices branch from 96de30a to 5f2bf1d Compare June 27, 2019 07:28
@nschonni
Copy link
Contributor Author

@BrianBlum I rebased this after your last PR landed

Copy link

@BrianBlum BrianBlum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nschonni, Thanks

@jhendrixMSFT jhendrixMSFT merged commit 695cbc9 into Azure:master Jun 28, 2019
@nschonni nschonni deleted the chore--jsonfmt-mediaservices branch June 28, 2019 15:30
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
Ran `jsonfmt -w "specification/mediaservices/**/*.json"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants