Skip to content

chore: jsonfmt relay#6226

Merged
praries880 merged 2 commits intoAzure:masterfrom
nschonni:chore--jsonfmt-relay
Jun 10, 2019
Merged

chore: jsonfmt relay#6226
praries880 merged 2 commits intoAzure:masterfrom
nschonni:chore--jsonfmt-relay

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Jun 5, 2019

Ran jsonfmt -w "specification/relay/**/*.json"

@nschonni nschonni requested a review from v-Ajnava as a code owner June 5, 2019 05:34
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 5, 2019

SDK Automation [Logs] (Generated from aec3ef5)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpgfmigu84/rest/specification/relay/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp0ddw5ny9']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2019

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2571

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2019

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3628

nschonni added 2 commits June 6, 2019 19:04
Ran `jsonfmt -w "specification/relay/**/*.json"`
The property isn't in Operation/display
@nschonni nschonni force-pushed the chore--jsonfmt-relay branch from 9dcdfb6 to aec3ef5 Compare June 6, 2019 23:04
@nschonni
Copy link
Contributor Author

nschonni commented Jun 6, 2019

@v-Ajnava I fixed the model validation issue by removing the "description" from the example file. I can remove this if you prefer

Copy link

@praries880 praries880 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you kindly add the operation descriptions back?

"resource": "WcfRelay",
"operation": "Get WcfRelay",
"description": "Get list of WcfRelay Resource Descriptions"
"operation": "Get WcfRelay"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have the descriptions been pulled out here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description isn't part of the Swagger spec, and was likely added because of a VS Code JSON schema bug that suggest "description" be added to example files. Without this the model validation will fail (see first commit). I can submit it separately, but the build won't pass. Let me know how you want to handle it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praries880 I've opened an issue with some background over here #6277, since it has come up on a few PR 😄
I'm still good if you want it removed from this PR

"resource": "WcfRelay AuthorizationRules",
"operation": "Create or Update WcfRelay Authorization Rule",
"description": "Create WcfRelay Authorization Rules and Update its properties. The Authorization Rules Access Rights, the Primary and Secondary Keys can be updated."
"operation": "Create or Update WcfRelay Authorization Rule"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for all operaitons in this file?

"resource": "Namespace",
"operation": "Create Or Update Namespace ",
"description": "Create a Namespace Resource and Update its properties. Tags and status of the Namespace are the properties which can be updated."
"operation": "Create Or Update Namespace "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above here

@praries880 praries880 merged commit aa3f9e7 into Azure:master Jun 10, 2019
@nschonni nschonni deleted the chore--jsonfmt-relay branch June 10, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants