Skip to content

chore: jsonfmt recoveryservicessiterecovery#6224

Merged
jhendrixMSFT merged 4 commits intoAzure:masterfrom
nschonni:chore--jsonfmt-recoveryservicessiterecovery
Jun 12, 2019
Merged

chore: jsonfmt recoveryservicessiterecovery#6224
jhendrixMSFT merged 4 commits intoAzure:masterfrom
nschonni:chore--jsonfmt-recoveryservicessiterecovery

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Jun 5, 2019

Ran jsonfmt -w "specification/recoveryservicessiterecovery/**/*.json"

Ran `jsonfmt -w "specification/recoveryservicessiterecovery/**/*.json"`
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 5, 2019

SDK Automation [Logs] (Generated from d6ca064)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpx33chise/rest/specification/recoveryservicessiterecovery/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp_pjalm53']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2019

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2588

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

nschonni added 3 commits June 5, 2019 01:10
Was only miscased in 2016-08-10 API and corrected after
Earlier versions were array of string, and examples were probably copied
Earlier version had type array of string but change in later API
@nschonni
Copy link
Contributor Author

nschonni commented Jun 5, 2019

Fixed a few minor model validation issues that looked like they were from examples copied between version while the types changed

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2019

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3704

"jobQueryParameter": {
"startTime": "2017-04-27T14:26:51.9161395Z",
"endTime": "2017-05-04T14:26:51.9161395Z",
"affectedObjectTypes": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this has changed types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type changed from the initial version from array to string, so Model Validation was flagging it.
I can undo the non-formatting changes if you want though, since these fixes don't fully fix the model validation issues

@kpajdzik
Copy link
Contributor

@jhendrixMSFT, Could you help me merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants