Adding resource definition for IoTSecuritySolutionsAnalytics by hagba · Pull Request #6160 · Azure/azure-rest-api-specs

hagba · 2019-05-30T18:02:05Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-30T18:03:08Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-05-30T18:03:13Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5709

AutorestCI · 2019-05-30T18:03:40Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2019-05-30T18:03:40Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3607

azuresdkci · 2019-05-30T18:04:34Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-30T18:05:12Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5176

...urce-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutionAnalytics.json

…view/2017-08-01-preview/iotSecuritySolutionAnalytics.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

ravbhatnagar · 2019-06-25T17:14:04Z

Looks good. Signing off from ARM side.

jhendrixMSFT · 2019-06-26T17:22:10Z

@AutorestCI regenerate azure-sdk-for-go

AutorestCI · 2019-06-26T17:26:21Z

Encountered a Subprocess error

Command: ['/usr/local/bin/autorest', '/tmp/tmp0tztcfnn/rest/specification/security/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp0tztcfnn/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.133', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Including configuration file 'file:///tmp/tmp0tztcfnn/rest/specification/security/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.133->2.1.133)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-composite-v1"} .
   Including configuration file 'file:///tmp/tmp0tztcfnn/rest/specification/security/resource-manager/readme.go.md'
Processing batch task - {"tag":"package-composite-v2"} .
   Including configuration file 'file:///tmp/tmp0tztcfnn/rest/specification/security/resource-manager/readme.go.md'
Processing batch task - {"tag":"package-composite-v3"} .
   Including configuration file 'file:///tmp/tmp0tztcfnn/rest/specification/security/resource-manager/readme.go.md'
FATAL: System.InvalidOperationException: Values specified by 'enum' mismatch those specified by 'x-ms-enum' (name: 'RecommendationType'): 'OpenPortsOnDevice', 'PermissiveFirewallPolicy ', 'PermissiveFirewallRuleInput', 'PermissiveFirewallRuleOut', 'OperationSystemNotValid', 'UnutilizedMessagesFromAgent', 'SecurityTwinConfigurationNotOptimal', 'SecurityTwinConfigurationConflict', 'IdenticalAuthenticationCredentials', 'DenyDefaultIpPolicy', 'TooLargeIPRange', 'EnableDiagnosticsLog ' vs 'OpenPortsOnDevice', 'PermissiveFirewallPolicy', 'PermissiveFirewallRuleInput', 'PermissiveFirewallRuleOut', 'OperationSystemNotValid', 'UnutilizedMessagesFromAgent', 'SecurityTwinConfigurationNotOptimal', 'SecurityTwinConfigurationConflict', 'IdenticalAuthenticationCredentials', 'DenyDefaultIpPolicy', 'TooLargeIPRange', 'EnableDiagnosticsLog'
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 129
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 179
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 179
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 271
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
Failure during batch task - {"tag":"package-composite-v3"} -- Error: Plugin imodeler1 reported failure..
  Error: Plugin imodeler1 reported failure.

…ttps://github.com/hagba/azure-rest-api-specs into dev-security-Microsoft.Security-2017-08-01-preview

package.json

sergey-shandar · 2019-07-11T06:02:29Z

@majastrz please, review the PR.

majastrz

Approving since Gaurav already marked it as ARMSignedOff.

) * Adding resource definition for IoTSecuritySolutionsAnalytics * Fix reference error * Add reference to iotSecuritySolutionsAnalytics.json * Fix Autorest and swagger errors * Remove paging from short responses * Fix spelling * Fix wording of description * Fix paging error * refix paging * add Lists support * Fix example syntax * fix schema warnings * fix schema * fix schema * fix alert required properties error * add properties level for assitional properties * Fix additional proprties issues * fix additional properties issues * remove required tag * Fix according to ARM comments * fix errors * fix recommendation type example * fix dismiss example * required property cannot be readonly * remove tags from examples * fix lists errors * remove location property * Fixed securitySolution patch swagger * fix according to ARMs comment * fix unhealthyDeviceCount property name * Fix syntax error * Update specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutionAnalytics.json Co-Authored-By: Nick Schonning <nschonni@gmail.com> * Move remediation steps from alerts to recommendations * Move remediation steps from alerts to recommendations * rename mostPrevalentDevices to mostPrevalentDeviceAlerts * rename mostPrevalentDevices to mostPrevalentDeviceAlerts * fix example * fix dismiss * add severity to prevalent lists * fix syntax * fix errors * fix enum * remove dependency

Adding resource definition for IoTSecuritySolutionsAnalytics

b654b8d

hagba assigned sergey-shandar May 30, 2019

AutorestCI mentioned this pull request May 30, 2019

[AutoPR security/resource-manager] Adding resource definition for IoTSecuritySolutionsAnalytics Azure/azure-sdk-for-python#5552

Closed

AutorestCI mentioned this pull request May 30, 2019

[AutoPR security/resource-manager] Adding resource definition for IoTSecuritySolutionsAnalytics Azure/azure-sdk-for-js#3303

Closed

hagba requested a review from sergey-shandar May 30, 2019 18:04

AutorestCI mentioned this pull request May 30, 2019

[AutoPR security/resource-manager] Adding resource definition for IoTSecuritySolutionsAnalytics Azure/azure-sdk-for-go#4913

Closed

nschonni reviewed May 30, 2019

View reviewed changes

...urce-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutionAnalytics.json Outdated Show resolved Hide resolved

...urce-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutionAnalytics.json Outdated Show resolved Hide resolved

hagba changed the title ~~Adding resource definition for IoTSecuritySolutionsAnalytics~~ ** Dont merge yet WIP **** Adding resource definition for IoTSecuritySolutionsAnalytics May 30, 2019

Fix reference error

919e914

AutorestCI mentioned this pull request May 30, 2019

[AutoPR security/resource-manager] ** Dont merge yet WIP **** Adding resource definition for IoTSecuritySolutionsAnalytics Azure/azure-sdk-for-js#3314

Closed

hagba changed the title ** Dont merge yet WIP **** Adding resource definition for IoTSecuritySolutionsAnalytics Adding resource definition for IoTSecuritySolutionsAnalytics Jun 2, 2019

hagba changed the title ~~Adding resource definition for IoTSecuritySolutionsAnalytics~~ [Draft-Do-not-review] Adding resource definition for IoTSecuritySolutionsAnalytics Jun 2, 2019

hagba added 2 commits June 3, 2019 11:37

Add reference to iotSecuritySolutionsAnalytics.json

5465f41

Fix Autorest and swagger errors

3a82701

AutorestCI mentioned this pull request Jun 3, 2019

[AutoPR security/resource-manager] [Draft-Do-not-review] Adding resource definition for IoTSecuritySolutionsAnalytics Azure/azure-sdk-for-js#3394

Closed

nschonni reviewed Jun 3, 2019

View reviewed changes

...urce-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutionAnalytics.json Outdated Show resolved Hide resolved

hagba added 8 commits June 3, 2019 16:40

Remove paging from short responses

b5861c5

Fix spelling

fcef8ed

Fix wording of description

5946694

Fix paging error

98e881d

refix paging

e7901ca

add Lists support

3adf92a

Fix example syntax

1b4c667

fix schema warnings

9d22d12

nschonni reviewed Jun 25, 2019

View reviewed changes

...urce-manager/Microsoft.Security/preview/2017-08-01-preview/iotSecuritySolutionAnalytics.json Outdated Show resolved Hide resolved

Update specification/security/resource-manager/Microsoft.Security/pre…

e22f344

…view/2017-08-01-preview/iotSecuritySolutionAnalytics.json Co-Authored-By: Nick Schonning <nschonni@gmail.com>

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 25, 2019

hagba added 3 commits July 10, 2019 10:12

Move remediation steps from alerts to recommendations

36efcdf

Move remediation steps from alerts to recommendations

6cfe39a

Merge branch 'dev-security-Microsoft.Security-2017-08-01-preview' of h…

4debc1e

…ttps://github.com/hagba/azure-rest-api-specs into dev-security-Microsoft.Security-2017-08-01-preview

nschonni reviewed Jul 10, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

hagba added 5 commits July 10, 2019 11:51

rename mostPrevalentDevices to mostPrevalentDeviceAlerts

9e1389d

rename mostPrevalentDevices to mostPrevalentDeviceAlerts

bb462b6

add mostPrevalentDeviceRecommendations

b17efd7

fix example

9bf2206

fix dismiss

9988c68

hagba removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 10, 2019

hagba changed the title ~~[Don't merge] Adding resource definition for IoTSecuritySolutionsAnalytics~~ Adding resource definition for IoTSecuritySolutionsAnalytics Jul 10, 2019

hagba added 4 commits July 10, 2019 18:03

add severity to prevalent lists

d1a6204

fix syntax

a240dbd

fix errors

d5967c0

fix enum

cffdbb2

AutorestCI mentioned this pull request Jul 11, 2019

[AutoPR security/resource-manager] Adding resource definition for IoTSecuritySolutionsAnalytics Azure/azure-sdk-for-go#5225

Merged

sergey-shandar reviewed Jul 11, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

remove dependency

49d63b7

sergey-shandar approved these changes Jul 11, 2019

View reviewed changes

majastrz approved these changes Jul 11, 2019

View reviewed changes

sergey-shandar merged commit d7cf232 into Azure:master Jul 12, 2019

Comments

Conversation

hagba commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

azuresdkci commented May 30, 2019

Uh oh!

AutorestCI commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ravbhatnagar commented Jun 25, 2019

Uh oh!

jhendrixMSFT commented Jun 26, 2019

Uh oh!

AutorestCI commented Jun 26, 2019

Uh oh!

Uh oh!

Uh oh!

sergey-shandar commented Jul 11, 2019

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

hagba commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading