Skip to content

Fix long-running operations for VnetGw, NetworkProfile; Fix examples #6159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergey-shandar merged 7 commits into from
Jun 12, 2019
Merged

Fix long-running operations for VnetGw, NetworkProfile; Fix examples #6159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f0dc518
Added missing long-running values
EvgenyAgafonchikov May 28, 2019
90f5b09
Fix old examples
EvgenyAgafonchikov May 28, 2019
1b32237
Update more long-running for older
EvgenyAgafonchikov May 28, 2019
cf38a8a
Updated long-running for networkProfile
EvgenyAgafonchikov May 30, 2019
b092dfb
Fix more examples
EvgenyAgafonchikov May 30, 2019
8992c0e
Fixed LB examples
EvgenyAgafonchikov Jun 3, 2019
45c8bb7
Fix examples to pass updated oav validations
EvgenyAgafonchikov Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions ...n/network/resource-manager/Microsoft.Network/stable/2015-06-15/virtualNetworkGateway.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@
"description": "Delete successful."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways": {
Expand Down Expand Up @@ -253,7 +256,10 @@
}
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/generatevpnclientpackage": {
Expand Down Expand Up @@ -301,6 +307,10 @@
"type": "string"
}
}
},
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
Expand Down Expand Up @@ -434,7 +444,10 @@
"description": "Delete successful."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections": {
Expand Down Expand Up @@ -521,7 +534,10 @@
"description": ""
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{virtualNetworkGatewayConnectionName}/sharedkey": {
Expand Down Expand Up @@ -746,7 +762,10 @@
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/localNetworkGateways": {
Expand Down
44 changes: 36 additions & 8 deletions ...n/network/resource-manager/Microsoft.Network/stable/2016-09-01/virtualNetworkGateway.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@
"description": "Delete successful."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways": {
Expand Down Expand Up @@ -251,7 +254,10 @@
}
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/generatevpnclientpackage": {
Expand Down Expand Up @@ -299,6 +305,10 @@
"type": "string"
}
}
},
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
Expand Down Expand Up @@ -349,7 +359,10 @@
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getLearnedRoutes": {
Expand Down Expand Up @@ -392,7 +405,10 @@
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getAdvertisedRoutes": {
Expand Down Expand Up @@ -442,7 +458,10 @@
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{virtualNetworkGatewayConnectionName}": {
Expand Down Expand Up @@ -575,7 +594,10 @@
"description": "Delete successful."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{virtualNetworkGatewayConnectionName}/sharedkey": {
Expand Down Expand Up @@ -754,7 +776,10 @@
"description": ""
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/localNetworkGateways/{localNetworkGatewayName}": {
Expand Down Expand Up @@ -887,7 +912,10 @@
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/localNetworkGateways": {
Expand Down
4 changes: 1 addition & 3 deletions ...work/resource-manager/Microsoft.Network/stable/2016-12-01/examples/RouteFilterCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"properties": {
"rules": [
{
"name": "ruleName",
"properties": {
"access": "Allow",
"routeFilterRuleType": "Community",
Expand All @@ -22,8 +21,7 @@
]
}
}
],
"peerings": []
Copy link
Copy Markdown
Contributor

@sergey-shandar sergey-shandar Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential API breaking change.

]
}
}
},
Expand Down
1 change: 0 additions & 1 deletion ...work/resource-manager/Microsoft.Network/stable/2016-12-01/examples/RouteFilterUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"properties": {
"rules": [
{
"name": "ruleName",
"properties": {
"access": "Allow",
"routeFilterRuleType": "Community",
Expand Down
44 changes: 36 additions & 8 deletions ...n/network/resource-manager/Microsoft.Network/stable/2016-12-01/virtualNetworkGateway.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@
"description": "Delete successful."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways": {
Expand Down Expand Up @@ -251,7 +254,10 @@
}
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/generatevpnclientpackage": {
Expand Down Expand Up @@ -299,6 +305,10 @@
"type": "string"
}
}
},
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
Expand Down Expand Up @@ -349,7 +359,10 @@
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getLearnedRoutes": {
Expand Down Expand Up @@ -392,7 +405,10 @@
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/virtualNetworkGateways/{virtualNetworkGatewayName}/getAdvertisedRoutes": {
Expand Down Expand Up @@ -442,7 +458,10 @@
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{virtualNetworkGatewayConnectionName}": {
Expand Down Expand Up @@ -575,7 +594,10 @@
"description": "Delete successful."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/connections/{virtualNetworkGatewayConnectionName}/sharedkey": {
Expand Down Expand Up @@ -754,7 +776,10 @@
"description": ""
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/localNetworkGateways/{localNetworkGatewayName}": {
Expand Down Expand Up @@ -887,7 +912,10 @@
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-long-running-operation": true
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/localNetworkGateways": {
Expand Down
4 changes: 1 addition & 3 deletions ...work/resource-manager/Microsoft.Network/stable/2017-03-01/examples/RouteFilterCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"properties": {
"rules": [
{
"name": "ruleName",
"properties": {
"access": "Allow",
"routeFilterRuleType": "Community",
Expand All @@ -22,8 +21,7 @@
]
}
}
],
"peerings": []
]
}
}
},
Expand Down
1 change: 0 additions & 1 deletion ...work/resource-manager/Microsoft.Network/stable/2017-03-01/examples/RouteFilterUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"properties": {
"rules": [
{
"name": "ruleName",
"properties": {
"access": "Allow",
"routeFilterRuleType": "Community",
Expand Down
Loading