HDI add autoscale feature support by gaoxiaoninghit · Pull Request #6158 · Azure/azure-rest-api-specs

gaoxiaoninghit · 2019-05-30T06:32:20Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-30T06:33:13Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-05-30T06:33:25Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6082

AutorestCI · 2019-05-30T06:33:43Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3696

AutorestCI · 2019-05-30T06:33:45Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3285

AutorestCI · 2019-05-30T06:35:07Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5106

azuresdkci · 2019-05-30T07:03:00Z

Can one of the admins verify this patch?

idear1203

LGTM.

NelsonDaniel

I left some review comments. Also, solve merge conflicts

...ation/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/cluster.json

...cation/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json

...ation/hdinsight/resource-manager/Microsoft.HDInsight/preview/2015-03-01-preview/cluster.json

...cation/hdinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/cluster.json

NelsonDaniel · 2019-06-11T00:54:09Z

Merge conflicts need to be resolved.

openapi-sdkautomation · 2019-06-12T05:51:36Z

SDK Automation [Logs] (Generated from edd2f70)

Go: Azure/azure-sdk-for-go [Logs] [Diff]

preview/hdinsight/mgmt/2015-03-01-preview [Logs] [Instructions]
- preview.hdinsight.mgmt.2015-03-01-preview.zip
preview/hdinsight/mgmt/2018-06-01-preview [Logs] [Instructions]
- preview.hdinsight.mgmt.2018-06-01-preview.zip

Java: Azure/azure-sdk-for-java [Logs] [Diff]

hdinsight/resource-manager/v2015_03_01_preview [Logs] [Instructions]
hdinsight/resource-manager/v2018_06_01_preview [Logs]

Python: Azure/azure-sdk-for-python [Logs] [Diff]

sdk/hdinsight/azure-mgmt-hdinsight [Logs] [Instructions]
- azure-mgmt-hdinsight-1.1.0.zip
- azure_mgmt_hdinsight-1.1.0-py2.py3-none-any.whl

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@azure/arm-hdinsight [Logs] [Instructions]
- azure-arm-hdinsight-0.14.0.tgz

NelsonDaniel · 2019-06-12T21:03:44Z

Looks good to me. Just waiting for ARM feedback. Need to reassign this PR since I will be OOF, and this needs to be merged before I come back

amarzavery · 2019-06-17T15:40:14Z

@gaoxiaoning - New model types have been added to the swagger specification. I don't see any updates to the corresponding x-ms-examples in the operation where these types are being used. Please update the existing examples or add new examples that show the usage of newly added model types.

majastrz

Looks good to me.

idear1203 · 2019-06-24T17:14:10Z

@amarzavery , could you please help merge the PR or let us know if you have other concerns:)

* removed unused properties and renamed example folder * removed provider version property * undone readme changes

AutorestCI mentioned this pull request May 30, 2019

[AutoPR hdinsight/resource-manager] Hdi add autoscale support autorest Azure/azure-sdk-for-python#5546

Closed

AutorestCI mentioned this pull request May 30, 2019

[AutoPR hdinsight/resource-manager] Hdi add autoscale support autorest Azure/azure-sdk-for-js#3298

Closed

AutorestCI mentioned this pull request May 30, 2019

[AutoPR hdinsight/resource-manager] Hdi add autoscale support autorest Azure/azure-sdk-for-go#4910

Closed

gaoxiaoninghit changed the title ~~Hdi add autoscale support autorest~~ HDI add autoscale feature support May 30, 2019

azuresdkci assigned NelsonDaniel May 30, 2019

azuresdkci requested a review from NelsonDaniel May 30, 2019 06:55

gaoxiaoninghit force-pushed the hdi_add_autoscale_support_autorest branch from e35e81d to 5692d42 Compare May 30, 2019 07:33

idear1203 self-requested a review May 31, 2019 04:57

idear1203 approved these changes May 31, 2019

View reviewed changes

NelsonDaniel suggested changes Jun 3, 2019

View reviewed changes

NelsonDaniel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 11, 2019

gaoxiaoninghit force-pushed the hdi_add_autoscale_support_autorest branch from cc046e5 to 64381fd Compare June 12, 2019 05:51

AutorestCI mentioned this pull request Jun 12, 2019

[AutoPR hdinsight/resource-manager] HDI add autoscale feature support Azure/azure-sdk-for-js#3696

Closed

change cluster json file to support the autoscale feature

a1be505

gaoxiaoninghit force-pushed the hdi_add_autoscale_support_autorest branch from 64381fd to a1be505 Compare June 12, 2019 05:55

NelsonDaniel approved these changes Jun 12, 2019

View reviewed changes

NelsonDaniel added the Reassign label Jun 12, 2019

azuresdkci removed the Reassign label Jun 12, 2019

azuresdkci assigned amarzavery and unassigned NelsonDaniel Jun 12, 2019

azuresdkci requested a review from amarzavery June 12, 2019 21:08

majastrz approved these changes Jun 17, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 17, 2019

Xiaoning Gao added 2 commits June 18, 2019 19:30

add x-ms-examples for Autoscale

01e6826

add x-ms-examples for Autoscale

3b14442

Xiaoning Gao added 3 commits June 19, 2019 16:44

fix valid error

991b04c

fix valid error

dd08127

Trigger notification

edd2f70

idear1203 added the HDInsight label Jun 21, 2019

amarzavery approved these changes Jun 25, 2019

View reviewed changes

amarzavery merged commit 047450d into Azure:master Jun 25, 2019

aim-for-better mentioned this pull request Aug 13, 2019

[HDInsight] Add three new features GetCapabilites, AutoScale, GetBillingSpec Azure/azure-sdk-for-net#7254

Merged

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Removed unused properties and renamed example folder (#6158)

fbec1fb

* removed unused properties and renamed example folder * removed provider version property * undone readme changes

Conversation

gaoxiaoninghit commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented May 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented May 30, 2019

Uh oh!

idear1203 left a comment

Choose a reason for hiding this comment

Uh oh!

NelsonDaniel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NelsonDaniel commented Jun 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-sdkautomation bot commented Jun 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from edd2f70)

Uh oh!

NelsonDaniel commented Jun 12, 2019

Uh oh!

amarzavery commented Jun 17, 2019

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

idear1203 commented Jun 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

gaoxiaoninghit commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

AutorestCI commented May 30, 2019 •

edited

Loading

NelsonDaniel commented Jun 11, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 12, 2019 •

edited

Loading