Skip to content

[HDInsight] Fix specs not support subdomainsuffix parameter #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpajdzik merged 1 commit into from
May 31, 2019
Merged

[HDInsight] Fix specs not support subdomainsuffix parameter #6150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...dinsight/resource-manager/Microsoft.HDInsight/stable/2018-06-01-preview/applications.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,14 @@
"type": "integer",
"format": "int32",
"description": "The public port to connect to."
},
"subDomainSuffix":{
"type": "string",
"description": "The subDomainSuffix of the application and can not greater than 3 characters."
Copy link
Copy Markdown

@tylerfox tylerfox Jun 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, the description should say "The subDomainSuffix of the application. It cannot be greater than 3 characters."

},
"disableGatewayAuth":{
"type": "boolean",
Copy link
Copy Markdown
Contributor

@kpajdzik kpajdzik May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI ARM team advises against boolean properties in specs, it will be a breaking change if you ever decide to add a third value and make it a string.

Copy link
Copy Markdown
Member Author

@aim-for-better aim-for-better May 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI ARM team advises against boolean properties in specs, it will be a breaking change if you ever decide to add a third value and make it a string.

Thanks for your reminder. It makes sense to me. We think it should be boolean.

"description": "The value indicates whether to disable GatewayAuth."
}
}
},
Expand Down
1 change: 0 additions & 1 deletion ...rce-manager/Microsoft.HDInsight/stable/2018-06-01-preview/examples/CreateApplication.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"WebPage"
]
}],
"provisioningState": "",
"applicationType": "CustomApplication",
"errors": []
}
Expand Down