Skip to content

Comments

chore: jsonfmt keyvault#6126

Merged
sergey-shandar merged 3 commits intoAzure:masterfrom
nschonni:chore--jsonfmt-keyvault
May 29, 2019
Merged

chore: jsonfmt keyvault#6126
sergey-shandar merged 3 commits intoAzure:masterfrom
nschonni:chore--jsonfmt-keyvault

Conversation

@nschonni
Copy link
Contributor

Ran jsonfmt -w "specification/keyvault/**/*.json"

Ran `jsonfmt -w "specification/keyvault/**/*.json"`
@nschonni nschonni requested a review from schaabs as a code owner May 28, 2019 04:12
@AutorestCI
Copy link

AutorestCI commented May 28, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp3jd8twc8/rest/specification/keyvault/data-plane/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp1l14xyd8']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@AutorestCI
Copy link

AutorestCI commented May 28, 2019

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented May 28, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#5484

@AutorestCI
Copy link

AutorestCI commented May 28, 2019

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2495

@AutorestCI
Copy link

AutorestCI commented May 28, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@nschonni
Copy link
Contributor Author

Fixed a minor model validation issues with the case of "recoveryLevel", but there are still a few missing parameters I don't think i'm qualified to fix:

  • parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values in spec
  • parameter parameter is required in the swagger spec but is not present in the provided example parameter values not sure
  • Additional properties not allowed: zip not in spec
  • Additional properties not allowed: basic_constraints not in spec
  • Additional properties not allowed: issuer in some specs
  • Additional properties not allowed: csr in stable spec, but used in preview
  • Additional properties not allowed: status in some specs
  • Additional properties not allowed: target in some specs
    ...

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sergey-shandar sergey-shandar merged commit c87d2b0 into Azure:master May 29, 2019
@nschonni nschonni deleted the chore--jsonfmt-keyvault branch May 29, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants