Improve descriptions in Network's specs by anton-evseev · Pull Request #6123 · Azure/azure-rest-api-specs

anton-evseev · 2019-05-27T10:46:58Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-27T10:47:53Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmplcaelopd/rest/specification/network/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp_97z6cwi']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-05-27T10:48:42Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpy932kn4z/rest/specification/network/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpy932kn4z/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4374/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4374)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[2150:0x432ec10]    63141 ms: Mark-sweep 1374.5 (1424.5) -> 1374.1 (1424.5) MB, 1226.7 / 0.0 ms  (average mu = 0.105, current mu = 0.025) allocation failure scavenge might not succeed
[2150:0x432ec10]    65118 ms: Mark-sweep 1375.0 (1424.5) -> 1374.6 (1425.0) MB, 1973.9 / 0.0 ms  (average mu = 0.043, current mu = 0.002) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x27323731e6e9 <JSObject>
    0: builtin exit frame: stringify(this=0x273237311a21 <Object map = 0xdc85f5042a9>,0x014b614026f1 <undefined>,0x014b614026f1 <undefined>,0x1f80dafc9451 <JSArray[6]>,0x273237311a21 <Object map = 0xdc85f5042a9>)

    1: arguments adaptor frame: 1->3
    2: IdentitySourceMapping [0x186af0435a61] [/root/.autorest/@microsoft.azure_autorest-core@2.0.4374/node_modules/@microsoft.azure/autorest-core/...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xe9f655  [node]
11: 0xea6eca v8::internal::Factory::NewRawOneByteString(int, v8::internal::PretenureFlag) [node]
12: 0x11d6b25 v8::internal::IncrementalStringBuilder::Extend() [node]
13: 0xf9f77d v8::internal::JsonStringifier::Result v8::internal::JsonStringifier::Serialize_<false>(v8::internal::Handle<v8::internal::Object>, bool, v8::internal::Handle<v8::internal::Object>) [node]
14: 0xfa0626 v8::internal::JsonStringifier::Result v8::internal::JsonStringifier::Serialize_<false>(v8::internal::Handle<v8::internal::Object>, bool, v8::internal::Handle<v8::internal::Object>) [node]
15: 0xfa1719 v8::internal::JsonStringifier::Stringify(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>) [node]
16: 0xba9121 v8::internal::Builtin_JsonStringify(int, v8::internal::Object**, v8::internal::Isolate*) [node]
17: 0xd767dddbf7d

AutorestCI · 2019-05-27T10:49:13Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp56m7gjp1/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp56m7gjp1/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.133', '--use-onever', '--verbose']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Including configuration file 'file:///tmp/tmp56m7gjp1/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.133->2.1.133)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-02"} .
   Including configuration file 'file:///tmp/tmp56m7gjp1/rest/specification/network/resource-manager/readme.go.md'

<--- Last few GCs --->

[26641:0x2ac88c0]    99357 ms: Mark-sweep 1387.0 (1472.4) -> 1387.0 (1474.4) MB, 1620.2 / 0.0 ms  allocation failure GC in old space requested
[26641:0x2ac88c0]   101099 ms: Mark-sweep 1387.0 (1474.4) -> 1386.8 (1435.9) MB, 1741.4 / 0.0 ms  last resort GC in old space requested
[26641:0x2ac88c0]   102793 ms: Mark-sweep 1386.8 (1435.9) -> 1386.8 (1435.4) MB, 1694.1 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x3c8c779a5879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x156de2494329](this=0x280eba9c43a9 <JSWeakMap>,key=0x420213da449 <Object map = 0x8b94f26f5f9>,value=0x8ae3888d169 <String[6]: String>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0x156de21d4cb9](this=0x4de600022d1 <und...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x156de20842fd

AutorestCI · 2019-05-27T10:50:33Z

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmpa86kaarv/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmpa86kaarv/azure-sdk-for-js', '--use=@microsoft.azure/autorest.typescript@4.0.0']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4299/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4299)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (4.0.0->4.0.0)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

<--- Last few GCs --->

[9642:0x3612860]   172165 ms: Mark-sweep 1396.9 (1484.1) -> 1396.9 (1484.6) MB, 1833.4 / 0.0 ms  allocation failure GC in old space requested
[9642:0x3612860]   173807 ms: Mark-sweep 1396.9 (1484.6) -> 1396.9 (1445.6) MB, 1641.9 / 0.0 ms  last resort GC in old space requested
[9642:0x3612860]   175399 ms: Mark-sweep 1396.9 (1445.6) -> 1396.9 (1443.1) MB, 1591.6 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x1721e9ca5879 <JSObject>
    1: readLineBreak(aka readLineBreak) [/node_modules/yaml-ast-parser/dist/src/loader.js:~300] [pc=0x1a36bf019c62](this=0x3ea9fb0022d1 <undefined>,state=0x16d4a1079c89 <State map = 0x384c71d35b59>)
    2: readFlowCollection(aka readFlowCollection) [/node_modules/yaml-ast-parser/dist/src/loader.js:~596] [pc=0x1a36bf022920](this=0x3ea9fb0022d1 <undefined>,state=0x16d4a1079c89 <State map = 0x384c7...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewUninitializedFixedArray(int) [node]
 6: 0xd7fc13 [node]
 7: v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [node]
 8: 0x1a36bec042fd

AutorestCI · 2019-05-27T10:54:32Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2019-05-27T11:34:08Z

Can one of the admins verify this patch?

* [AutoSync] c5c7e0e restore common types * [AutoSync] 47e5fdd add keyvault reference in sample

Improve Network's descriptions

7a96608

anton-evseev requested a review from MikhailTryakhov as a code owner May 27, 2019 10:46

azuresdkci assigned sergey-shandar May 27, 2019

azuresdkci requested a review from sergey-shandar May 27, 2019 11:09

sergey-shandar approved these changes May 28, 2019

View reviewed changes

sergey-shandar merged commit 033a60c into Azure:master May 28, 2019

anton-evseev deleted the nrp-descriptions branch July 26, 2019 08:24

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

[AutoSync] Swagger updates for servicelinker/swagger (#6123)

e3824b8

* [AutoSync] c5c7e0e restore common types * [AutoSync] 47e5fdd add keyvault reference in sample

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve descriptions in Network's specs#6123

Improve descriptions in Network's specs#6123
sergey-shandar merged 1 commit intoAzure:masterfrom
anton-evseev:nrp-descriptions

anton-evseev commented May 27, 2019

Uh oh!

AutorestCI commented May 27, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 27, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 27, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 27, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 27, 2019 •

edited

Loading

Uh oh!

azuresdkci commented May 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

anton-evseev commented May 27, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented May 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented May 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented May 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

azuresdkci commented May 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

AutorestCI commented May 27, 2019 •

edited

Loading

AutorestCI commented May 27, 2019 •

edited

Loading

AutorestCI commented May 27, 2019 •

edited

Loading

AutorestCI commented May 27, 2019 •

edited

Loading

AutorestCI commented May 27, 2019 •

edited

Loading