[Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview #6090

sarang-amondikar · 2019-05-23T17:24:07Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2019-05-23T17:25:10Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5564

AutorestCI · 2019-05-23T17:25:25Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3349

AutorestCI · 2019-05-23T17:25:38Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2474

azuresdkci · 2019-05-23T17:25:40Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-23T17:26:41Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4926

REST Spec PR 'Azure/azure-rest-api-specs#6090' REST Spec PR Author 'sarang-amondikar' REST Spec PR Last commit

adxsdknet · 2019-05-23T17:31:38Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6403
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@f9cbc29
adxsdknet/azure-sdk-for-net@7085e5e
adxsdknet/azure-sdk-for-net@37d8471

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

REST Spec PR 'Azure/azure-rest-api-specs#6090' REST Spec PR Author 'sarang-amondikar' REST Spec PR Last commit

AutorestCI · 2019-05-23T22:06:20Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpy23e04jq/rest/specification/billing/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpfqhk6xeq']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

REST Spec PR 'Azure/azure-rest-api-specs#6090' REST Spec PR Author 'sarang-amondikar' REST Spec PR Last commit

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

ryansbenson

Approved from ARMs side

jhendrixMSFT · 2019-05-24T16:06:36Z

@sarang-amondikar has this API been deployed?

sarang-amondikar · 2019-05-24T20:08:26Z

@jhendrixMSFT the api is not yet deployed, we want to test it in ppe first

jhendrixMSFT · 2019-05-24T20:11:39Z

Sounds good, please update when the API is live so we can merge.

jhendrixMSFT · 2019-05-31T16:22:00Z

@AutorestCI regenerate azure-sdk-for-go

sarang-amondikar · 2019-05-31T18:42:17Z

the api is now deployed to prod, could you please approve this PR?

* add vlanid and ip fwd * add type to vlanid * fix prettycheck

sarang-amondikar requested a review from wilcobmsft as a code owner May 23, 2019 17:24

azuresdkci assigned jhendrixMSFT May 23, 2019

azuresdkci requested a review from jhendrixMSFT May 23, 2019 17:24

AutorestCI mentioned this pull request May 23, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-python#5450

Closed

AutorestCI mentioned this pull request May 23, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-js#3155

Closed

AutorestCI mentioned this pull request May 23, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-ruby#2479

Merged

AutorestCI mentioned this pull request May 23, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-go#4863

Closed

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 23, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 23, 2019

.NET SDK Resource Provider:'Billing'

f9cbc29

REST Spec PR 'Azure/azure-rest-api-specs#6090' REST Spec PR Author 'sarang-amondikar' REST Spec PR Last commit

jhendrixMSFT reviewed May 23, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json Outdated Show resolved Hide resolved

sarang-amondikar added 2 commits May 23, 2019 10:59

make validateAddress top level api

dc03212

review comments

6f923f7

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 23, 2019

.NET SDK Resource Provider:'Billing'

7085e5e

REST Spec PR 'Azure/azure-rest-api-specs#6090' REST Spec PR Author 'sarang-amondikar' REST Spec PR Last commit

update class

3da72c1

wilcobmsft approved these changes May 23, 2019

View reviewed changes

AutorestCI mentioned this pull request May 23, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-js#3169

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 23, 2019

.NET SDK Resource Provider:'Billing'

37d8471

REST Spec PR 'Azure/azure-rest-api-specs#6090' REST Spec PR Author 'sarang-amondikar' REST Spec PR Last commit

ryansbenson added the ARMReviewInProgress label May 24, 2019

ryansbenson reviewed May 24, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json Show resolved Hide resolved

ryansbenson reviewed May 24, 2019

View reviewed changes

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 24, 2019

jhendrixMSFT approved these changes May 24, 2019

View reviewed changes

jhendrixMSFT added the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 24, 2019

AutorestCI mentioned this pull request May 31, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-go#4917

Closed

jhendrixMSFT removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 31, 2019

jhendrixMSFT merged commit 17856d4 into Azure:master May 31, 2019

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

add vlanid and ip fwd (#6090)

10c9636

* add vlanid and ip fwd * add type to vlanid * fix prettycheck

[Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview #6090

[Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview #6090

Uh oh!

Conversation

sarang-amondikar commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

AutorestCI commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

azuresdkci commented May 23, 2019

Uh oh!

AutorestCI commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

adxsdknet commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

Uh oh!

AutorestCI commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

Uh oh!

ryansbenson left a comment

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT commented May 24, 2019

Uh oh!

sarang-amondikar commented May 24, 2019

Uh oh!

jhendrixMSFT commented May 24, 2019

Uh oh!

jhendrixMSFT commented May 31, 2019

Uh oh!

sarang-amondikar commented May 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sarang-amondikar commented May 23, 2019 •

edited

Loading

AutorestCI commented May 23, 2019 •

edited

Loading

AutorestCI commented May 23, 2019 •

edited

Loading

AutorestCI commented May 23, 2019 •

edited

Loading

AutorestCI commented May 23, 2019 •

edited

Loading

adxsdknet commented May 23, 2019 •

edited

Loading

AutorestCI commented May 23, 2019 •

edited

Loading