[Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview by msft-adrianma · Pull Request #6041 · Azure/azure-rest-api-specs

msft-adrianma · 2019-05-21T04:39:12Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2019-05-21T04:39:44Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2474

AutorestCI · 2019-05-21T04:40:03Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3349

AutorestCI · 2019-05-21T04:40:18Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5564

AutorestCI · 2019-05-21T04:41:53Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4924

azuresdkci · 2019-05-21T05:17:19Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-21T06:39:33Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpj891cdj6/rest/specification/billing/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpo565k5q6']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

REST Spec PR 'Azure/azure-rest-api-specs#6041' REST Spec PR Author 'msft-adrianma' REST Spec PR Last commit

adxsdknet · 2019-05-23T06:30:10Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6398
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@d3a58be
adxsdknet/azure-sdk-for-net@1aa42bb
adxsdknet/azure-sdk-for-net@b09ab98

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/UpdateBillingAccount.json

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/UpdateBillingAccount.json

REST Spec PR 'Azure/azure-rest-api-specs#6041' REST Spec PR Author 'msft-adrianma' REST Spec PR Last commit

ryansbenson · 2019-05-24T19:21:58Z

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

+    "BillingAccountUpdateProperties": {
+      "description": "The properties of the billing account that can be updated.",
+      "properties": {
+        "address": {


One final thing:
The body of patch should replicate the resource but only include the fields being patched. In this case you have:
{
'address':...
}
but it should be:
{
'properties':{
'address': ...
}
}

REST Spec PR 'Azure/azure-rest-api-specs#6041' REST Spec PR Author 'msft-adrianma' REST Spec PR Last commit

shahabhijeet · 2019-05-28T21:15:38Z

This is good to be merged as soon as CI is green

jhendrixMSFT · 2019-05-31T16:22:47Z

@AutorestCI regenerate azure-sdk-for-go

swagger for patching billing account.

a449760

msft-adrianma requested a review from wilcobmsft as a code owner May 21, 2019 04:39

AutorestCI mentioned this pull request May 21, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-js#3061

Closed

AutorestCI mentioned this pull request May 21, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-python#5368

Closed

msft-adrianma added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 21, 2019

azuresdkci assigned shahabhijeet May 21, 2019

azuresdkci requested a review from shahabhijeet May 21, 2019 04:40

AutorestCI mentioned this pull request May 21, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-go#4841

Closed

wilcobmsft approved these changes May 21, 2019

View reviewed changes

AutorestCI mentioned this pull request May 21, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-java#3720

Closed

ryansbenson reviewed May 22, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json Outdated Show resolved Hide resolved

updated based on feedback.

c78bd89

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 23, 2019

.NET SDK Resource Provider:'Billing'

d3a58be

REST Spec PR 'Azure/azure-rest-api-specs#6041' REST Spec PR Author 'msft-adrianma' REST Spec PR Last commit

ryansbenson reviewed May 23, 2019

View reviewed changes

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/UpdateBillingAccount.json Outdated Show resolved Hide resolved

ryansbenson added the ARMChangesRequested label May 24, 2019

update example based on feedback.

c00f5ad

AutorestCI mentioned this pull request May 24, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-js#3185

Closed

ryansbenson reviewed May 24, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json Outdated Show resolved Hide resolved

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/UpdateBillingAccount.json Outdated Show resolved Hide resolved

updated azure-async operation based on feedback.

996c006

AutorestCI mentioned this pull request May 24, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-js#3190

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 24, 2019

.NET SDK Resource Provider:'Billing'

1aa42bb

REST Spec PR 'Azure/azure-rest-api-specs#6041' REST Spec PR Author 'msft-adrianma' REST Spec PR Last commit

ryansbenson reviewed May 24, 2019

View reviewed changes

update based on feedback.

f7b6da7

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 25, 2019

.NET SDK Resource Provider:'Billing'

b09ab98

REST Spec PR 'Azure/azure-rest-api-specs#6041' REST Spec PR Author 'msft-adrianma' REST Spec PR Last commit

ryansbenson mentioned this pull request May 28, 2019

Spec for LineOfCredit API and other corrections #6054

Merged

5 tasks

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 28, 2019

AutorestCI mentioned this pull request May 31, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-go#4918

Merged

shahabhijeet merged commit d057548 into Azure:master May 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview#6041

[Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview#6041
shahabhijeet merged 5 commits intoAzure:masterfrom
msft-adrianma:patchBillingAccount-billing-Microsoft.Billing-2018-11-01-preview

msft-adrianma commented May 21, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 21, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 21, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 21, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 21, 2019 •

edited

Loading

Uh oh!

azuresdkci commented May 21, 2019

Uh oh!

AutorestCI commented May 21, 2019 •

edited

Loading

Uh oh!

Uh oh!

adxsdknet commented May 23, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryansbenson May 24, 2019

Uh oh!

shahabhijeet commented May 28, 2019

Uh oh!

jhendrixMSFT commented May 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

msft-adrianma commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

AutorestCI commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented May 21, 2019

Uh oh!

AutorestCI commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

Uh oh!

adxsdknet commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryansbenson May 24, 2019

Choose a reason for hiding this comment

Uh oh!

shahabhijeet commented May 28, 2019

Uh oh!

jhendrixMSFT commented May 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

msft-adrianma commented May 21, 2019 •

edited

Loading

AutorestCI commented May 21, 2019 •

edited

Loading

AutorestCI commented May 21, 2019 •

edited

Loading

AutorestCI commented May 21, 2019 •

edited

Loading

AutorestCI commented May 21, 2019 •

edited

Loading

AutorestCI commented May 21, 2019 •

edited

Loading

adxsdknet commented May 23, 2019 •

edited

Loading