-
Notifications
You must be signed in to change notification settings - Fork 5.6k
ARM spec review for validateAddress for BillingRP #6010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kpajdzik
merged 3 commits into
Azure:master
from
sarang-amondikar:dev-billing-Microsoft.Billing-2018-11-01-preview
May 21, 2019
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
.../Microsoft.Billing/preview/2018-11-01-preview/examples/BillingAccountValidateAddress.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2018-11-01-preview", | ||
| "billingAccountName": "00000000-0000-0000-0000-000000000000", | ||
| "address": { | ||
| "addressLine1": "555 110th Ave NE", | ||
| "city": "bellevue", | ||
| "region": "wa", | ||
| "postalCode": "98004", | ||
| "country": "us" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "status": "Valid", | ||
| "suggestedAddresses": [ | ||
| { | ||
| "country": "US", | ||
| "region": "WA", | ||
| "city": "Bellevue", | ||
| "addressLine1": "555 110th Ave NE", | ||
| "postalCode": "98004-5124" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
44 changes: 44 additions & 0 deletions
44
...oft.Billing/preview/2018-11-01-preview/examples/BillingAccountValidateAddressInvalid.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2018-11-01-preview", | ||
| "billingAccountName": "00000000-0000-0000-0000-000000000000", | ||
| "address": { | ||
| "addressLine1": "55 110th Ave NE", | ||
| "city": "bellevue", | ||
| "region": "wa", | ||
| "postalCode": "98004", | ||
| "country": "us" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "status": "Invalid", | ||
| "suggestedAddresses": [ | ||
| { | ||
| "country": "US", | ||
| "region": "WA", | ||
| "city": "Bellevue", | ||
| "addressLine1": "100 110th Ave NE", | ||
| "postalCode": "98004" | ||
| }, | ||
| { | ||
| "country": "US", | ||
| "region": "WA", | ||
| "city": "Bellevue", | ||
| "addressLine1": "102 110th Ave NE", | ||
| "postalCode": "98004-5804" | ||
| }, | ||
| { | ||
| "country": "US", | ||
| "region": "WA", | ||
| "city": "Bellevue", | ||
| "addressLine1": "104 110th Ave NE", | ||
| "postalCode": "98004-5804" | ||
| } | ||
| ], | ||
| "validationMessage" : "Invalid address" | ||
| } | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is validation error message part of the request body. If the validation on an address fails, shouldnt it return an error with the details part of the error body which complies with the ARM RPC error contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation error message is not part of request body. If AV fails, it returns a message in ValidationMessage property which is a part of Response object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i meant response body itself. What i meant is -> if POST /validateAddress fails to validate an address, shouldnt the response should be a failure? In the current model, the response will be a successful response, with the validation failure in the response body.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, yes, it always responds with 200, we internally call into other service which always returns 200, with validation results in response body. We apply some business logic and return 200.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks for confirming.