[Do not merge] Adding workspace level quota management APIs by leizhaoPS · Pull Request #5972 · Azure/azure-rest-api-specs

leizhaoPS · 2019-05-15T22:11:52Z

To update quota, we use the Post call with the action quota URI (similar to Usages): subscriptions/{subscriptionId}/providers/Microsoft.BatchAI/locations/{locationName}/updateQuotas

Parameters of this call:
Subscription ID (uri)
location (uri)
vmFamily (body)
workspaceId (body)
Quota (body)
api-version (query)

To get quota, we use Post call on the list action quota URI: subscriptions/{subscriptionId}/providers/Microsoft.BatchAI/locations/{locationName}/listQuotas

Parameters of this call:
Subscription ID (uri)
location (uri)
api-version (query)
Changes:
Added new API for update Quotas
Added new API for list Quotas
Added two examples:
ListWorkspaceQuotasByVMFamily.json
UpdateQuota.json

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…nd put quota

AutorestCI · 2019-05-15T22:12:37Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout cd8b1d2f6b320240b5c72320cfe196fe0cd8f68b
  stderr: 'fatal: reference is not a tree: cd8b1d2f6b320240b5c72320cfe196fe0cd8f68b'

AutorestCI · 2019-05-15T22:12:45Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-05-15T22:13:07Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3846

AutorestCI · 2019-05-15T22:14:09Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout cd8b1d2f6b320240b5c72320cfe196fe0cd8f68b
  stderr: 'fatal: reference is not a tree: cd8b1d2f6b320240b5c72320cfe196fe0cd8f68b'

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json

azuresdkci · 2019-05-15T22:42:45Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-15T22:43:21Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

leizhaoPS · 2019-05-17T19:17:58Z

Consider folks will give comments, close the draft PR and I will reopen a new PR

leizhaoPS · 2019-05-17T19:21:44Z

reopen as normal PR

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json

KrisBash

Please see comments

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json

sanjaiganesh · 2019-06-01T05:52:34Z

Adding ArmFeedbackRequested as there is one comment that is not responded to (or addressed) .. on adding this under preview api first.. also another minor comment I have added on operation name

openapi-sdkautomation · 2019-06-05T21:53:56Z

SDK Automation [Logs] (Generated from fcd620f)

Go: Azure/azure-sdk-for-go [Logs] [Diff]

preview/machinelearning/mgmt/2018-03-01-preview [Logs] [Instructions]
- preview.machinelearning.mgmt.2018-03-01-preview.zip

Python: Azure/azure-sdk-for-python [Logs] [Diff]

No packages generated.

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@azure/arm-machinelearningservices [Logs] [Instructions]
- azure-arm-machinelearningservices-2.1.0.tgz

shahabhijeet · 2019-08-02T20:19:25Z

@leizhaoPS all jobs are failing and this PR has [Do Not Merge]
Are you still thinking of merging this PR? if yes please make sure the CI is green.

yungezz · 2019-08-08T07:27:01Z

hi @leizhaoPS are you still on this PR? could you pls address comments and fix CI?

leizhaoPS · 2019-08-08T17:02:13Z

Sorry, the purpose of this PR is to get design sign-off from ARM, for now I close it and will check-in a new version later

add workspace level quota management APIs which including get quota a…

87b00a3

…nd put quota

azuresdkci assigned shahabhijeet May 15, 2019

azuresdkci requested a review from shahabhijeet May 15, 2019 22:12

AutorestCI mentioned this pull request May 15, 2019

[AutoPR machinelearningservices/resource-manager] Adding workspace level quota management APIs Azure/azure-sdk-for-js#2921

Closed

nschonni reviewed May 15, 2019

View reviewed changes

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json Outdated Show resolved Hide resolved

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json Outdated Show resolved Hide resolved

leizhaoPS added 2 commits May 16, 2019 12:18

post quota support batch

c440eb4

renaming description

7cc5476

AutorestCI mentioned this pull request May 17, 2019

[AutoPR machinelearningservices/resource-manager] Adding workspace level quota management APIs Azure/azure-sdk-for-python#5298

Closed

leizhaoPS closed this May 17, 2019

leizhaoPS reopened this May 17, 2019

leizhaoPS marked this pull request as ready for review May 17, 2019 20:41

leizhaoPS commented May 17, 2019

View reviewed changes

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json Outdated Show resolved Hide resolved

leizhaoPS commented May 17, 2019

View reviewed changes

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json Outdated Show resolved Hide resolved

KrisBash suggested changes May 17, 2019

View reviewed changes

move quota API to preview

97e9adc

This was referenced May 20, 2019

[AutoPR machinelearningservices/resource-manager] Adding workspace level quota management APIs Azure/azure-sdk-for-js#3049

Closed

[AutoPR machinelearningservices/resource-manager] Adding workspace level quota management APIs Azure/azure-sdk-for-go#4836

Closed

nschonni reviewed May 20, 2019

View reviewed changes

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json Outdated Show resolved Hide resolved

leizhaoPS added 2 commits May 20, 2019 17:34

fix typo

b8ed2d0

fix lintdiff validation errors

c9b5521

AutorestCI mentioned this pull request May 21, 2019

[AutoPR machinelearningservices/resource-manager] Adding workspace level quota management APIs Azure/azure-sdk-for-js#3082

Closed

ravbhatnagar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 21, 2019

sanjaiganesh reviewed Jun 1, 2019

View reviewed changes

...er/Microsoft.MachineLearningServices/preview/2018-03-01-preview/machineLearningServices.json Outdated Show resolved Hide resolved

sanjaiganesh added the ARMChangesRequested label Jun 1, 2019

leizhaoPS changed the title ~~Adding workspace level quota management APIs~~ [Do not merge] Adding workspace level quota management APIs Jun 5, 2019

update quota API response schema and samples

fcd620f

Modify get Quotas, updateQuotas request and response structure

0a49a47

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR machinelearningservices/resource-manager] [Do not merge] Adding workspace level quota management APIs Azure/azure-sdk-for-js#3846

Closed

shahabhijeet removed their assignment Aug 2, 2019

yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 5, 2019

yungezz self-assigned this Aug 5, 2019

leizhaoPS closed this Aug 8, 2019

Conversation

leizhaoPS commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

Uh oh!

Uh oh!

azuresdkci commented May 15, 2019

Uh oh!

AutorestCI commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

leizhaoPS commented May 17, 2019

Uh oh!

leizhaoPS commented May 17, 2019

Uh oh!

Uh oh!

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sanjaiganesh commented Jun 1, 2019

Uh oh!

openapi-sdkautomation bot commented Jun 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from fcd620f)

Uh oh!

shahabhijeet commented Aug 2, 2019

Uh oh!

yungezz commented Aug 8, 2019

Uh oh!

leizhaoPS commented Aug 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

leizhaoPS commented May 15, 2019 •

edited

Loading

AutorestCI commented May 15, 2019 •

edited

Loading

AutorestCI commented May 15, 2019 •

edited

Loading

AutorestCI commented May 15, 2019 •

edited

Loading

AutorestCI commented May 15, 2019 •

edited

Loading

AutorestCI commented May 15, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 5, 2019 •

edited

Loading