Skip to content

DNS: generating the 2018-05-01 Go SDK#5966

Merged
jhendrixMSFT merged 1 commit intoAzure:masterfrom
tombuildsstuff:f/generate-dns-sdk
May 15, 2019
Merged

DNS: generating the 2018-05-01 Go SDK#5966
jhendrixMSFT merged 1 commit intoAzure:masterfrom
tombuildsstuff:f/generate-dns-sdk

Conversation

@tombuildsstuff
Copy link
Contributor

This PR generates the Go SDK for the DNS API version 2018-05-01. This is required so that we can represent the resource:

{
    "name": "recordname",
    "type": "Microsoft.Network/dnszones/A",
    "properties": {
        "TTL": 60,
        "targetResource": {
            "id": "front_door_id"
        },
        "ARecords": null,
        "AAAARecords": null,
        "CNAMERecord": null,
        "MXRecords": null,
        "NSRecords": null,
        "SOARecord": null,
        "SRVRecords": null,
        "TXTRecords": null,
        "PTRRecords": null
    }
}

cc @jhendrixMSFT


Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented May 15, 2019

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented May 15, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented May 15, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented May 15, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4803

@AutorestCI
Copy link

AutorestCI commented May 15, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@jhendrixMSFT jhendrixMSFT merged commit 4e33158 into Azure:master May 15, 2019
@tombuildsstuff tombuildsstuff deleted the f/generate-dns-sdk branch May 15, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants