[Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview by msft-adrianma · Pull Request #5962 · Azure/azure-rest-api-specs

msft-adrianma · 2019-05-15T01:20:59Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2019-05-15T01:21:45Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-05-15T01:21:58Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5564

AutorestCI · 2019-05-15T01:22:24Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#3633

AutorestCI · 2019-05-15T01:23:43Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4984

REST Spec PR 'Azure/azure-rest-api-specs#5962' REST Spec PR Author 'msft-adrianma' REST Spec PR Last commit

adxsdknet · 2019-05-15T01:27:55Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6273
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@7e36ae2
adxsdknet/azure-sdk-for-net@b84eb56

azuresdkci · 2019-05-15T01:54:28Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-15T04:42:07Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpbhbyohia/rest/specification/billing/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp7ysremg1']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/CreateBillingProfile.json

REST Spec PR 'Azure/azure-rest-api-specs#5962' REST Spec PR Author 'msft-adrianma' REST Spec PR Last commit

ravbhatnagar

please take a look at the comments

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

jhendrixMSFT · 2019-05-31T16:23:17Z

@AutorestCI regenerate azure-sdk-for-go

sanjaiganesh · 2019-06-01T02:04:41Z

It looks there is an open item .. being followed up with Krish (per comments). Krish is oncall next week.. so deferring to him.

openapi-sdkautomation · 2019-06-10T18:57:20Z

SDK Automation [Logs] (Generated from f6c1106)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

KrisBash

Signing off for ARM. Please revisit POST vs PUT for future version.

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/CreateBillingProfile.json

jhendrixMSFT

Please fix model validation failure.

…n requests.

adding swagger for create billing profile

cc875ae

msft-adrianma requested a review from wilcobmsft as a code owner May 15, 2019 01:20

AutorestCI mentioned this pull request May 15, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-python#5240

Closed

azuresdkci assigned jhendrixMSFT May 15, 2019

azuresdkci requested a review from jhendrixMSFT May 15, 2019 01:22

AutorestCI mentioned this pull request May 15, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-js#2907

Closed

AutorestCI mentioned this pull request May 15, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-go#4801

Closed

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 15, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 15, 2019

.NET SDK Resource Provider:'Billing'

7e36ae2

REST Spec PR 'Azure/azure-rest-api-specs#5962' REST Spec PR Author 'msft-adrianma' REST Spec PR Last commit

AutorestCI mentioned this pull request May 15, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-java#3648

Closed

wilcobmsft reviewed May 16, 2019

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json Outdated Show resolved Hide resolved

wilcobmsft reviewed May 16, 2019

View reviewed changes

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/CreateBillingProfile.json Outdated Show resolved Hide resolved

updates based on feedback.

697ed2c

AutorestCI mentioned this pull request May 16, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-js#2959

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 16, 2019

.NET SDK Resource Provider:'Billing'

b84eb56

REST Spec PR 'Azure/azure-rest-api-specs#5962' REST Spec PR Author 'msft-adrianma' REST Spec PR Last commit

wilcobmsft approved these changes May 16, 2019

View reviewed changes

ravbhatnagar reviewed May 17, 2019

View reviewed changes

ravbhatnagar added the ARMChangesRequested label May 17, 2019

AutorestCI mentioned this pull request May 31, 2019

[AutoPR billing/resource-manager] [Hub Generated] Review request for Microsoft.Billing to add version preview/2018-11-01-preview Azure/azure-sdk-for-go#4919

Closed

removing CreatAzureSubscriptions request parameter as per feedback.

0cf3d30

KrisBash approved these changes Jun 10, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 10, 2019

jhendrixMSFT reviewed Jun 10, 2019

View reviewed changes

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/CreateBillingProfile.json Show resolved Hide resolved

jhendrixMSFT reviewed Jun 10, 2019

View reviewed changes

...urce-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/CreateBillingProfile.json Show resolved Hide resolved

jhendrixMSFT requested changes Jun 10, 2019

View reviewed changes

fixing model validation failure. skuid should be settable for creatio…

f6c1106

…n requests.

jhendrixMSFT approved these changes Jun 10, 2019

View reviewed changes

jhendrixMSFT merged commit 31165ad into Azure:master Jun 10, 2019

Conversation

msft-adrianma commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

AutorestCI commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

adxsdknet commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

azuresdkci commented May 15, 2019

Uh oh!

AutorestCI commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

Uh oh!

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jhendrixMSFT commented May 31, 2019

Uh oh!

sanjaiganesh commented Jun 1, 2019

Uh oh!

openapi-sdkautomation bot commented Jun 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from f6c1106)

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Comments

msft-adrianma commented May 15, 2019 •

edited

Loading

AutorestCI commented May 15, 2019 •

edited

Loading

AutorestCI commented May 15, 2019 •

edited

Loading

AutorestCI commented May 15, 2019 •

edited

Loading

AutorestCI commented May 15, 2019 •

edited

Loading

adxsdknet commented May 15, 2019 •

edited

Loading

AutorestCI commented May 15, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 10, 2019 •

edited

Loading