[Do Not Merge] Kusto: Add support for attached databases by radennis · Pull Request #5933 · Azure/azure-rest-api-specs

radennis · 2019-05-13T11:59:26Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

… gneerated swagger successfully

AutorestCI · 2019-05-13T12:00:15Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2019-05-13T12:00:30Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-05-13T12:00:33Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#5707

AutorestCI · 2019-05-13T12:02:09Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp10y_6e82/rest/specification/azure-kusto/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmppmi50a2b']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-05-13T12:02:10Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#4785

azuresdkci · 2019-05-13T12:33:00Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5933' REST Spec PR Author 'radennis' REST Spec PR Last commit

adxsdknet · 2019-05-13T12:36:33Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6253
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@552d689
adxsdknet/azure-sdk-for-net@028c2df
adxsdknet/azure-sdk-for-net@6bdd102

...soft.Kusto/stable/2019-01-21/generated/AttachedDatabaseConfigurationsOperationsExtensions.cs

REST Spec PR 'Azure/azure-rest-api-specs#5933' REST Spec PR Author 'radennis' REST Spec PR Last commit

radennis · 2019-05-16T14:41:47Z

@kpajdzik do you have any other comments or can approve?

kpajdzik · 2019-05-16T23:08:38Z

@kpajdzik do you have any other comments or can approve?

Could you resolve the merge conflicts? I'll merge after the resolution.

radennis · 2019-05-18T11:05:14Z

Thanks @kpajdzik. Please do not merge yet. The CR is here to make sure it is approved by the SDK and ARM folks before going forward. Thanks!

REST Spec PR 'Azure/azure-rest-api-specs#5933' REST Spec PR Author 'radennis' REST Spec PR Last commit

kpajdzik · 2019-05-20T16:41:23Z

Thanks @kpajdzik. Please do not merge yet. The CR is here to make sure it is approved by the SDK and ARM folks before going forward. Thanks!

I'm adding ARM team if you need their review. I believe I'm one of the "SDK folks" so we have this checked :)

radennis · 2019-05-20T17:05:27Z

That's great, thanks @kpajdzik. Regarding ARM, would appreciate @KrisBash's approval since he attended the design review.

sanjaiganesh · 2019-06-01T01:37:57Z

KrishBash is ARM reviewer next week. I would defer to Krish this as Ravit suggested.

radennis · 2019-06-04T14:30:59Z

@KrisBash could you please take a look and approve per our design? Just to make it clear, we're not looking into pushing this change now. Just getting your approval, so that once the feature is complete we can add it to the swagger.

KrisBash

Thanks for working closely with us on this one. - it looks as expected. I had a few questions in my comments.

specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2019-01-21/kusto.json

openapi-sdkautomation · 2019-06-06T15:33:23Z

SDK Automation [Logs] (Generated from 48f2ed9)

Python: Azure/azure-sdk-for-python

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

KrisBash

LGTM

radennis · 2019-06-10T10:12:42Z

Thanks @KrisBash !
Closing the PR for until we want to push it.

radennis added 4 commits May 8, 2019 01:29

Added attached database configuration resource and operations, and it…

dfe4133

… gneerated swagger successfully

Add list and detach actions from the leader

1a72e44

fixing database configuration all to include a list of database names

21ae14c

Changing database to have kinds of read only attached and read write

6c3d677

AutorestCI mentioned this pull request May 13, 2019

[AutoPR azure-kusto/resource-manager] Kusto: Add support for attached databases Azure/azure-sdk-for-python#5195

Closed

This was referenced May 13, 2019

[AutoPR azure-kusto/resource-manager] Kusto: Add support for attached databases Azure/azure-sdk-for-java#3628

Closed

[AutoPR azure-kusto/resource-manager] Kusto: Add support for attached databases Azure/azure-sdk-for-go#4785

Closed

radennis changed the title ~~Kusto: Add support for attached databases~~ [Do Not Merge] Kusto: Add support for attached databases May 13, 2019

azuresdkci assigned kpajdzik May 13, 2019

azuresdkci requested a review from kpajdzik May 13, 2019 12:23

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 13, 2019

.NET SDK Resource Provider:'Kusto'

552d689

REST Spec PR 'Azure/azure-rest-api-specs#5933' REST Spec PR Author 'radennis' REST Spec PR Last commit

kpajdzik reviewed May 13, 2019

View reviewed changes

...soft.Kusto/stable/2019-01-21/generated/AttachedDatabaseConfigurationsOperationsExtensions.cs Outdated Show resolved Hide resolved

radennis added 2 commits May 14, 2019 07:58

Removing generated files

03c137b

Simplify attached database configuration not to include a kind

27c7090

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 14, 2019

.NET SDK Resource Provider:'Kusto'

028c2df

REST Spec PR 'Azure/azure-rest-api-specs#5933' REST Spec PR Author 'radennis' REST Spec PR Last commit

kpajdzik approved these changes May 16, 2019

View reviewed changes

Add list attached databases by cluster

e420f5a

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 20, 2019

.NET SDK Resource Provider:'Kusto'

6bdd102

REST Spec PR 'Azure/azure-rest-api-specs#5933' REST Spec PR Author 'radennis' REST Spec PR Last commit

kpajdzik added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 20, 2019

ravbhatnagar added the ARMReviewInProgress label May 20, 2019

Fix casing

e136a66

KrisBash suggested changes Jun 6, 2019

View reviewed changes

KrisBash added ARMChangesRequested and removed ARMReviewInProgress labels Jun 6, 2019

Address comments

48f2ed9

AutorestCI mentioned this pull request Jun 6, 2019

[AutoPR azure-kusto/resource-manager] [Do Not Merge] Kusto: Add support for attached databases Azure/azure-sdk-for-python#5707

Closed

KrisBash approved these changes Jun 6, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 6, 2019

radennis closed this Jun 10, 2019

docohe mentioned this pull request Sep 24, 2019

[Hub Generated] Review request for Microsoft.Kusto to add version stable/2019-09-07 #7300

Merged

2 tasks

Conversation

radennis commented May 13, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented May 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented May 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented May 13, 2019

Uh oh!

adxsdknet commented May 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

Uh oh!

radennis commented May 16, 2019

Uh oh!

kpajdzik commented May 16, 2019

Uh oh!

radennis commented May 18, 2019

Uh oh!

kpajdzik commented May 20, 2019

Uh oh!

radennis commented May 20, 2019

Uh oh!

sanjaiganesh commented Jun 1, 2019

Uh oh!

radennis commented Jun 4, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openapi-sdkautomation bot commented Jun 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from 48f2ed9)

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

radennis commented Jun 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

AutorestCI commented May 13, 2019 •

edited

Loading

AutorestCI commented May 13, 2019 •

edited

Loading

AutorestCI commented May 13, 2019 •

edited

Loading

AutorestCI commented May 13, 2019 •

edited

Loading

AutorestCI commented May 13, 2019 •

edited

Loading

adxsdknet commented May 13, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 6, 2019 •

edited

Loading

radennis commented Jun 10, 2019 •

edited

Loading