API for usages by VM family, Workspace & Compute by nkalpana · Pull Request #5910 · Azure/azure-rest-api-specs

nkalpana · 2019-05-10T00:29:43Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

New Usage API with detailed breakdown of usage by VM Family, Workspace and Compute

Added a new API usagesbyvmfamily
Added a new defintion UsageByVMFamily extending an existing Usage definition, with some new properties
Added new example for the API

Validation

{ message: 'Semantically validating specification\machinelearningservices\resource-manager\Microsoft.MachineLearningServices\stable\2018-11-19\machineLearningServices.json:\n',
level: '\u001b[32minfo\u001b[39m' }
{ message: 'No Errors were found.',
level: '\u001b[32minfo\u001b[39m' }

AutorestCI · 2019-05-10T00:30:28Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e3f8a701ad81bd624ce08441cfe2693435ea8d8a
  stderr: 'fatal: reference is not a tree: e3f8a701ad81bd624ce08441cfe2693435ea8d8a'

AutorestCI · 2019-05-10T00:30:30Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e3f8a701ad81bd624ce08441cfe2693435ea8d8a
  stderr: 'fatal: reference is not a tree: e3f8a701ad81bd624ce08441cfe2693435ea8d8a'

azuresdkci · 2019-05-10T00:30:32Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-10T00:30:35Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#2800

AutorestCI · 2019-05-10T00:32:00Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e3f8a701ad81bd624ce08441cfe2693435ea8d8a
  stderr: 'fatal: reference is not a tree: e3f8a701ad81bd624ce08441cfe2693435ea8d8a'

AutorestCI · 2019-05-10T05:30:35Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout e3f8a701ad81bd624ce08441cfe2693435ea8d8a
  stderr: 'fatal: reference is not a tree: e3f8a701ad81bd624ce08441cfe2693435ea8d8a'

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json

jhendrixMSFT · 2019-05-10T16:03:41Z

This swagger isn't referenced in the README.md file, can you please add it?

jhendrixMSFT · 2019-05-13T17:31:49Z

specification/machinelearningservices/resource-manager/readme.go.md


 ```yaml $(go) && $(multiapi)
 batch:
-  - tag: package-2018-03-preview


This will stop building package-2018-03-preview, is that intentional? Both can be built.

ravbhatnagar

@nkalpana - please comply with the ARM /usages contract for this new API.

ravbhatnagar · 2019-05-13T18:35:39Z

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json

        }
      }
    },
+    "/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/locations/{location}/usagesByVMFamily": {


Please comply with the ARM usages contract for this API. It is defined here - https://armwiki.azurewebsites.net/api_contracts/UsagesAPIContract.html

@nkalpana Could you update per ARM usages api contract ?

jhendrixMSFT · 2019-05-14T19:59:11Z

...Microsoft.MachineLearningServices/stable/2018-11-19/examples/ListUsagesByVMFamilyResult.json

+              "value": "Clusters",
+              "localizedValue": "Clusters"
+            },
+            "resourceType": "TotalClusters",


According to the swagger, resourceType and resourceGroupName are supposed to be under a properties key like this.

"properties": { "resourceType": "TotalClusters", "resourceGroupName": "rg" }

This is causing model validation failures, see the log.
Comment applies to all items in the array.

jhendrixMSFT · 2019-05-14T20:01:30Z

Please also look at the model validation failures for operation ID MachineLearningCompute_Update.

KrisBash · 2019-06-05T03:18:25Z

Is this to be replaced by PR: #6173?

ravbhatnagar · 2019-06-27T22:59:06Z

This PR is not needed any more. removing ARM labels. The owner will abandon this one.

jhendrixMSFT · 2019-06-28T15:24:22Z

Closing per comments.

JackTn · 2021-08-23T03:41:05Z

Hi, @nkalpana. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch.

JackTn · 2022-06-16T03:30:07Z

Hi, @nkalpana. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

API for usages by VM family, Workspace & Compute

9bc0249

nkalpana self-assigned this May 10, 2019

AutorestCI mentioned this pull request May 10, 2019

[AutoPR machinelearningservices/resource-manager] API for usages by VM family, Workspace & Compute Azure/azure-sdk-for-python#5166

Closed

AutorestCI mentioned this pull request May 10, 2019

[AutoPR machinelearningservices/resource-manager] API for usages by VM family, Workspace & Compute Azure/azure-sdk-for-js#2800

Closed

nkalpana requested review from jhendrixMSFT, msoni3 and pradeepgunda May 10, 2019 00:31

nschonni reviewed May 10, 2019

View reviewed changes

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json Outdated Show resolved Hide resolved

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 10, 2019

jhendrixMSFT reviewed May 10, 2019

View reviewed changes

...rce-manager/Microsoft.MachineLearningServices/stable/2018-11-19/machineLearningServices.json Outdated Show resolved Hide resolved

Fix casing and description

b55b01c

nkalpana requested a review from jhendrixMSFT May 10, 2019 19:29

kanpilot added 3 commits May 10, 2019 17:03

Fix version in readmes

2a8a96f

Fix one more minor version change

880a0cc

Changed scenario name to be unique

ce1f8ea

jhendrixMSFT reviewed May 13, 2019

View reviewed changes

ravbhatnagar reviewed May 13, 2019

View reviewed changes

ravbhatnagar added the ARMChangesRequested label May 13, 2019

kanpilot added 5 commits May 13, 2019 15:18

Fixing lint diff errors

cf7adf9

Fix parameter issue in example

cbfb276

Changing status to 200

43a84c2

tring a different name for API

edac207

putting allOf on top and setting type as object

42a30a9

kanpilot and others added 6 commits May 14, 2019 00:42

using a diferent name for usage

187b62d

add resoureGropuName to a path to see error picks

b778ceb

Attempting another name change

818fb99

adding type object to Usage base definition

b2f6361

add back package-2018-03-preview

93f144c

fix Go SDK package path

6785f7b

jhendrixMSFT reviewed May 14, 2019

View reviewed changes

KrisBash mentioned this pull request Jun 5, 2019

[DO NOT MERGE] Adding usage id property to support usages by VM family, Workspace & Comput #6173

Closed

5 tasks

ravbhatnagar removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 27, 2019

jhendrixMSFT closed this Jun 28, 2019

JackTn deleted the kanatara/usagesbyvmfamily_new_api branch July 5, 2022 01:21

Comments

Conversation

nkalpana commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

New Usage API with detailed breakdown of usage by VM Family, Workspace and Compute

Validation

Uh oh!

AutorestCI commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

azuresdkci commented May 10, 2019

Uh oh!

AutorestCI commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

Uh oh!

Uh oh!

jhendrixMSFT commented May 10, 2019

Uh oh!

jhendrixMSFT May 13, 2019

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar May 13, 2019

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh May 31, 2019

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT May 14, 2019

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT commented May 14, 2019

Uh oh!

KrisBash commented Jun 5, 2019

Uh oh!

ravbhatnagar commented Jun 27, 2019

Uh oh!

jhendrixMSFT commented Jun 28, 2019

Uh oh!

JackTn commented Aug 23, 2021

Uh oh!

JackTn commented Jun 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nkalpana commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading