Skip to content

chore: jsonfmt network 2017#5902

Merged
dsgouda merged 2 commits intoAzure:masterfrom
nschonni:chore--jsonfmt-network-2017
May 23, 2019
Merged

chore: jsonfmt network 2017#5902
dsgouda merged 2 commits intoAzure:masterfrom
nschonni:chore--jsonfmt-network-2017

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented May 9, 2019

Ran jsonfmt -w "specification/network/**/stable/2017*/**/*.json"

@nschonni nschonni requested a review from MikhailTryakhov as a code owner May 9, 2019 18:34
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented May 9, 2019

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2478

@AutorestCI
Copy link

AutorestCI commented May 9, 2019

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmp5b_dz9h2/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp5b_dz9h2/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.133', '--use-onever', '--verbose']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Including configuration file 'file:///tmp/tmp5b_dz9h2/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.133->2.1.133)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-02"} .
   Including configuration file 'file:///tmp/tmp5b_dz9h2/rest/specification/network/resource-manager/readme.go.md'

<--- Last few GCs --->

[28820:0x2eeb8c0]    85180 ms: Mark-sweep 1382.8 (1467.3) -> 1382.5 (1473.3) MB, 1498.8 / 0.0 ms  allocation failure GC in old space requested
[28820:0x2eeb8c0]    86681 ms: Mark-sweep 1382.5 (1473.3) -> 1382.4 (1436.8) MB, 1500.4 / 0.0 ms  last resort GC in old space requested
[28820:0x2eeb8c0]    88188 ms: Mark-sweep 1382.4 (1436.8) -> 1382.4 (1432.8) MB, 1506.7 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x2ed8f64a5879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x3fcf792fb009](this=0x35e6e900fa69 <JSWeakMap>,key=0x2cb2a312bab1 <Object map = 0x5ce4725be31>,value=0x187886fc98b1 <String[6]: value2>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4302/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0x3fcf792e0839](this=0x16525db022d1 <...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x3fcf791042fd

@AutorestCI
Copy link

AutorestCI commented May 9, 2019

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmplpue_63i/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmplpue_63i/azure-sdk-for-js', '--use=@microsoft.azure/autorest.typescript@4.0.0']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4299/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4299)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (4.0.0->4.0.0)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

<--- Last few GCs --->

[13483:0x3f87860]    99378 ms: Mark-sweep 1383.2 (1465.0) -> 1383.1 (1466.0) MB, 1611.4 / 0.0 ms  allocation failure GC in old space requested
[13483:0x3f87860]   101069 ms: Mark-sweep 1383.1 (1466.0) -> 1383.1 (1429.0) MB, 1689.8 / 0.0 ms  last resort GC in old space requested
[13483:0x3f87860]   102699 ms: Mark-sweep 1383.1 (1429.0) -> 1383.1 (1425.5) MB, 1630.2 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x119fc0325879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x2e64ab18fc89](this=0x14ff891d1349 <JSWeakMap>,key=0x3c5503b19e29 <Object map = 0xa6256b34f51>,value=0x2654cde2eb39 <String[13]: CompositeType>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@microsoft.azure_autorest-core@2.0.4299/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0x2e64ab18fab9](this=0x3bf0aa...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x2e64aae842fd

@AutorestCI
Copy link

AutorestCI commented May 9, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5446

@dsgouda
Copy link
Contributor

dsgouda commented May 9, 2019

@sergey-shandar are these model validation errors expected?

@AutorestCI
Copy link

AutorestCI commented May 9, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

Ran `jsonfmt -w "specification/network/**/stable/2017*/**/*.json"`
@nschonni nschonni force-pushed the chore--jsonfmt-network-2017 branch from ca5b900 to 9b38577 Compare May 15, 2019 23:01
@nschonni
Copy link
Contributor Author

@MikhailTryakhov looks like the model validation is an existing issue. I can't tell which of the 3 examples for PublicIPAddresses_CreateOrUpdate is the one it's flagging to fix it

@EvgenyAgafonchikov
Copy link
Contributor

Updated failing example.

@nschonni, if you are interested in, you may wish to review available validation tools that allow to localize root causes of some specs or examples failures quickly. For example oav validate-example <path> returns details on all the examples referenced in spec file.

To check large set of files locally (and avoid waiting for CI results then) you may also script it like this

network\resource-manager\Microsoft.Network\stable>$(Get-ChildItem -Path . -Filter "2017*") | % { (Get-ChildItem $_.FullName | Where-Object { -not ($_ -is [System.IO.DirectoryInfo]) }) | % { & oav validate-example $_.FullName } }

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit bad63a8 into Azure:master May 23, 2019
@nschonni nschonni deleted the chore--jsonfmt-network-2017 branch May 23, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants