Swagger API for Azure CDN WebApplicationFirewallPolicy resource

[sushantsingh]

This PR includes the following changes

Adds

1. Added the swagger api spec for CdnWebApplicationFirewallPolicy which is a new (public preview) arm resource under the Microsoft.Cdn provider
2. Added the relevant examples

Edits

1. To integrate this with Azure CDN, a new property "webApplicationFirewallPolicyLink" is added to the "Endpoint" sub resource in cdn.json arm resource. This new property is the means by which a "CdnWebApplicationFirewallPolicy" can be references in a cdn "Endpoint" resource.
2. All the examples related to the "Endpoint" resource in cdn.json were edited to include this new property
3. Readme.md, a new package was added for this new change

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[sushantsingh]

Hi @devigned do you have any other pending concerns?

[devigned]

@sushantsingh please resolve the build issue. I know it is from a previous example, but it's not a good reason to keep propagating incorrect examples. Thank you!

[sushantsingh]

@devigned Sure I can try to fix the build issue but I have no idea what it means (I did try my best to reduce the error count due to existing issues by fixing everything I could understand).
Can you please help me understand what "message: Cannot read property 'readUInt8' of null" means?

Validating "examples" and "x-ms-examples" in specification/cdn/resource-manager/Microsoft.Cdn/preview/2019-06-15-preview/cdn.json:

error : ‌
operationId: CustomDomains_EnableCustomHttps
scenario: CustomDomains_EnableCustomHttpsUsingYourOwnCertificate
source: request
responseCode: ALL
severity: 0
code: INTERNAL_ERROR
details:
message: Cannot read property 'readUInt8' of null
code: INTERNAL_ERROR

[devigned]

Approved with the understanding that subscription level get will be added and cacheDuration will be converted to a ISO duration rather than a string before a stable release.

[devigned]

@KrisBash are you good for preview? @sushantsingh and I chatted and we have commitment to add a subscription level get, improved documentation for models / operations, and to start a conversation about migrating cache duration to an ISO duration rather than string for the stable release.

[sushantsingh]

Hi folks, this needs to be merged soon or we risk not meeting the preview release date of Jun 15th. Please let me know if anything is needed from our end to expedite things.
@KrisBash @amarzavery @devigned

[KrisBash]

Signing off with understanding that subscription level GET will be added for stable API version