Azure CDN WebApplicationFirewal Policy Swagger Implementation by sushantsingh · Pull Request #5878 · Azure/azure-rest-api-specs

sushantsingh · 2019-05-07T04:09:57Z

This PR adds the swagger API spec for a new ARM resource called "CdnWebApplicationFirewallPolicies".
There is also a change to the existing CDN swagger API, where a new property called "WebApplicationFirewallPolicyLink" has been added to the "Endpoint" resource.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-07T04:10:55Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 73c96960064a64761bc33a43c945248f23bed9cb
  stderr: 'fatal: reference is not a tree: 73c96960064a64761bc33a43c945248f23bed9cb'

AutorestCI · 2019-05-07T04:11:10Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 73c96960064a64761bc33a43c945248f23bed9cb
  stderr: 'fatal: reference is not a tree: 73c96960064a64761bc33a43c945248f23bed9cb'

AutorestCI · 2019-05-07T04:11:30Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 73c96960064a64761bc33a43c945248f23bed9cb
  stderr: 'fatal: reference is not a tree: 73c96960064a64761bc33a43c945248f23bed9cb'

AutorestCI · 2019-05-07T04:12:45Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 73c96960064a64761bc33a43c945248f23bed9cb
  stderr: 'fatal: reference is not a tree: 73c96960064a64761bc33a43c945248f23bed9cb'

AutorestCI · 2019-05-07T04:12:47Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 73c96960064a64761bc33a43c945248f23bed9cb
  stderr: 'fatal: reference is not a tree: 73c96960064a64761bc33a43c945248f23bed9cb'

azuresdkci · 2019-05-07T04:31:30Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5878' REST Spec PR Author 'sushantsingh' REST Spec PR Last commit

adxsdknet · 2019-05-07T05:36:51Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6163
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@89f4e7f
adxsdknet/azure-sdk-for-net@ac565de

nschonni · 2019-05-07T06:57:43Z

...ication/cdn/resource-manager/Microsoft.Cdn/preview/2019-06-15/cdnwebapplicationfirewall.json

+          "type": "string"
+        },
+        "enabled": {
+          "description": "Defines wheather the rule is enabled or not (defaults to true)",


Suggested change

"description": "Defines wheather the rule is enabled or not (defaults to true)",

"description": "Defines whether the rule is enabled or not (defaults to true)",

nschonni · 2019-05-07T06:57:57Z

...ication/cdn/resource-manager/Microsoft.Cdn/preview/2019-06-15/cdnwebapplicationfirewall.json

+          "type": "string"
+        },
+        "anomalyScore": {
+          "description": "Verizon only : If the rule set supports anomaly detection mode, this descibes the threshold for blocking requests.",


Suggested change

"description": "Verizon only : If the rule set supports anomaly detection mode, this descibes the threshold for blocking requests.",

"description": "Verizon only : If the rule set supports anomaly detection mode, this describes the threshold for blocking requests.",

…pi-specs

REST Spec PR 'Azure/azure-rest-api-specs#5878' REST Spec PR Author 'sushantsingh' REST Spec PR Last commit

sushantsingh added 30 commits May 1, 2019 17:01

Create cdnwebapplicationfirewall.json

ecd1590

Create CdnWafCreateOrUpdate

2e7fe09

Create CdnWafListPolicies.json

3da4bae

Create CdnWafPolicyGet.json

4bf7e26

Update cdnwebapplicationfirewall.json

d6245b5

Create WafListManagedRuleSets.json

5d9d8ca

Create WafListPolicies.json

2dbd94a

Create WafPolicyGet.json

7150826

Update WafListPolicies.json

8388fbd

Create WafPolicyCreateOrUpdate.json

80407bb

Create WafPolicyDelete.json

d75df78

Delete CdnWafCreateOrUpdate

3184996

Delete CdnWafListPolicies.json

7f102c8

Delete CdnWafPolicyGet.json

8690b45

Create cdn.json

7921410

Create readme.md

dc9d304

Update cdn.json

cd64866

Update cdnwebapplicationfirewall.json

b60f419

Update cdn.json

a081271

Update WafListManagedRuleSets.json

7932ada

Update cdnwebapplicationfirewall.json

581f3f5

Create Endpoints_Create.json

6f3d7d5

Update Endpoints_Get.json

c79203c

Create Endpoints_Get.json

308d627

Update Endpoints_Get.json

9184f2c

Create Endpoints_Update.json

fba9937

Update cdn.json

2f22ee0

Added examples which shows default behaviour

be55117

Update Endpoints_Get.json

74c5884

Update Endpoints_Update.json

6b539d9

sushantsingh added 6 commits May 6, 2019 20:57

Update Endpoints_Create.json

6bc53f8

Update Endpoints_Create.json

c43173b

Update Endpoints_Create.json

b7244ac

Update Endpoints_Create.json

ec89d67

Update Endpoints_Create.json

cb8c1b4

Update Endpoints_Create.json

dbbf70f

AutorestCI mentioned this pull request May 7, 2019

[AutoPR cdn/resource-manager] Azure CDN WebApplicationFirewal Policy Swagger Implementation Azure/azure-sdk-for-python#5129

Closed

AutorestCI mentioned this pull request May 7, 2019

[AutoPR cdn/resource-manager] Azure CDN WebApplicationFirewal Policy Swagger Implementation Azure/azure-sdk-for-js#2740

Closed

AutorestCI mentioned this pull request May 7, 2019

[AutoPR cdn/resource-manager] Azure CDN WebApplicationFirewal Policy Swagger Implementation Azure/azure-sdk-for-java#3568

Closed

AutorestCI mentioned this pull request May 7, 2019

[AutoPR cdn/resource-manager] Azure CDN WebApplicationFirewal Policy Swagger Implementation Azure/azure-sdk-for-go#4754

Closed

azuresdkci assigned sarangan12 May 7, 2019

azuresdkci requested a review from sarangan12 May 7, 2019 04:32

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 7, 2019

.NET SDK Resource Provider:'Cdn'

89f4e7f

REST Spec PR 'Azure/azure-rest-api-specs#5878' REST Spec PR Author 'sushantsingh' REST Spec PR Last commit

nschonni reviewed May 7, 2019

View reviewed changes

sushantsingh added 7 commits May 7, 2019 12:09

Update WafListPolicies.json

c3742e8

Update WafListManagedRuleSets.json

627bad3

Update WafPolicyCreateOrUpdate.json

84317bf

Update WafPolicyGet.json

a2e9d14

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

3580609

Merge branch 'master' of https://github.com/sushantsingh/azure-rest-a…

4ec7396

…pi-specs

Added new cdn version 2016-06-15

60fc948

sushantsingh closed this May 7, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 7, 2019

.NET SDK Resource Provider:'Cdn'

ac565de

REST Spec PR 'Azure/azure-rest-api-specs#5878' REST Spec PR Author 'sushantsingh' REST Spec PR Last commit

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Azure CDN WebApplicationFirewal Policy Swagger Implementation#5878

Azure CDN WebApplicationFirewal Policy Swagger Implementation#5878
sushantsingh wants to merge 71 commits intoAzure:masterfrom
sushantsingh:master

sushantsingh commented May 7, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 7, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 7, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 7, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 7, 2019 •

edited

Loading

Uh oh!

AutorestCI commented May 7, 2019 •

edited

Loading

Uh oh!

azuresdkci commented May 7, 2019

Uh oh!

adxsdknet commented May 7, 2019 •

edited

Loading

Uh oh!

nschonni May 7, 2019

Uh oh!

nschonni May 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	"description": "Defines wheather the rule is enabled or not (defaults to true)",
	"description": "Defines whether the rule is enabled or not (defaults to true)",

	"description": "Verizon only : If the rule set supports anomaly detection mode, this descibes the threshold for blocking requests.",
	"description": "Verizon only : If the rule set supports anomaly detection mode, this describes the threshold for blocking requests.",

Comments

Conversation

sushantsingh commented May 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented May 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented May 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented May 7, 2019

Uh oh!

adxsdknet commented May 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

nschonni May 7, 2019

Choose a reason for hiding this comment

Uh oh!

nschonni May 7, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sushantsingh commented May 7, 2019 •

edited

Loading

AutorestCI commented May 7, 2019 •

edited

Loading

AutorestCI commented May 7, 2019 •

edited

Loading

AutorestCI commented May 7, 2019 •

edited

Loading

AutorestCI commented May 7, 2019 •

edited

Loading

AutorestCI commented May 7, 2019 •

edited

Loading

adxsdknet commented May 7, 2019 •

edited

Loading