Add version 2019-03-01-preview Microsoft.ServiceFabric specification and fix package-2018-02 mismatched duplicate models #5852

a-santamaria · 2019-05-03T01:22:02Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-03T01:22:38Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2019-05-03T01:23:02Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5383

AutorestCI · 2019-05-03T01:23:06Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmpdb3gtuio/rest/specification/servicefabric/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp_6egyby1']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-05-03T01:24:48Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3731

AutorestCI · 2019-05-03T01:24:55Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4846

azuresdkci · 2019-05-03T01:50:33Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit

adxsdknet · 2019-05-03T02:04:26Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6090
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@7a3a91a
adxsdknet/azure-sdk-for-net@251e41e
adxsdknet/azure-sdk-for-net@25f3545

...efabric/resource-manager/Microsoft.ServiceFabric/preview/2019-03-01-preview/application.json

REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit

…pi-specs

REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit

sarangan12 · 2019-05-15T19:42:47Z

@a-santamaria Apologize for the delay. Please fix the errors reported at https://dev.azure.com/azure-sdk/public/_build/results?buildId=30903&view=logs&jobId=688669d0-441c-57c3-cf6d-f89a22ccfa5d

a-santamaria · 2019-05-15T20:24:33Z

@a-santamaria Apologize for the delay. Please fix the errors reported at https://dev.azure.com/azure-sdk/public/_build/results?buildId=30903&view=logs&jobId=688669d0-441c-57c3-cf6d-f89a22ccfa5d

@sarangan12 thanks for taking a look. the error reported is DuplicateModelCollsion saying that file: /Microsoft.ServiceFabric/preview/2017-07-01-preview/application.json has a definition of ApplicationHealthPolicy in line 973. But as you can see here I removed that definition from the file so I'm not sure why the check is still reporting that error.

sarangan12 · 2019-05-15T22:35:42Z

@a-santamaria Let me run some checks and update this PR

sarangan12 · 2019-05-16T21:19:58Z

This is definitely failing SDK generation. I am still debugging this. Will update soon.

a-santamaria · 2019-05-20T18:55:24Z

@sarangan12 any update on this? Is there an error in my changes that is causing this?

* .NET SDK Resource Provider:'ServiceFabric' REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit * .NET SDK Resource Provider:'ServiceFabric' REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit * .NET SDK Resource Provider:'ServiceFabric' REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit

Alfredo Santamaria Gomez added 3 commits May 2, 2019 12:47

adding version 2019-03-01-preview

64a5c16

changing ApplicationHealthPolicy definiton name to fix conflicts

b2842fb

add package-2019-03 tag and fix conflicting definitions

03507b1

AutorestCI mentioned this pull request May 3, 2019

[AutoPR servicefabric/resource-manager] Add version 2019-03-01-preview Microsoft.ServiceFabric specification and fix package-2018-02 mismatched duplicate models Azure/azure-sdk-for-python#5066

Merged

azuresdkci assigned sarangan12 May 3, 2019

azuresdkci requested a review from sarangan12 May 3, 2019 01:34

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 3, 2019

.NET SDK Resource Provider:'ServiceFabric'

7a3a91a

REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit

nschonni reviewed May 3, 2019

View reviewed changes

fix typos

45349e8

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 3, 2019

.NET SDK Resource Provider:'ServiceFabric'

251e41e

REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit

Alfredo Santamaria Gomez added 4 commits May 6, 2019 17:04

adding package-2018-02 and package-2019-03 to readme.ruby.md

0d9ff79

fixes for model validation errors

eb59e87

Merge branch 'master' of https://github.com/a-santamaria/azure-rest-a…

6ede91c

…pi-specs

fix tag package-2019-03 to use 2019-03 for both cluster and application

1e801a9

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 13, 2019

.NET SDK Resource Provider:'ServiceFabric'

25f3545

REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit

jhendrixMSFT closed this May 13, 2019

jhendrixMSFT reopened this May 13, 2019

fix Go SDK package path

ded9a9d

sarangan12 assigned amarzavery and unassigned sarangan12 May 21, 2019

sarangan12 requested review from amarzavery and removed request for sarangan12 May 21, 2019 17:44

amarzavery approved these changes May 21, 2019

View reviewed changes

sarangan12 merged commit 284f876 into Azure:master May 21, 2019

jhendrixMSFT mentioned this pull request Jul 17, 2019

Cannot build servicefabric package-2018-02 due to mismatched duplicate models #4359

Closed

Add version 2019-03-01-preview Microsoft.ServiceFabric specification and fix package-2018-02 mismatched duplicate models #5852

Add version 2019-03-01-preview Microsoft.ServiceFabric specification and fix package-2018-02 mismatched duplicate models #5852

Uh oh!

Conversation

a-santamaria commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented May 3, 2019

Uh oh!

adxsdknet commented May 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarangan12 commented May 15, 2019

Uh oh!

a-santamaria commented May 15, 2019

Uh oh!

sarangan12 commented May 15, 2019

Uh oh!

sarangan12 commented May 16, 2019

Uh oh!

a-santamaria commented May 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

a-santamaria commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

AutorestCI commented May 3, 2019 •

edited

Loading

adxsdknet commented May 3, 2019 •

edited

Loading