Skip to content

Add rulesEngine support to CDN#5850

Merged
sergey-shandar merged 13 commits intoAzure:masterfrom
hytao:ruleEngine1
May 6, 2019
Merged

Add rulesEngine support to CDN#5850
sergey-shandar merged 13 commits intoAzure:masterfrom
hytao:ruleEngine1

Conversation

@hytao
Copy link
Contributor

@hytao hytao commented May 3, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@hytao hytao requested a review from lmazuel May 3, 2019 00:28
@AutorestCI
Copy link

AutorestCI commented May 3, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#2723

@AutorestCI
Copy link

AutorestCI commented May 3, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4759

@AutorestCI AutorestCI mentioned this pull request May 3, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented May 3, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2439

@AutorestCI
Copy link

AutorestCI commented May 3, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4746

@AutorestCI
Copy link

AutorestCI commented May 3, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3281

This was referenced May 3, 2019
Merged
Merged
@azuresdkci azuresdkci requested a review from sarangan12 May 3, 2019 00:49
This was referenced May 3, 2019
Merged
Merged
@azuresdkci
Copy link
Contributor

azuresdkci commented May 3, 2019

Can one of the admins verify this patch?

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 3, 2019
@adxsdknet
.NET SDK Resource Provider:'Cdn'
7cad4e6 
REST Spec PR 'Azure/azure-rest-api-specs#5850'
REST Spec PR Author 'hytao'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented May 3, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6088
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@7cad4e6
adxsdknet/azure-sdk-for-net@412d428
adxsdknet/azure-sdk-for-net@3b2b729
adxsdknet/azure-sdk-for-net@44a4a95

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 3, 2019
@adxsdknet
.NET SDK Resource Provider:'Cdn'
412d428 
REST Spec PR 'Azure/azure-rest-api-specs#5850'
REST Spec PR Author 'hytao'
REST Spec PR Last commit
@dsgouda dsgouda mentioned this pull request May 3, 2019
Closed
@dsgouda
Copy link
Contributor

dsgouda commented May 3, 2019

@hytao did you push an initial commit where you copied over specs from a previous version. If not, please do so, so that I can review the new changes you are introducing in isolation

@hytao
Copy link
Contributor Author

hytao commented May 3, 2019

@dsgouda , I have push an initial commit for compassion.

@hytao
Copy link
Contributor Author

hytao commented May 3, 2019

Hi, I forgot to add links to the old PR in private repo. https://github.com/Azure/azure-rest-api-specs-pr/pull/746
This change has been approved by ARM reviewer.

@kpajdzik was working with me but his OOF today. Could anyone help me get this PR merged?
@dsgouda @nschonni

Thanks,
Hanyun

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 3, 2019
@adxsdknet
.NET SDK Resource Provider:'Cdn'
3b2b729 
REST Spec PR 'Azure/azure-rest-api-specs#5850'
REST Spec PR Author 'hytao'
REST Spec PR Last commit
@dsgouda
Copy link
Contributor

dsgouda commented May 3, 2019

@hytao There are some model validation errors here that need to be fixed.

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 4, 2019
@adxsdknet
.NET SDK Resource Provider:'Cdn'
44a4a95 
REST Spec PR 'Azure/azure-rest-api-specs#5850'
REST Spec PR Author 'hytao'
REST Spec PR Last commit
@hytao
Copy link
Contributor Author

hytao commented May 4, 2019

Hi @dsgouda @nschonni @kpajdzik @sergey-shandar @veronicagg

I have fixed most of the validation failure.

Could someone look at the log and tell me how to get rid of those remaining errors?
https://dev.azure.com/azure-sdk/public/_build/results?buildId=26350

Thanks,

@kpajdzik
Copy link
Contributor

kpajdzik commented May 6, 2019

Hi @dsgouda @nschonni @kpajdzik @sergey-shandar @veronicagg

I have fixed most of the validation failure.

Could someone look at the log and tell me how to get rid of those remaining errors?
https://dev.azure.com/azure-sdk/public/_build/results?buildId=26350

Thanks,

We'll merge it as soon as Veronica is online.

@sergey-shandar sergey-shandar merged commit 01e59df into Azure:master May 6, 2019
@kpajdzik
Copy link
Contributor

kpajdzik commented May 6, 2019

Thanks @sergey-shandar!

dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request May 7, 2019
@adxsdknet @dsgouda
AutoPr-Cdn-hytao-REST Spec PrNumber 5850 (#6088)
768bb19 
* .NET SDK Resource Provider:'Cdn'
REST Spec PR 'Azure/azure-rest-api-specs#5850'
REST Spec PR Author 'hytao'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Cdn'
REST Spec PR 'Azure/azure-rest-api-specs#5850'
REST Spec PR Author 'hytao'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Cdn'
REST Spec PR 'Azure/azure-rest-api-specs#5850'
REST Spec PR Author 'hytao'
REST Spec PR Last commit
@hytao hytao mentioned this pull request May 8, 2019
Merged
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
AutoPr-Cdn-hytao-REST Spec PrNumber 5850 (Azure#6088)
7a9be7c 
* .NET SDK Resource Provider:'Cdn'
REST Spec PR 'Azure/azure-rest-api-specs#5850'
REST Spec PR Author 'hytao'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Cdn'
REST Spec PR 'Azure/azure-rest-api-specs#5850'
REST Spec PR Author 'hytao'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Cdn'
REST Spec PR 'Azure/azure-rest-api-specs#5850'
REST Spec PR Author 'hytao'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

@sarangan12 sarangan12 Awaiting requested review from sarangan12

2 more reviewers

@nschonni nschonni nschonni left review comments

@kpajdzik kpajdzik kpajdzik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@hytao @AutorestCI @azuresdkci @adxsdknet @dsgouda @kpajdzik @nschonni @sarangan12 @sergey-shandar