[Microsoft.Advisor] Add metadata api by mudit794 · Pull Request #5826 · Azure/azure-rest-api-specs

mudit794 · 2019-05-01T19:42:00Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2019-05-01T19:42:31Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-01T19:42:47Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2453

AutorestCI · 2019-05-01T19:42:58Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#2631

AutorestCI · 2019-05-01T19:42:59Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5133

AutorestCI · 2019-05-01T19:44:29Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4756

AutorestCI · 2019-05-01T19:44:37Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3585

REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

adxsdknet · 2019-05-01T19:48:11Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6029
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@2872837
adxsdknet/azure-sdk-for-net@d2afbfc
adxsdknet/azure-sdk-for-net@251241b
adxsdknet/azure-sdk-for-net@8744968
adxsdknet/azure-sdk-for-net@e1a5d94
adxsdknet/azure-sdk-for-net@f11f2a2

REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

mudit794 · 2019-05-02T22:42:10Z

Can some one provide pointer on how to fix SDK node failure. Thanks

shahabhijeet

https://github.com/Azure/azure-rest-api-specs/pull/5826/files#diff-d0283661446defbd1a9caf436b028f0cR787
Have you considered having common error response align with what is documented on ARM guidelines
https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content

specification/advisor/resource-manager/Microsoft.Advisor/stable/2017-04-19/advisor.json

shahabhijeet · 2019-05-04T21:21:18Z

@amarzavery is the Node failure of any concern here. Can you take look and confirm if this failure can be/cannot be ignored
https://dev.azure.com/azure-sdk/public/_build/results?buildId=26159

amarzavery · 2019-05-06T17:44:13Z

Please ignore the nodejs failure and move ahead.

shahabhijeet · 2019-05-06T17:54:16Z

@mudit794 I have not heard back from you regarding aligning to common schema for error response.

REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

mudit794 · 2019-05-06T20:50:58Z

@mudit794 I have not heard back from you regarding aligning to common schema for error response.

@shahabhijeet Addressed feedback as per our offline conversation to revert current api error response and add feedback.md for future reference.

REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

shahabhijeet · 2019-05-07T19:48:14Z

Node sdk is a know issue and we have travis wide issue. So this PR is ok to be merged.

* .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

mudit794 added 2 commits May 1, 2019 12:39

Update advisor.json

adc29e9

Add examples for metadata api

681f743

This was referenced May 1, 2019

[AutoPR advisor/resource-manager] Add metadata api Azure/azure-sdk-for-js#2630

Merged

[AutoPR advisor/resource-manager] Add metadata api Azure/azure-sdk-for-python#5027

Merged

mudit794 changed the title ~~Add metadata api~~ [Microsoft.Advisor] Add metadata api May 1, 2019

azuresdkci assigned shahabhijeet May 1, 2019

azuresdkci requested a review from shahabhijeet May 1, 2019 19:44

AutorestCI mentioned this pull request May 1, 2019

[AutoPR advisor/resource-manager] Add metadata api Azure/azure-sdk-for-go#4727

Merged

AutorestCI mentioned this pull request May 1, 2019

[AutoPR advisor/resource-manager] Add metadata api Azure/azure-sdk-for-java#3497

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 1, 2019

.NET SDK Resource Provider:'Advisor'

2872837

REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

mudit794 added 8 commits May 1, 2019 13:02

Update GetRecommendationMetadataEntity.json

7df0571

Update ListRecommendationMetadata.json

1010d9d

Update GetRecommendationMetadataEntity.json

ee38171

Update ListRecommendationMetadata.json

ccf0a4d

Update advisor.json

0a738be

Update ListRecommendationMetadata.json

0573e35

Update GetRecommendationMetadataEntity.json

a6193d8

Add files via upload

7e7bfe1

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 2, 2019

.NET SDK Resource Provider:'Advisor'

d2afbfc

REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

mudit794 added 4 commits May 2, 2019 09:53

Update ListConfigurations_ResourceGroup.json

c46724e

Update ListConfigurations_Subscription.json

25ed91b

Update advisor.json

a2ef9d7

Update advisor.json

493af20

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 2, 2019

.NET SDK Resource Provider:'Advisor'

251241b

REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

Update ListRecommendationMetadata.json

88f4079

anthony-c-martin added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 2, 2019

Update advisor.json

53e25c3

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 2, 2019

.NET SDK Resource Provider:'Advisor'

8744968

REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

Update readme.md

448cb28

AutorestCI mentioned this pull request May 3, 2019

[AutoPR advisor/resource-manager] [Microsoft.Advisor] Add metadata api Azure/azure-sdk-for-ruby#2445

Merged

Update readme.md

625d146

anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 3, 2019

shahabhijeet suggested changes May 4, 2019

View reviewed changes

specification/advisor/resource-manager/Microsoft.Advisor/stable/2017-04-19/advisor.json Outdated Show resolved Hide resolved

specification/advisor/resource-manager/Microsoft.Advisor/stable/2017-04-19/advisor.json Outdated Show resolved Hide resolved

Update advisor.json

72b7f20

mudit794 added 2 commits May 6, 2019 13:06

Update advisor.json

3755450

Update GetRecommendationMetadataEntity.json

0ef4296

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 6, 2019

.NET SDK Resource Provider:'Advisor'

e1a5d94

REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

mudit794 added 3 commits May 7, 2019 09:41

Update advisor.json

964ebb8

Update GetRecommendationMetadataEntity.json

ca580cf

Create feedback.md

c598adf

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 7, 2019

.NET SDK Resource Provider:'Advisor'

f11f2a2

REST Spec PR 'Azure/azure-rest-api-specs#5826' REST Spec PR Author 'mudit794' REST Spec PR Last commit

shahabhijeet approved these changes May 7, 2019

View reviewed changes

shahabhijeet merged commit 0685351 into Azure:master May 7, 2019

Conversation

mudit794 commented May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azuresdkci commented May 1, 2019

Uh oh!

AutorestCI commented May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

adxsdknet commented May 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

mudit794 commented May 2, 2019

Uh oh!

shahabhijeet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shahabhijeet commented May 4, 2019

Uh oh!

amarzavery commented May 6, 2019

Uh oh!

shahabhijeet commented May 6, 2019

Uh oh!

mudit794 commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shahabhijeet commented May 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mudit794 commented May 1, 2019 •

edited

Loading

AutorestCI commented May 1, 2019 •

edited

Loading

AutorestCI commented May 1, 2019 •

edited

Loading

AutorestCI commented May 1, 2019 •

edited

Loading

AutorestCI commented May 1, 2019 •

edited

Loading

AutorestCI commented May 1, 2019 •

edited

Loading

adxsdknet commented May 1, 2019 •

edited

Loading

mudit794 commented May 6, 2019 •

edited

Loading