Skip to content

Blueprints: Update swagger for new example file#5825

Merged
sergey-shandar merged 1 commit intoAzure:masterfrom
filizt:newExamples
May 1, 2019
Merged

Blueprints: Update swagger for new example file#5825
sergey-shandar merged 1 commit intoAzure:masterfrom
filizt:newExamples

Conversation

@filizt
Copy link
Contributor

@filizt filizt commented May 1, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci azuresdkci requested a review from dsgouda May 1, 2019 18:01
@AutorestCI
Copy link

AutorestCI commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@azuresdkci
Copy link
Contributor

azuresdkci commented May 1, 2019

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented May 1, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

dsgouda
dsgouda approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented May 1, 2019 •
edited
Loading

@sergey-shandar Please take a look at the model validation failures

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 1, 2019
@adxsdknet
.NET SDK Resource Provider:'Blueprint'
53e2a27 
REST Spec PR 'Azure/azure-rest-api-specs#5825'
REST Spec PR Author 'filizt'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented May 1, 2019

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6023
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@53e2a27

@sergey-shandar sergey-shandar merged commit ea648b9 into Azure:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@filizt @AutorestCI @azuresdkci @dsgouda @adxsdknet @sergey-shandar