Skip to content

Conversation

@xizha162
Copy link
Contributor

Merge 2019-04-01 container service from dev branch to master
The following changes are included and already approved when merging to the dev branch:

Adding windowsProfile and maxAgentPools property in the new 2019-04-01 (#5465)
adding load balancer sku property (#5556)
Add support VMSS agent nodes with public IP. (#5748)
Add identity property in managedCluster definition and add an example(#5709)
node resource group can be read-write(#5762)
Update managed cluster upgrades(#5789)

I also included a minor change to include 2019-04-01 in 2019-04 package.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5009

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#2610

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Apr 30, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4714

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 30, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5797'
REST Spec PR Author 'xizhamsft'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Apr 30, 2019

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6000
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@ab580a2
adxsdknet/azure-sdk-for-net@4877af7

@praries880 praries880 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 30, 2019
@praries880 praries880 merged commit 0987d5a into Azure:master Apr 30, 2019
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request May 1, 2019
* .NET SDK Resource Provider:'ContainerService'
REST Spec PR 'Azure/azure-rest-api-specs#5797'
REST Spec PR Author 'xizhamsft'
REST Spec PR Last commit

* .NET SDK Resource Provider:'ContainerService'
REST Spec PR 'Azure/azure-rest-api-specs#5797'
REST Spec PR Author 'xizhamsft'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
* .NET SDK Resource Provider:'ContainerService'
REST Spec PR 'Azure/azure-rest-api-specs#5797'
REST Spec PR Author 'xizhamsft'
REST Spec PR Last commit

* .NET SDK Resource Provider:'ContainerService'
REST Spec PR 'Azure/azure-rest-api-specs#5797'
REST Spec PR Author 'xizhamsft'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants