Skip to content

Update managed cluster upgrades #5789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsgouda merged 2 commits into from
Apr 29, 2019
Merged

Update managed cluster upgrades #5789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eb3d21
Update managed cluster upgrades
gtracer Apr 29, 2019
4964e17
Fix syntax type error
gtracer Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ...crosoft.ContainerService/stable/2019-04-01/examples/ManagedClustersGetUpgradeProfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,13 @@
"name": "agent",
"osType": "Linux",
"upgrades": [
"1.8.1"
{
"kubernetesVersion": "1.7.9"
},
{
"kubernetesVersion": "1.7.11",
"isPreview": true
}
]
}
],
Expand All @@ -26,7 +32,13 @@
"name": "master",
"osType": "Linux",
"upgrades": [
"1.8.1"
{
"kubernetesVersion": "1.7.9",
"isPreview": true
},
{
"kubernetesVersion": "1.7.11"
}
]
}
},
Expand Down
29 changes: 11 additions & 18 deletions ...ervice/resource-manager/Microsoft.ContainerService/stable/2019-04-01/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1822,23 +1822,6 @@
},
"description": "Identity for the managed cluster."
},
"OrchestratorProfile": {
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for a stable version. Were any SDKs published for this spec?

Copy link
Copy Markdown
Contributor Author

@gtracer gtracer Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda thanks for noting this. I don't believe spec 2019-04-01 has been published yet, so it should be ok.
@xizhamsft can you confirm that no SDKs were published for 2019-04-01? Also, Xiaofang, I removed it because I couldn't find any references to it

Copy link
Copy Markdown
Contributor

@xizha162 xizha162 Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda , We have not published the SDK using 2019-04-01 api-version. We do have SDK published for earlier api-versions like 2019-02-01. Would that be a problem?

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no SDKs have been published, we can move forward with these changes

"properties": {
"orchestratorType": {
"type": "string",
"description": "Orchestrator type."
},
"orchestratorVersion": {
"type": "string",
"description": "Orchestrator version (major, minor, patch)."
}
},
"required": [
"orchestratorType",
"orchestratorVersion"
],
"description": "Contains information about orchestrator."
},
"ManagedClusterAccessProfile": {
"allOf": [
{
Expand Down Expand Up @@ -1893,7 +1876,17 @@
"upgrades": {
"type": "array",
"items": {
"type": "string"
"type": "object",
"properties": {
"kubernetesVersion": {
"type": "string",
"description": "Kubernetes version (major, minor, patch)."
},
"isPreview": {
"type": "boolean",
"description": "Whether Kubernetes version is currently in preview."
}
}
},
"description": "List of orchestrator types and versions available for upgrade."
}
Expand Down