Skip to content

Adding support to the LogicApps Workflow Run Delete operation.#5755

Closed
aalevato wants to merge 2 commits intoAzure:masterfrom
aalevato:logicworkflowdeleterun
Closed

Adding support to the LogicApps Workflow Run Delete operation.#5755
aalevato wants to merge 2 commits intoAzure:masterfrom
aalevato:logicworkflowdeleterun

Conversation

@aalevato
Copy link
Contributor

@aalevato aalevato commented Apr 24, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI AutorestCI mentioned this pull request Apr 24, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 24, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 22096ad9bca693763e74814d9cf7b3fdfb3d3f28
  stderr: 'fatal: reference is not a tree: 22096ad9bca693763e74814d9cf7b3fdfb3d3f28'

@AutorestCI AutorestCI mentioned this pull request Apr 24, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 24, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#2748

@azuresdkci azuresdkci requested a review from shahabhijeet April 24, 2019 22:27
@AutorestCI AutorestCI mentioned this pull request Apr 24, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 24, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2455

@AutorestCI AutorestCI mentioned this pull request Apr 24, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 24, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 22096ad9bca693763e74814d9cf7b3fdfb3d3f28
  stderr: 'fatal: reference is not a tree: 22096ad9bca693763e74814d9cf7b3fdfb3d3f28'

@AutorestCI AutorestCI mentioned this pull request Apr 24, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 24, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#3455

@azuresdkci
Copy link
Contributor

azuresdkci commented Apr 24, 2019

Can one of the admins verify this patch?

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 24, 2019
@adxsdknet
.NET SDK Resource Provider:'Logic'
8ecee26 
REST Spec PR 'Azure/azure-rest-api-specs#5755'
REST Spec PR Author 'aalevato'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Apr 24, 2019

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5947
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@8ecee26

@aalevato
Copy link
Contributor Author

aalevato commented Apr 25, 2019

The "model validation" errors being pointed out are not related to any of my changes here. Please disregard them.

@shahabhijeet
Copy link
Contributor

shahabhijeet commented Apr 30, 2019

@sergey-shandar shoudl we be ignoring this error "Bash exited with code '1'." for model validation?

@aalevato aalevato closed this May 7, 2019
@aalevato aalevato reopened this May 7, 2019
This was referenced May 7, 2019
Closed
Closed
Closed
@aalevato
Copy link
Contributor Author

aalevato commented May 7, 2019

@shahabhijeet @sergey-shandar Can we please complete and merge this PR? Thanks!

@shahabhijeet
Copy link
Contributor

shahabhijeet commented May 15, 2019

@sergey-shandar is this ok to merge this with the failures I see?

@shahabhijeet
Copy link
Contributor

shahabhijeet commented Jun 7, 2019

@aalevato atthis point I will wait for @sergey-shandar to approve if it's ok to merge this PR

@aalevato
Copy link
Contributor Author

aalevato commented Jun 7, 2019 via email •
edited
Loading

@shahabhijeet
Copy link
Contributor

shahabhijeet commented Aug 2, 2019

@aalevato please make sure the required CI jobs are green and there are no merge conflicts

@shahabhijeet shahabhijeet removed their assignment Aug 2, 2019
@yungezz
Copy link
Member

yungezz commented Aug 5, 2019

hi @aalevato , are you still on this PR? could you pls resolve conflicts and make sure CI passed, then we can merge it.

@yungezz
Copy link
Member

yungezz commented Aug 12, 2019

@aalevato ping again

@yungezz yungezz self-assigned this Aug 12, 2019
@aalevato
Copy link
Contributor Author

aalevato commented Aug 14, 2019 •
edited
Loading

@shahabhijeet @yungezz I was oncall and couldn't look into it. As soon as I'm done with my current priorities I'll review it (again). However, I must point out that the "Details" links didn't work weeks ago and don't work now (they show a message saying "An Error has Occurred" without details). Plus, please look into the files being merged - I'm just adding documentation and describing the new method we added months ago. I will try again in some days to see if I can do any kind of true investigation on it.

@yungezz
Copy link
Member

yungezz commented Aug 15, 2019

@aalevato can we close the PR for now since it's not ready for merge, and the PR is over 4 months, there're lots of conflict with latest code base already. Pls create new PR when you're ready for review and merge.

@aalevato
Copy link
Contributor Author

aalevato commented Aug 15, 2019

@yungezz No, we can't. I will get back to it and check how complex will be to solve the merge conflicts. Hopefully this time someone will be able to read and address my comments in time and help us get the code merged.

@yungezz
Copy link
Member

yungezz commented Aug 16, 2019

@aalevato thanks for taking care of it. ping us when you're ready for review and merge.

@aalevato
Copy link
Contributor Author

aalevato commented Aug 19, 2019

@yungezz @shahabhijeet If I click on "Checks" or try to drilldown the "Details" of any check error, I get a 500. Is it happening because of the migration, did anything get corrupted? How can I check the conflicts and edit the files online without it?

@aalevato
Copy link
Contributor Author

aalevato commented Aug 19, 2019

@yungezz @shahabhijeet Hey guys - I added a new PR and will abandon this one once merged. Could you please help review and approve the new one? => #6994

@aalevato aalevato mentioned this pull request Aug 19, 2019
Merged
5 tasks
@yungezz yungezz closed this Aug 28, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 28, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 2e13518, Iteration 1)

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@nickweeds2
Microsoft.MobileNetwork DataNetwork and Site can have no properties (#…
ab4dc8e 
…5755)

* Microsoft.MobileNetwork DataNetwork and Site can have no properties

* Fix examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@refortie refortie refortie left review comments

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yungezz yungezz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aalevato @AutorestCI @azuresdkci @adxsdknet @shahabhijeet @yungezz @refortie

Comments