Skip to content

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version preview/2019-05-01-preview #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhendrixMSFT merged 13 commits into from
Apr 22, 2019
Merged

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version preview/2019-05-01-preview #5723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6bc1b8c
Update description of property "destination" in "ImageTemplateFileCus…
Apr 21, 2019
a290d93
Update min and max values of property "buildTimeoutInMinutes"
Apr 21, 2019
9923e7f
Fix a bug to reflect the actual resource naming pattern (which allows…
Apr 21, 2019
4c252d6
Use correct "artifactTags" instead of "tags" for distribute in examples
Apr 21, 2019
6b2ad3c
Fix an example by removing unnecessary field "imageId"
Apr 21, 2019
41c34bc
generate GO SDK for 2019-05-01-preview
Apr 21, 2019
45059cc
Re-generate python SDK
Apr 21, 2019
770176c
fix go sdk for 2019-05-01-preview package
Apr 22, 2019
56e5a9e
Fix example response status codes
Apr 22, 2019
c1299bf
Remove duplicate unreferenced example
Apr 22, 2019
54813d9
Fix update identity example by including identity section in the resp…
Apr 22, 2019
6ff554e
Fix PATCH examples for 202 response
Apr 22, 2019
99fa75e
Fix async operation urls in responses
Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions ...crosoft.VirtualMachineImages/preview/2019-05-01-preview/examples/CreateImageTemplate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"tags": {
"artifactTags": {
"tagName": "value"
}
}
Expand Down Expand Up @@ -61,7 +61,39 @@
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"tags": {
"artifactTags": {
"tagName": "value"
}
}
]
}
}
},
"200": {
"body": {
"id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.VirtualMachineImages/imageTemplates/myImageTemplate",
"name": "myImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"properties": {
"source": {
"type": "ManagedImage",
"imageId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rg1/providers/Microsoft.Compute/images/source_image"
},
"customize": [
{
"type": "Shell",
"name": "Shell Customizer Example",
"scriptUri": "https://example.com/path/to/script.sh"
}
],
"distribute": [
{
"type": "ManagedImage",
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"artifactTags": {
"tagName": "value"
}
}
Expand Down
45 changes: 43 additions & 2 deletions ...ages/preview/2019-05-01-preview/examples/CreateImageTemplateWithUserAssignedIdentity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"tags": {
"artifactTags": {
"tagName": "value"
}
}
Expand Down Expand Up @@ -76,7 +76,48 @@
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"tags": {
"artifactTags": {
"tagName": "value"
}
}
]
}
}
},
"200": {
"body": {
"id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.VirtualMachineImages/imageTemplates/myImageTemplate",
"name": "myImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "UserAssigned",
"userAssignedIdentities": {
"/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
"clientId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000"
}
}
},
"properties": {
"source": {
"type": "ManagedImage",
"imageId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rg1/providers/Microsoft.Compute/images/source_image"
},
"customize": [
{
"type": "Shell",
"name": "Shell Customizer Example",
"scriptUri": "https://example.com/path/to/script.sh"
}
],
"distribute": [
{
"type": "ManagedImage",
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"artifactTags": {
"tagName": "value"
}
}
Expand Down
6 changes: 4 additions & 2 deletions ...crosoft.VirtualMachineImages/preview/2019-05-01-preview/examples/DeleteImageTemplate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
"responses":{
"202": {
"headers": {
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/{subscription-id}/providers/Microsoft.VirtualMachineImages/locations/westus/operations/85506efc-36f7-11e9-a0c2-000d3afd16e3?api-version=2018-02-01-preview"
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/{subscription-id}/providers/Microsoft.VirtualMachineImages/locations/{location}/operations/{operation-id}?api-version=2019-05-01-preview"
}
}
},
"200": {},
"204": {}
}
}
2 changes: 1 addition & 1 deletion .../Microsoft.VirtualMachineImages/preview/2019-05-01-preview/examples/GetImageTemplate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"tags": {
"artifactTags": {
"tagName": "value"
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...icrosoft.VirtualMachineImages/preview/2019-05-01-preview/examples/ListImageTemplates.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"tags": {
"artifactTags": {
"tagName": "value"
}
}
Expand Down Expand Up @@ -64,7 +64,7 @@
"location": "eastus",
"runOutputName": "eus",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/mySecondImage-eus",
"tags": {
"artifactTags": {
"stage": "development"
}
}
Expand Down
5 changes: 2 additions & 3 deletions ...soft.VirtualMachineImages/preview/2019-05-01-preview/examples/ListImageTemplatesByRg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"tags": {
"artifactTags": {
"tagName": "value"
}
}
Expand Down Expand Up @@ -70,8 +70,7 @@
"type": "SharedImage",
"galleryImageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/gallery/baseimages/images/baseimage",
"replicationRegions":[ "eastus", "westus"],
"runOutputName": "gallery",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/baseimage-eus"
"runOutputName": "gallery"
}
]
}
Expand Down
49 changes: 0 additions & 49 deletions ...VirtualMachineImages/preview/2019-05-01-preview/examples/RemoveImageTemplateIdentity.json
View file
Open in desktop

This file was deleted.

5 changes: 3 additions & 2 deletions .../Microsoft.VirtualMachineImages/preview/2019-05-01-preview/examples/RunImageTemplate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
"responses":{
"202":{
"headers": {
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/{subscription-id}/providers/Microsoft.VirtualMachineImages/locations/westus/operations/777b2050-36f8-11e9-b8fa-000d3afd16e3?api-version=2018-02-01-preview"
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/{subscription-id}/providers/Microsoft.VirtualMachineImages/locations/{location}/operations/{operation-id}?api-version=2019-05-01-preview"
}
}
},
"204":{}
}
}
15 changes: 10 additions & 5 deletions ...oft.VirtualMachineImages/preview/2019-05-01-preview/examples/UpdateImageTemplateTags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
"parameters": {
"subscriptionId": "{subscription-id}",
"resourceGroupName": "myResourceGroup",
"imageTemplateName":"myImageTemplate",
"imageTemplateName": "myImageTemplate",
"api-version": "2019-05-01-preview",
"parameters":{
"parameters": {
"tags": {
"new-tag": "new-value"
}
}
},
"responses":{
"responses": {
"200": {
"body": {
"id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.VirtualMachineImages/imageTemplates/myImageTemplate",
Expand Down Expand Up @@ -39,13 +39,18 @@
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"tags": {
"artifactTags": {
"tagName": "value"
}
}
]
}
}
}
},
"202": {
"headers": {
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/{subscription-id}/providers/Microsoft.VirtualMachineImages/locations/{location}/operations/{operation-id}?api-version=2019-05-01-preview"
}
}
}
}
10 changes: 9 additions & 1 deletion ...hineImages/preview/2019-05-01-preview/examples/UpdateImageTemplateToRemoveIdentities.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
"name": "myImageTemplate",
"location": "westus",
"type": "Microsoft.VirtualMachineImages/imageTemplate",
"identity": {
"type": "None"
},
"tags": {
"new-tag": "new-value"
},
Expand All @@ -39,13 +42,18 @@
"location": "1_location",
"runOutputName": "image_it_pir_1",
"imageId": "/subscriptions/{subscription-id}/resourceGroups/rg1/providers/Microsoft.Compute/images/image_it_1",
"tags": {
"artifactTags": {
"tagName": "value"
}
}
]
}
}
},
"202": {
"headers": {
"Azure-AsyncOperation": "https://management.azure.com/subscriptions/{subscription-id}/providers/Microsoft.VirtualMachineImages/locations/{location}/operations/{operation-id}?api-version=2019-05-01-preview"
}
}
}
}
12 changes: 7 additions & 5 deletions ...ource-manager/Microsoft.VirtualMachineImages/preview/2019-05-01-preview/imagebuilder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@
},
"destination": {
"type": "string",
"description": "The absolute path (with existing directory structure) where the file will be uploaded to in the VM"
"description": "The absolute path to a file (with nested directory structures already created) where the file (from sourceUri) will be uploaded to in the VM"
}
}
},
Expand All @@ -727,7 +727,7 @@
"runOutputName": {
"type": "string",
"description": "The name to be used for the associated RunOutput.",
"pattern": "^[A-Za-z0-9-_]{1,64}$"
"pattern": "^[A-Za-z0-9-_.]{1,64}$"
},
"artifactTags": {
"type": "object",
Expand Down Expand Up @@ -914,7 +914,9 @@
},
"buildTimeoutInMinutes": {
"type": "integer",
"description": "Maximum duration to wait while building the image template. Default is 60 minutes."
"minimum": 0,
"maximum": 960,
"description": "Maximum duration to wait while building the image template. Omit or specify 0 to use the default (60 minutes)."
}
},
"required": [
Expand Down Expand Up @@ -1235,7 +1237,7 @@
"required": true,
"type": "string",
"description": "The name of the image Template",
"pattern": "^[A-Za-z0-9-_]{1,64}$",
"pattern": "^[A-Za-z0-9-_.]{1,64}$",
"x-ms-parameter-location": "method"
},
"RunOutputNameParameter": {
Expand All @@ -1244,7 +1246,7 @@
"required": true,
"type": "string",
"description": "The name of the run output",
"pattern": "^[A-Za-z0-9-_]{1,64}$",
"pattern": "^[A-Za-z0-9-_.]{1,64}$",
"x-ms-parameter-location": "method"
},
"LocationParameter": {
Expand Down
10 changes: 10 additions & 0 deletions specification/imagebuilder/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ These settings apply only when `--go` is specified on the command line.
batch:
- tag: package-2018-02
- tag: package-2019-02
- tag: package-preview-2019-05
```

### Tag: package-2018-02
Expand All @@ -33,3 +34,12 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s
``` yaml $(tag) == 'package-2019-02' && $(go)
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2019-02-01-preview/$(namespace)
```

### Tag: package-preview-2019-05

These settings apply only when `--tag=package-preview-2019-05 --go` is specified on the command line.
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag) == 'package-preview-2019-05' && $(go)
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2019-05-01-preview/$(namespace)
```
2 changes: 1 addition & 1 deletion specification/imagebuilder/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ python:
namespace: azure.mgmt.imagebuilder
package-name: azure-mgmt-imagebuilder
clear-output-folder: true
package-version: 0.2.0
package-version: 0.2.1
```

``` yaml $(python) && $(python-mode) == 'update'
Expand Down