Network mar #5578

khannarheams · 2019-04-08T17:05:56Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…01 to version 2019-02-01

…ter-into-network

* Patch call for DDoS Protection plan Removing unreferenced definition Addressing review comments. Setting x-ms-long-running-operation to false Removing tags from Patch call description Fixing the response message description Removing x-ms-long-running-operation from patch fixing the file renames * Adding patch call to 2019-02-01 * fixing date * fixing semantic error * Addressing review comments

Merge master into Network release branch

* Added missing descriptions in Network specs * Add missing x-ms-enum

* Adds base for updating Microsoft.Network from version stable/2018-12-01 to version 2018-12-01 * Updates readme * Updates API version in new specs and examples * Updated VNet Gateways operations: Fix for Azure#4642 * Network: Duplicate tags in readme file. (Azure#5227) * Added missing change. Extended to new API version

… have to check the upper Limit. (Azure#5527) * Swagger has to just enforce a non-negative fileupload limit, need not do the upper limit check * rolling back * Swagger has to just enforce a positive fileUploadLimitInMb, It doesnt have to check the upper Limit.

AutorestCI · 2019-04-08T17:08:15Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 88cbe41e2baaadd334159ac0f2b08bb6133b0bda
  stderr: 'fatal: reference is not a tree: 88cbe41e2baaadd334159ac0f2b08bb6133b0bda'

AutorestCI · 2019-04-08T17:14:27Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 88cbe41e2baaadd334159ac0f2b08bb6133b0bda
  stderr: 'fatal: reference is not a tree: 88cbe41e2baaadd334159ac0f2b08bb6133b0bda'

azuresdkci · 2019-04-08T17:20:28Z

Can one of the admins verify this patch?

AutorestCI · 2019-04-08T17:20:59Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 88cbe41e2baaadd334159ac0f2b08bb6133b0bda
  stderr: 'fatal: reference is not a tree: 88cbe41e2baaadd334159ac0f2b08bb6133b0bda'

AutorestCI · 2019-04-08T17:36:37Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 88cbe41e2baaadd334159ac0f2b08bb6133b0bda
  stderr: 'fatal: reference is not a tree: 88cbe41e2baaadd334159ac0f2b08bb6133b0bda'

dsgouda · 2019-04-08T17:50:32Z

@khannarheams

Please target the appropriate branch
@MikhailTryakhov Please take a look
Is this a duplicate of Add new Nat Gateway resource #5579

nschonni · 2019-04-08T17:48:17Z

...ication/network/resource-manager/Microsoft.Network/stable/2019-02-01/applicationGateway.json

+        "properties": {
+          "x-ms-client-flatten": true,
+          "$ref": "#/definitions/ApplicationGatewaySslPredefinedPolicyPropertiesFormat",
+          "description": "Properties of the application gateway SSDL predefined policy."


SSDL -> SSL?

nschonni · 2019-04-08T17:57:08Z

...ion/network/resource-manager/Microsoft.Network/stable/2019-02-01/webapplicationfirewall.json

+            "modelAsString": true
+          }
+        },
+        "negationConditon": {


Suggested change

"negationConditon": {

"negationCondition": {

AutorestCI · 2019-04-08T18:26:26Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 88cbe41e2baaadd334159ac0f2b08bb6133b0bda
  stderr: 'fatal: reference is not a tree: 88cbe41e2baaadd334159ac0f2b08bb6133b0bda'

…azure-powershell

MikhailTryakhov

please follow our process [https://microsoft.sharepoint.com/teams/WAG/AzureNetworking/_layouts/OneNote.aspx?id=%2Fteams%2FWAG%2FAzureNetworking%2FOneNotes%2FNRP%20migrated&wd=target%28Hydra%20%2B%20SDK.one%7C96F7B95B-A378-4CA5-903B-C88F894873EF%2FSwagger%20-%3E%20SDK%20-%3E%20PowerShell%20Process%20Overview%7C71B816ED-DAE5-4907-94D8-DE7EE13278A0%2F%29](One Note)
please target to network-march-release
please DON'T MAKE functional changes in older API? We're not sure all of them may be supported on the server side
azure firewall just removed "Alert" from swagger, why are you returning this?

MikhailTryakhov and others added 16 commits March 19, 2019 11:34

Adds base for updating Microsoft.Network from version stable/2018-12-…

701b2c8

…01 to version 2019-02-01

Updates readme

5488167

Updates API version in new specs and examples

0aa5541

Remove Alert action from user rules (Azure#5428)

7a5a276

Merge remote-tracking branch 'remotes/upstream/master' into merge-mas…

c07128d

…ter-into-network

Merge pull request Azure#5464 from number213/merge-master-into-network

96ba604

Merge master into Network release branch

Fixed examples for WAFPolicy (Azure#5454)

68cd0d3

Added missing descriptions in Network specs (Azure#5490)

20aa68a

* Added missing descriptions in Network specs * Add missing x-ms-enum

Copy changes for AppGw from 2018-12-01 (Azure#5463)

e6822ab

Correct Azure Firewall Rule Action in Examples (Azure#5514)

ffb2b59

removed unused flag allowglobalreach (Azure#5539)

c72d012

Stub YML config for validating NRP PRs (Azure#5550)

48b78a1

Add new Nat Gateway resource

2bc49d8

khannarheams requested a review from MikhailTryakhov as a code owner April 8, 2019 17:05

AutorestCI mentioned this pull request Apr 8, 2019

[AutoPR network/resource-manager] Network mar Azure/azure-sdk-for-ruby#2389

Closed

Update API version

eafa102

AutorestCI mentioned this pull request Apr 8, 2019

[AutoPR network/resource-manager] Network mar Azure/azure-sdk-for-python#4800

Closed

Update PR comments

fe49a58

azuresdkci assigned dsgouda Apr 8, 2019

azuresdkci requested a review from dsgouda April 8, 2019 17:27

Update nat gateway

a3493db

AutorestCI mentioned this pull request Apr 8, 2019

[AutoPR network/resource-manager] Network mar Azure/azure-sdk-for-go#4492

Closed

Fix json errors

f89b36c

dsgouda added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 8, 2019

Updated nat gateway

7fb944c

nschonni reviewed Apr 8, 2019

View reviewed changes

AutorestCI mentioned this pull request Apr 8, 2019

[AutoPR network/resource-manager] Network mar Azure/azure-sdk-for-java#3325

Closed

khannarheams added 3 commits April 8, 2019 13:04

Update Nat Gateway examples name

c18f034

Update Examples with 202

7627a36

Need to update with latest master since network.csproj is failing on …

938bbbe

…azure-powershell

MikhailTryakhov suggested changes Apr 9, 2019

View reviewed changes

khannarheams closed this Apr 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Network mar #5578

Network mar #5578

Uh oh!

khannarheams commented Apr 8, 2019

Uh oh!

AutorestCI commented Apr 8, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Apr 8, 2019 •

edited

Loading

Uh oh!

azuresdkci commented Apr 8, 2019

Uh oh!

AutorestCI commented Apr 8, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Apr 8, 2019 •

edited

Loading

Uh oh!

dsgouda commented Apr 8, 2019 •

edited

Loading

Uh oh!

nschonni Apr 8, 2019

Uh oh!

nschonni Apr 8, 2019

Uh oh!

AutorestCI commented Apr 8, 2019 •

edited

Loading

Uh oh!

MikhailTryakhov left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Network mar #5578

Network mar #5578

Uh oh!

Conversation

khannarheams commented Apr 8, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Apr 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Apr 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

azuresdkci commented Apr 8, 2019

Uh oh!

AutorestCI commented Apr 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Apr 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

dsgouda commented Apr 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nschonni Apr 8, 2019

Choose a reason for hiding this comment

Uh oh!

nschonni Apr 8, 2019

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Apr 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

MikhailTryakhov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

AutorestCI commented Apr 8, 2019 •

edited

Loading

AutorestCI commented Apr 8, 2019 •

edited

Loading

AutorestCI commented Apr 8, 2019 •

edited

Loading

AutorestCI commented Apr 8, 2019 •

edited

Loading

dsgouda commented Apr 8, 2019 •

edited

Loading

AutorestCI commented Apr 8, 2019 •

edited

Loading