Skip to content

graph: identifierUris should not be required#5425

Merged
lmazuel merged 1 commit intoAzure:masterfrom
yugangw-msft:appiduri
Mar 19, 2019
Merged

graph: identifierUris should not be required#5425
lmazuel merged 1 commit intoAzure:masterfrom
yugangw-msft:appiduri

Conversation

@yugangw-msft
Copy link
Contributor

@yugangw-msft yugangw-msft commented Mar 19, 2019

This should not be required. Portal allows it to be null

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@yugangw-msft
Copy link
Contributor Author

yugangw-msft commented Mar 19, 2019

//CC: @stevengum

@azuresdkci azuresdkci requested a review from veronicagg March 19, 2019 18:00
@azuresdkci
Copy link
Contributor

azuresdkci commented Mar 19, 2019

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Mar 19, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 19, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4574

@AutorestCI AutorestCI mentioned this pull request Mar 19, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 19, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1651

@AutorestCI AutorestCI mentioned this pull request Mar 19, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 19, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2319

@AutorestCI AutorestCI mentioned this pull request Mar 19, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 19, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4971

@AutorestCI AutorestCI mentioned this pull request Mar 19, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 19, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3099

@AutorestCI AutorestCI mentioned this pull request Mar 19, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 19, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4331

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 19, 2019
@adxsdknet
.NET SDK Resource Provider:'Graph.RBAC'
6b3f8ee 
REST Spec PR 'Azure/azure-rest-api-specs#5425'
REST Spec PR Author 'yugangw-msft'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Mar 19, 2019

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5512
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@6b3f8ee

veronicagg
veronicagg suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yugangw-msft could you add the spec owner as reviewer?

lmazuel
lmazuel approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct bug fix:
https://docs.microsoft.com/en-us/previous-versions/azure/ad/graph/api/entity-and-complex-type-reference#application-entity

@lmazuel lmazuel merged commit 2f13167 into Azure:master Mar 19, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel lmazuel approved these changes

+1 more reviewer

@veronicagg veronicagg veronicagg requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@darshanhs90 darshanhs90

@veronicagg veronicagg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yugangw-msft @azuresdkci @AutorestCI @adxsdknet @lmazuel @veronicagg @darshanhs90

Comments