Skip to content

Swagger Changes For Alerts and Alerts Summary as extension resources #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
praries880 merged 7 commits into from
Mar 26, 2019
Merged

Swagger Changes For Alerts and Alerts Summary as extension resources #5384

praries880 merged 7 commits into from
Mar 26, 2019

Conversation

@assing
Copy link
Contributor

@assing assing commented Mar 14, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@azuresdkci azuresdkci requested a review from praries880 March 14, 2019 15:18
@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3723

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

azuresdkci commented Mar 14, 2019

Can one of the admins verify this patch?

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 14, 2019
@sanjaiganesh
Copy link
Contributor

sanjaiganesh commented Mar 15, 2019

Looking to sync up with Ashutosh to understand the resource model

@dsgouda
Copy link
Contributor

dsgouda commented Mar 18, 2019

Rest spec to Net Sdk code generation is not supported for new RPs, they will be onboarded separately. Please do not block on the Automation for azure-sdk-for-net failure for this review.

anthony-c-martin
anthony-c-martin requested changes Mar 19, 2019
View reviewed changes
@praries880
Copy link

praries880 commented Mar 20, 2019

@antmarti-microsoft Can you validate that the latest commit took care of your feedback?

@sanjaiganesh sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 26, 2019
@assing
Copy link
Contributor Author

assing commented Mar 26, 2019

@praries880 I think I can't merge this PR. Can you please merge this PR?

@praries880 praries880 merged commit cc40e3c into Azure:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

+3 more reviewers

@nschonni nschonni nschonni left review comments

@sanjaiganesh sanjaiganesh sanjaiganesh left review comments

@praries880 praries880 praries880 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@praries880 praries880

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@assing @AutorestCI @azuresdkci @sanjaiganesh @dsgouda @praries880 @nschonni @anthony-c-martin