Servicebus : NetworkruleSet by v-Ajnava · Pull Request #5361 · Azure/azure-rest-api-specs

v-Ajnava · 2019-03-11T19:38:55Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

X ] I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…into SBvnetkafka2017

AutorestCI · 2019-03-11T19:39:47Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3633

AutorestCI · 2019-03-11T19:40:06Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1697

azuresdkci · 2019-03-11T19:40:44Z

Can one of the admins verify this patch?

...ification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

REST Spec PR 'Azure/azure-rest-api-specs#5361' REST Spec PR Author 'v-Ajnava' REST Spec PR Last commit

AutorestCI · 2019-03-11T19:44:12Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5012

AutorestCI · 2019-03-11T19:52:49Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2175

AutorestCI · 2019-03-11T20:48:44Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4353

dsgouda · 2019-03-11T21:20:38Z

@jhendrixMSFT I'll take over this one.

AutorestCI · 2019-03-12T02:08:13Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3166

REST Spec PR 'Azure/azure-rest-api-specs#5361' REST Spec PR Author 'v-Ajnava' REST Spec PR Last commit

dsgouda · 2019-03-14T23:15:40Z

startbuild

sanjaiganesh · 2019-03-14T23:44:41Z

...ification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

+      },
+      "allOf": [
+        {
+          "$ref": "#/definitions/Resource"


Resource [](start = 33, length = 8)

Is this a proxy or tracked resource ? #Resolved

its a proxy resource. #Resolved

sanjaiganesh · 2019-03-14T23:45:41Z

...ification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

+          "description": "Value that indicates whether to ignore missing VNet Service Endpoint"
+        }
+      },
+      "description": "The response from the List namespace operation."


The response from the List namespace operation [](start = 22, length = 46)

update ? #Resolved

updated description. #Resolved

sanjaiganesh · 2019-03-14T23:45:49Z

...ification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

+          "default": "Allow"
+        }
+      },
+      "description": "The response from the List namespace operation."


The response from the List namespace operation." [](start = 22, length = 48)

update ? #Resolved

updated description. #Resolved

sanjaiganesh · 2019-03-14T23:47:23Z

...ification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

      },
      "description": "The result of the List migrationConfigurations operation."
+    },
+    "Subnet": {


" [](start = 4, length = 1)

"required" properties not specified for the new types #Resolved

added required property #Resolved

sanjaiganesh · 2019-03-14T23:50:14Z

...viceBus/stable/2017-04-01/examples/NameSpaces/VirtualNetworkRule/SBNetworkRuleSetCreate.json

+    "parameters": {
+      "properties": {
+        "defaultAction": "Deny",
+        "virtualNetworkRules": [


virtualNetworkRules [](start = 9, length = 19)

This is taking arrays.. PUT request MUST replace server-side representation of the resource.. should NOT merge.

you can consider PATCH support if support for partial updates (additions) are desired.

In reply to: 265808072 [](ancestors = 265808072)

yes, its replaces the resource. we are considering the PATCH support in future releases.

sanjaiganesh · 2019-03-14T23:51:42Z

...ification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json

+          }
+        ],
+        "responses": {
+          "200": {


200 [](start = 11, length = 3)

Does this complete synchronously ? just double checking.

sanjaiganesh · 2019-03-14T23:58:08Z

        "description": "Eventhub error response describing why the operation failed.",

ServiceBus ? #Resolved

Refers to: specification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json:2986 in 530b1bf. [](commit_id = 530b1bf, deletion_comment = False)

dsgouda

LGTM

Ajit Navasare (MINDTREE LIMITED) added 2 commits March 11, 2019 11:52

Added NetwruleSet to 2017 version

ac29d95

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

dba02a7

…into SBvnetkafka2017

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-python#4534

Merged

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-js#1512

Closed

azuresdkci assigned jhendrixMSFT Mar 11, 2019

azuresdkci requested a review from jhendrixMSFT March 11, 2019 19:40

dsgouda suggested changes Mar 11, 2019

View reviewed changes

...ification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json Outdated Show resolved Hide resolved

...ification/servicebus/resource-manager/Microsoft.ServiceBus/stable/2017-04-01/servicebus.json Show resolved Hide resolved

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 11, 2019

.NET SDK Resource Provider:'ServiceBus'

79edde2

REST Spec PR 'Azure/azure-rest-api-specs#5361' REST Spec PR Author 'v-Ajnava' REST Spec PR Last commit

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-node#4865

Closed

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-ruby#2308

Merged

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 11, 2019

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-go#4255

Merged

Ajit Navasare (MINDTREE LIMITED) added 2 commits March 11, 2019 14:04

fixed indentation and aded default value to single value enum

dc6cc6f

fixed default for enum

e828e75

This was referenced Mar 11, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-js#1515

Closed

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-node#4867

Closed

dsgouda self-assigned this Mar 11, 2019

jhendrixMSFT removed their assignment Mar 11, 2019

jhendrixMSFT removed their request for review March 11, 2019 21:23

AutorestCI mentioned this pull request Mar 12, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-java#3083

Merged

updated the URI to networkRuleSets as per ARM guideline

530b1bf

AutorestCI mentioned this pull request Mar 13, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-js#1556

Closed

AutorestCI mentioned this pull request Mar 13, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-node#4900

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 13, 2019

.NET SDK Resource Provider:'ServiceBus'

91cc650

REST Spec PR 'Azure/azure-rest-api-specs#5361' REST Spec PR Author 'v-Ajnava' REST Spec PR Last commit

Azure deleted a comment from adxsdknet Mar 14, 2019

sanjaiganesh reviewed Mar 14, 2019

View reviewed changes

sanjaiganesh mentioned this pull request Mar 14, 2019

EventHub: Added NetwrokruleSet API #5364

Merged

5 tasks

sanjaiganesh added the ARMChangesRequested label Mar 14, 2019

updated with review comments resolve

ba179ab

This was referenced Mar 15, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-js#1597

Closed

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-node#4932

Closed

sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 15, 2019

dsgouda approved these changes Mar 20, 2019

View reviewed changes

dsgouda merged commit 7e9794c into Azure:master Mar 21, 2019

This was referenced Mar 21, 2019

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-js#1696

Merged

[AutoPR servicebus/resource-manager] Servicebus : NetworkruleSet Azure/azure-sdk-for-node#5011

Merged

Conversation

v-Ajnava commented Mar 11, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

azuresdkci commented Mar 11, 2019

Uh oh!

Uh oh!

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

dsgouda commented Mar 11, 2019

Uh oh!

AutorestCI commented Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

dsgouda commented Mar 14, 2019

Uh oh!

sanjaiganesh Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

v-Ajnava Mar 15, 2019 • edited by sanjaiganesh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

v-Ajnava Mar 15, 2019 • edited by sanjaiganesh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

v-Ajnava Mar 15, 2019 • edited by sanjaiganesh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

v-Ajnava Mar 15, 2019 • edited by sanjaiganesh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh Mar 14, 2019

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh Mar 14, 2019

Choose a reason for hiding this comment

Uh oh!

v-Ajnava Mar 15, 2019

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh Mar 14, 2019

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 12, 2019 •

edited

Loading

sanjaiganesh Mar 14, 2019 •

edited

Loading

v-Ajnava Mar 15, 2019 •

edited by sanjaiganesh

Loading

sanjaiganesh Mar 14, 2019 •

edited

Loading

v-Ajnava Mar 15, 2019 •

edited by sanjaiganesh

Loading

sanjaiganesh Mar 14, 2019 •

edited

Loading

v-Ajnava Mar 15, 2019 •

edited by sanjaiganesh

Loading

sanjaiganesh Mar 14, 2019 •

edited

Loading

v-Ajnava Mar 15, 2019 •

edited by sanjaiganesh

Loading

sanjaiganesh commented Mar 14, 2019 •

edited

Loading