[Hub Generated] Review request for Microsoft.CostManagement to add version 2019-03-01-preview by ariehf · Pull Request #5359 · Azure/azure-rest-api-specs

ariehf · 2019-03-11T18:42:17Z

Main changes:

Field changes related to CloudConnector,ExternalBillingAccount,ExternalSubscription
Remove API POST: /providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.CostManagement/getEntities
Reformat costmanagement.json with VisualStudio Code
Fix typo Managment -> Management
Fix validation errors in Showback

Details of Field changes:

CloudConnector: renamed providerAccountId to providerBillingAccountId
CloudConnector: added providerBillingAccountDisplayName, externalBillingAccountId
CloudConnector: changed status to be readonly (no longer part of PUT)
CloudConnector: changed PATCH to not take a connector properties, and therefore to be used only for verifying an existing cloudconnector
ExternalBillingAccount: added providerBillingAccountId, connectorId
ExternalBillingAccount: added GET $expand=collectionInfo
ExternalSubscription: added providerBillingAccountId, providerAccountId
ExternalSubscription: added GET $expand=collectionInfo
ManagementGroups/externalSubscription: added $recurse

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2019-03-11T18:42:54Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2019-03-11T18:43:01Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2019-03-11T18:43:28Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2019-03-11T18:43:58Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2160

azuresdkci · 2019-03-11T18:45:49Z

Can one of the admins verify this patch?

AutorestCI · 2019-03-11T19:50:23Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

praries880 · 2019-03-11T20:00:12Z

@AutorestCI regenerate azure-sdk-for-go

...ent/resource-manager/Microsoft.CostManagement/preview/2019-03-01-preview/costmanagement.json

AutorestCI · 2019-03-11T23:23:04Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

praries880 · 2019-03-12T17:16:49Z

@AutorestCI regenerate azure-sdk-for-go

praries880 · 2019-03-12T17:17:24Z

@sergey-shandar Can you look into the issue with the Defrault build issue?

https://azuresdkci.westus2.cloudapp.azure.com/job/DotNetSwaggerToSdkCI/73/

shahabhijeet · 2019-03-13T08:14:40Z

@praries880 ignore failures on "default" job.
We recently renamed the job to "Automation for azure-sdk-for-net"

sanjaiganesh · 2019-03-14T23:32:09Z

Arieh, There are lot of breaking changes and must be done in new api version.

sanjaiganesh · 2019-03-15T19:23:45Z

    "operationId": "CloudConnector_Verify",

why renaming a patch operation as '_verify' , instead of '_update' ?

Refers to: specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2019-03-01-preview/costmanagement.json:1326 in ef9b6d3. [](commit_id = ef9b6d3, deletion_comment = False)

adxsdknet · 2019-03-17T11:43:23Z

Automation for azure-sdk-for-net

A PR has been created for you:
https://github.com/azure/azure-sdk-for-net/pull/-1
.NET SDK Commits:
https://github.com/adxsdknet/azure-sdk-for-net/pull/-1/commits/

ariehf · 2019-03-18T13:04:48Z

    "operationId": "CloudConnector_Verify",
why renaming a patch operation as '_verify' , instead of '_update' ?

Refers to: specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2019-03-01-preview/costmanagement.json:1326 in ef9b6d3. [](commit_id = ef9b6d3, deletion_comment = False)

Renamed _verify to _update

adxsdknet · 2019-03-18T13:09:32Z

Automation for azure-sdk-for-net

A PR has been created for you:
https://github.com/azure/azure-sdk-for-net/pull/-1
.NET SDK Commits:
https://github.com/adxsdknet/azure-sdk-for-net/pull/-1/commits/

praries880 · 2019-03-20T17:35:22Z

@sanjaiganesh / @antmarti-microsoft Can you validate that the latest commits handle the ARM feeback?

...ent/resource-manager/Microsoft.CostManagement/preview/2019-03-01-preview/costmanagement.json

adxsdknet · 2019-03-21T22:40:37Z

Automation for azure-sdk-for-net

A PR has been created for you:
https://github.com/azure/azure-sdk-for-net/pull/-1
.NET SDK Commits:
https://github.com/adxsdknet/azure-sdk-for-net/pull/-1/commits/

CloudConnector,ExternalBillingAccount,ExternalSubscription updates

eaa8fa1

azuresdkci assigned praries880 Mar 11, 2019

azuresdkci requested a review from praries880 March 11, 2019 18:43

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR cost-management/resource-manager] [Hub Generated] Review request for Microsoft.CostManagement to add version 2019-03-01-preview Azure/azure-sdk-for-ruby#2305

Merged

praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 11, 2019

nschonni reviewed Mar 11, 2019

View reviewed changes

...ent/resource-manager/Microsoft.CostManagement/preview/2019-03-01-preview/costmanagement.json Outdated Show resolved Hide resolved

...ent/resource-manager/Microsoft.CostManagement/preview/2019-03-01-preview/costmanagement.json Outdated Show resolved Hide resolved

ariehf added 3 commits March 11, 2019 22:38

Managment -> Management typo fix

59ebf2e

CloudConnector verify

ecc2bbc

CloudConnector status readonly

67f206b

ariehf added 2 commits March 12, 2019 22:07

Fix Showback validation errors

ae7b650

Fix validation errors

28c4744

Azure deleted a comment from dsgouda Mar 13, 2019

Fix Showback validation errors

ef9b6d3

sanjaiganesh added the ARMChangesRequested label Mar 14, 2019

address showback validation issues

008d89a

validation checks

eb335e8

anthony-c-martin reviewed Mar 20, 2019

View reviewed changes

...ent/resource-manager/Microsoft.CostManagement/preview/2019-03-01-preview/costmanagement.json Outdated Show resolved Hide resolved

anthony-c-martin requested changes Mar 21, 2019

View reviewed changes

Remove ExternalSubscription_ManyUpdateManagementGroup

3163a76

anthony-c-martin added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 21, 2019

anthony-c-martin approved these changes Mar 21, 2019

View reviewed changes

praries880 removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 21, 2019

praries880 approved these changes Mar 21, 2019

View reviewed changes

praries880 merged commit 88a9c90 into Azure:master Mar 21, 2019

Conversation

ariehf commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

azuresdkci commented Mar 11, 2019

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

praries880 commented Mar 11, 2019

Uh oh!

Uh oh!

Uh oh!

AutorestCI commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

praries880 commented Mar 12, 2019

Uh oh!

praries880 commented Mar 12, 2019

Uh oh!

shahabhijeet commented Mar 13, 2019

Uh oh!

sanjaiganesh commented Mar 14, 2019

Uh oh!

sanjaiganesh commented Mar 15, 2019

Uh oh!

adxsdknet commented Mar 17, 2019

Automation for azure-sdk-for-net

Uh oh!

ariehf commented Mar 18, 2019

Uh oh!

adxsdknet commented Mar 18, 2019

Automation for azure-sdk-for-net

Uh oh!

praries880 commented Mar 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adxsdknet commented Mar 21, 2019

Automation for azure-sdk-for-net

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Comments

ariehf commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading